diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-03 03:09:03 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-03 03:09:03 +0300 |
commit | a2a712139fc7fa58aa02b143f2767286d28ef28d (patch) | |
tree | b62661ce7c26bfa679bec8f360c99b8214ec4ae5 /spec/controllers | |
parent | edfec24c1d7adefa03568c97b50f730a6196f9d2 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/groups/group_links_controller_spec.rb | 37 |
1 files changed, 28 insertions, 9 deletions
diff --git a/spec/controllers/groups/group_links_controller_spec.rb b/spec/controllers/groups/group_links_controller_spec.rb index 04f2e33b26a..fc015471d5c 100644 --- a/spec/controllers/groups/group_links_controller_spec.rb +++ b/spec/controllers/groups/group_links_controller_spec.rb @@ -13,12 +13,30 @@ describe Groups::GroupLinksController do describe '#create' do let(:shared_with_group_id) { shared_with_group.id } + let(:shared_group_access) { GroupGroupLink.default_access } subject do post(:create, params: { group_id: shared_group, shared_with_group_id: shared_with_group_id, - shared_group_access: GroupGroupLink.default_access }) + shared_group_access: shared_group_access }) + end + + shared_examples 'creates group group link' do + it 'links group with selected group' do + expect { subject }.to change { shared_with_group.shared_groups.include?(shared_group) }.from(false).to(true) + end + + it 'redirects to group links page' do + subject + + expect(response).to(redirect_to(group_group_members_path(shared_group))) + end + + it 'allows access for group member' do + expect { subject }.to( + change { group_member.can?(:read_group, shared_group) }.from(false).to(true)) + end end context 'when user has correct access to both groups' do @@ -31,18 +49,19 @@ describe Groups::GroupLinksController do shared_with_group.add_developer(group_member) end - it 'links group with selected group' do - expect { subject }.to change { shared_with_group.shared_groups.include?(shared_group) }.from(false).to(true) + context 'when default access level is requested' do + include_examples 'creates group group link' end - it 'redirects to group links page' do - subject + context 'when owner access is requested' do + let(:shared_group_access) { Gitlab::Access::OWNER } - expect(response).to(redirect_to(group_group_members_path(shared_group))) - end + include_examples 'creates group group link' - it 'allows access for group member' do - expect { subject }.to change { group_member.can?(:read_group, shared_group) }.from(false).to(true) + it 'allows admin access for group member' do + expect { subject }.to( + change { group_member.can?(:admin_group, shared_group) }.from(false).to(true)) + end end context 'when shared with group id is not present' do |