Remove CommonMetricsImporter patch

Remove CommonMetricsImporter patch and change all references to
CommonMetrics::Importer. Move specs into their appropriate folders. Also
cleans up some common_metric importer namespacing.

1 files changed, 0 insertions, 139 deletions

diff --git a/spec/db/importers/common_metrics_importer_spec.rb b/spec/db/importers/common_metrics_importer_spec.rb
deleted file mode 100644
index 02e7d51c268..00000000000
--- a/spec/db/importers/common_metrics_importer_spec.rb
+++ /dev/null
@@ -1,139 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-require Rails.root.join("db", "importers", "common_metrics_importer.rb")
-
-describe Gitlab::Importers::CommonMetrics::PrometheusMetric do
-  let(:existing_group_titles) do
-    ::PrometheusMetricEnums.group_details.each_with_object({}) do |(key, value), memo|
-      memo[key] = value[:group_title]
-    end
-  end
-
-  it 'group enum equals ::PrometheusMetric' do
-    expect(described_class.groups).to eq(::PrometheusMetric.groups)
-  end
-
-  it 'GROUP_TITLES equals ::PrometheusMetric' do
-    expect(Gitlab::Importers::CommonMetrics::PrometheusMetricEnums.group_titles).to eq(existing_group_titles)
-  end
-end
-
-describe Importers::CommonMetricsImporter do
-  subject { described_class.new }
-
-  context "does import common_metrics.yml" do
-    let(:groups) { subject.content['panel_groups'] }
-    let(:panels) { groups.map { |group| group['panels'] }.flatten }
-    let(:metrics) { panels.map { |group| group['metrics'] }.flatten }
-    let(:metric_ids) { metrics.map { |metric| metric['id'] } }
-
-    before do
-      subject.execute
-    end
-
-    it "has the same amount of groups" do
-      expect(PrometheusMetric.common.group(:group).count.count).to eq(groups.count)
-    end
-
-    it "has the same amount of panels" do
-      expect(PrometheusMetric.common.group(:group, :title).count.count).to eq(panels.count)
-    end
-
-    it "has the same amount of metrics" do
-      expect(PrometheusMetric.common.count).to eq(metrics.count)
-    end
-
-    it "does not have duplicate IDs" do
-      expect(metric_ids).to eq(metric_ids.uniq)
-    end
-
-    it "imports all IDs" do
-      expect(PrometheusMetric.common.pluck(:identifier)).to contain_exactly(*metric_ids)
-    end
-  end
-
-  context "does import common_metrics.yml" do
-    it "when executed from outside of the Rails.root" do
-      Dir.chdir(Dir.tmpdir) do
-        expect { subject.execute }.not_to raise_error
-      end
-
-      expect(PrometheusMetric.common).not_to be_empty
-    end
-  end
-
-  context 'does import properly all fields' do
-    let(:query_identifier) { 'response-metric' }
-    let(:dashboard) do
-      {
-        panel_groups: [{
-          group: 'Response metrics (NGINX Ingress)',
-          panels: [{
-            title: "Throughput",
-            y_label: "Requests / Sec",
-            metrics: [{
-              id: query_identifier,
-              query_range: 'my-query',
-              unit: 'my-unit',
-              label: 'status code'
-            }]
-          }]
-        }]
-      }
-    end
-
-    before do
-      expect(subject).to receive(:content) { dashboard.deep_stringify_keys }
-    end
-
-    shared_examples 'stores metric' do
-      let(:metric) { PrometheusMetric.find_by(identifier: query_identifier) }
-
-      it 'with all data' do
-        expect(metric.group).to eq('nginx_ingress')
-        expect(metric.title).to eq('Throughput')
-        expect(metric.y_label).to eq('Requests / Sec')
-        expect(metric.unit).to eq('my-unit')
-        expect(metric.legend).to eq('status code')
-        expect(metric.query).to eq('my-query')
-      end
-    end
-
-    context 'if ID is missing' do
-      let(:query_identifier) { }
-
-      it 'raises exception' do
-        expect { subject.execute }.to raise_error(Gitlab::Importers::CommonMetrics::Importer::MissingQueryId)
-      end
-    end
-
-    context 'for existing common metric with different ID' do
-      let!(:existing_metric) { create(:prometheus_metric, :common, identifier: 'my-existing-metric') }
-
-      before do
-        subject.execute
-      end
-
-      it_behaves_like 'stores metric' do
-        it 'and existing metric is not changed' do
-          expect(metric).not_to eq(existing_metric)
-        end
-      end
-    end
-
-    context 'when metric with ID exists ' do
-      let!(:existing_metric) { create(:prometheus_metric, :common, identifier: 'response-metric') }
-
-      before do
-        subject.execute
-      end
-
-      it_behaves_like 'stores metric' do
-        it 'and existing metric is changed' do
-          expect(metric).to eq(existing_metric)
-        end
-      end
-    end
-  end
-end