diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-03-23 16:08:39 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-04-03 19:54:48 +0300 |
| commit | 4e3516788fdea3de3c5f06e1981ddc518b05d0fb (patch) | |
| tree | d83183c2dfb8c5082a9d5a9fbcda6a5479c7d9fd /spec/features/admin | |
| parent | ca6a7f1e9c9296317315249de9b8b3803d1c6ddc (diff) | |
Don't use FFaker in factories, use sequences instead
FFaker can generate data that randomly break our test suite. This
simplifies our factories and use sequences which are more predictive.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/features/admin')
| -rw-r--r-- | spec/features/admin/admin_hooks_spec.rb | 2 | ||||
| -rw-r--r-- | spec/features/admin/admin_users_impersonation_tokens_spec.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/spec/features/admin/admin_hooks_spec.rb b/spec/features/admin/admin_hooks_spec.rb index f246997d5a2..570c374a89b 100644 --- a/spec/features/admin/admin_hooks_spec.rb +++ b/spec/features/admin/admin_hooks_spec.rb @@ -26,7 +26,7 @@ describe "Admin::Hooks", feature: true do end describe "New Hook" do - let(:url) { FFaker::Internet.uri('http') } + let(:url) { generate(:url) } it 'adds new hook' do visit admin_hooks_path diff --git a/spec/features/admin/admin_users_impersonation_tokens_spec.rb b/spec/features/admin/admin_users_impersonation_tokens_spec.rb index 9ff5c2f9d40..ff23d486355 100644 --- a/spec/features/admin/admin_users_impersonation_tokens_spec.rb +++ b/spec/features/admin/admin_users_impersonation_tokens_spec.rb @@ -16,7 +16,7 @@ describe 'Admin > Users > Impersonation Tokens', feature: true, js: true do describe "token creation" do it "allows creation of a token" do - name = FFaker::Product.brand + name = 'Hello World' visit admin_user_impersonation_tokens_path(user_id: user.username) fill_in "Name", with: name |