diff options
author | Bryce Johnson <bryce@gitlab.com> | 2017-06-12 21:43:21 +0300 |
---|---|---|
committer | Bryce Johnson <bryce@gitlab.com> | 2017-06-29 19:50:45 +0300 |
commit | 81e9c2842574b10d694a8e29665c77fde7fd6ae5 (patch) | |
tree | c7fad475df58553505885b9e2de9b9543bc6d3f3 /spec/features/expand_collapse_diffs_spec.rb | |
parent | 066a6c8ba8900f0883ee788d901d300850b1ae61 (diff) |
Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.
MR: !12103
Diffstat (limited to 'spec/features/expand_collapse_diffs_spec.rb')
-rw-r--r-- | spec/features/expand_collapse_diffs_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/features/expand_collapse_diffs_spec.rb b/spec/features/expand_collapse_diffs_spec.rb index ea749528c11..d492a15ea17 100644 --- a/spec/features/expand_collapse_diffs_spec.rb +++ b/spec/features/expand_collapse_diffs_spec.rb @@ -129,7 +129,7 @@ feature 'Expand and collapse diffs', js: true, feature: true do before do large_diff.find('.diff-line-num', match: :prefer_exact).hover - large_diff.find('.add-diff-note').click + large_diff.find('.add-diff-note', match: :prefer_exact).click large_diff.find('.note-textarea').send_keys comment_text large_diff.find_button('Comment').click wait_for_requests |