diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-20 17:22:11 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-20 17:22:11 +0300 |
commit | 0c872e02b2c822e3397515ec324051ff540f0cd5 (patch) | |
tree | ce2fb6ce7030e4dad0f4118d21ab6453e5938cdd /spec/features/groups | |
parent | f7e05a6853b12f02911494c4b3fe53d9540d74fc (diff) |
Add latest changes from gitlab-org/gitlab@15-7-stable-eev15.7.0-rc42
Diffstat (limited to 'spec/features/groups')
55 files changed, 127 insertions, 107 deletions
diff --git a/spec/features/groups/activity_spec.rb b/spec/features/groups/activity_spec.rb index 5bac80959b1..7e592b3f48b 100644 --- a/spec/features/groups/activity_spec.rb +++ b/spec/features/groups/activity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group activity page' do +RSpec.describe 'Group activity page', feature_category: :subgroups do let(:user) { create(:group_member, :developer, user: create(:user), group: group).user } let(:group) { create(:group) } let(:path) { activity_group_path(group) } diff --git a/spec/features/groups/board_sidebar_spec.rb b/spec/features/groups/board_sidebar_spec.rb index 10ef28f3fbc..8216bc3249d 100644 --- a/spec/features/groups/board_sidebar_spec.rb +++ b/spec/features/groups/board_sidebar_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Issue Boards', :js do +RSpec.describe 'Group Issue Boards', :js, feature_category: :subgroups do include BoardHelpers let(:group) { create(:group) } diff --git a/spec/features/groups/board_spec.rb b/spec/features/groups/board_spec.rb index aece6d790b5..11ec38f637b 100644 --- a/spec/features/groups/board_spec.rb +++ b/spec/features/groups/board_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Boards' do +RSpec.describe 'Group Boards', feature_category: :team_planning do include DragTo include MobileHelpers include BoardHelpers @@ -35,7 +35,7 @@ RSpec.describe 'Group Boards' do page.within("[data-testid='project-select-dropdown']") do find('button.gl-dropdown-toggle').click - find('.gl-new-dropdown-item button').click + find('.gl-dropdown-item button').click end click_button 'Create issue' diff --git a/spec/features/groups/clusters/user_spec.rb b/spec/features/groups/clusters/user_spec.rb index 6b512323d4d..3e565dd8eab 100644 --- a/spec/features/groups/clusters/user_spec.rb +++ b/spec/features/groups/clusters/user_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'User Cluster', :js do +RSpec.describe 'User Cluster', :js, feature_category: :users do include GoogleApi::CloudPlatformHelpers let(:group) { create(:group) } diff --git a/spec/features/groups/container_registry_spec.rb b/spec/features/groups/container_registry_spec.rb index 7bef2dc9416..11f94967aaf 100644 --- a/spec/features/groups/container_registry_spec.rb +++ b/spec/features/groups/container_registry_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Container Registry', :js do +RSpec.describe 'Container Registry', :js, feature_category: :container_registry do let(:user) { create(:user) } let(:group) { create(:group) } let(:project) { create(:project, namespace: group) } @@ -97,8 +97,6 @@ RSpec.describe 'Container Registry', :js do expect(find('.modal .modal-title')).to have_content _('Remove tag') find('.modal .modal-footer .btn-danger').click end - - it_behaves_like 'rejecting tags destruction for an importing repository on', tags: ['latest'] end end diff --git a/spec/features/groups/crm/contacts/create_spec.rb b/spec/features/groups/crm/contacts/create_spec.rb index b10b2afe35c..860cadd322d 100644 --- a/spec/features/groups/crm/contacts/create_spec.rb +++ b/spec/features/groups/crm/contacts/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Create a CRM contact', :js do +RSpec.describe 'Create a CRM contact', :js, feature_category: :service_desk do let(:user) { create(:user) } let(:group) { create(:group, :crm_enabled) } let!(:organization) { create(:organization, group: group, name: 'GitLab') } diff --git a/spec/features/groups/dependency_proxy_for_containers_spec.rb b/spec/features/groups/dependency_proxy_for_containers_spec.rb index ae721e7b91f..c0456140291 100644 --- a/spec/features/groups/dependency_proxy_for_containers_spec.rb +++ b/spec/features/groups/dependency_proxy_for_containers_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Dependency Proxy for containers', :js do +RSpec.describe 'Group Dependency Proxy for containers', :js, feature_category: :dependency_proxy do include DependencyProxyHelpers include_context 'file upload requests helpers' diff --git a/spec/features/groups/dependency_proxy_spec.rb b/spec/features/groups/dependency_proxy_spec.rb index af9c4a40729..05984d40ea6 100644 --- a/spec/features/groups/dependency_proxy_spec.rb +++ b/spec/features/groups/dependency_proxy_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Dependency Proxy' do +RSpec.describe 'Group Dependency Proxy', feature_category: :dependency_proxy do let(:owner) { create(:user) } let(:reporter) { create(:user) } let(:group) { create(:group) } diff --git a/spec/features/groups/empty_states_spec.rb b/spec/features/groups/empty_states_spec.rb index f1a8f97461a..a37c40f50e0 100644 --- a/spec/features/groups/empty_states_spec.rb +++ b/spec/features/groups/empty_states_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group empty states' do +RSpec.describe 'Group empty states', feature_category: :subgroups do let(:group) { create(:group) } let(:user) { create(:group_member, :developer, user: create(:user), group: group).user } diff --git a/spec/features/groups/group_page_with_external_authorization_service_spec.rb b/spec/features/groups/group_page_with_external_authorization_service_spec.rb index 59a7feb813b..dce5b67d694 100644 --- a/spec/features/groups/group_page_with_external_authorization_service_spec.rb +++ b/spec/features/groups/group_page_with_external_authorization_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'The group page' do +RSpec.describe 'The group page', feature_category: :subgroups do include ExternalAuthorizationServiceHelpers let(:user) { create(:user) } diff --git a/spec/features/groups/group_runners_spec.rb b/spec/features/groups/group_runners_spec.rb index c9d1c69e9e1..ab53ef7c470 100644 --- a/spec/features/groups/group_runners_spec.rb +++ b/spec/features/groups/group_runners_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe "Group Runners" do +RSpec.describe "Group Runners", feature_category: :runner_fleet do include Spec::Support::Helpers::Features::RunnersHelpers include Spec::Support::Helpers::ModalHelpers diff --git a/spec/features/groups/group_settings_spec.rb b/spec/features/groups/group_settings_spec.rb index 81ff0088e1e..fe1b0909c06 100644 --- a/spec/features/groups/group_settings_spec.rb +++ b/spec/features/groups/group_settings_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Edit group settings' do +RSpec.describe 'Edit group settings', feature_category: :subgroups do let(:user) { create(:user) } let(:group) { create(:group, path: 'foo') } @@ -147,7 +147,7 @@ RSpec.describe 'Edit group settings' do selected_group.add_owner(user) end - it 'can successfully transfer the group' do + it 'can successfully transfer the group', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/384966' do visit edit_group_path(selected_group) page.within('[data-testid="transfer-locations-dropdown"]') do diff --git a/spec/features/groups/import_export/connect_instance_spec.rb b/spec/features/groups/import_export/connect_instance_spec.rb index ae03e64cf59..11cc4bb9b37 100644 --- a/spec/features/groups/import_export/connect_instance_spec.rb +++ b/spec/features/groups/import_export/connect_instance_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Import/Export - Connect to another instance', :js do +RSpec.describe 'Import/Export - Connect to another instance', :js, feature_category: :importers do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } @@ -10,74 +10,96 @@ RSpec.describe 'Import/Export - Connect to another instance', :js do group.add_owner(user) end - before do - gitlab_sign_in(user) + context 'when importing group by direct transfer is enabled' do + before do + stub_application_setting(bulk_import_enabled: true) - visit new_group_path + open_import_group + end - click_link 'Import group' - end + context 'when the user provides valid credentials' do + source_url = 'https://gitlab.com' - context 'when the user provides valid credentials' do - source_url = 'https://gitlab.com' + include_context 'bulk imports requests context', source_url - include_context 'bulk imports requests context', source_url + it 'successfully connects to remote instance' do + pat = 'demo-pat' - it 'successfully connects to remote instance' do - pat = 'demo-pat' + expect(page).to have_content 'Import groups from another instance of GitLab' + expect(page).to have_content 'Not all related objects are migrated' - expect(page).to have_content 'Import groups from another instance of GitLab' - expect(page).to have_content 'Not all related objects are migrated' + fill_in :bulk_import_gitlab_url, with: source_url + fill_in :bulk_import_gitlab_access_token, with: pat - fill_in :bulk_import_gitlab_url, with: source_url - fill_in :bulk_import_gitlab_access_token, with: pat + click_on 'Connect instance' - click_on 'Connect instance' + expect(page).to have_content 'Showing 1-1 of 42 groups that you own from %{url}' % { url: source_url } + expect(page).to have_content 'stub-group' - expect(page).to have_content 'Showing 1-1 of 42 groups that you own from %{url}' % { url: source_url } - expect(page).to have_content 'stub-group' + visit '/' - visit '/' + wait_for_all_requests + end + end + + context 'when the user provides invalid url' do + it 'reports an error' do + source_url = 'invalid-url' + pat = 'demo-pat' + + fill_in :bulk_import_gitlab_url, with: source_url + fill_in :bulk_import_gitlab_access_token, with: pat - wait_for_all_requests + click_on 'Connect instance' + + expect(page).to have_content 'Specified URL cannot be used' + end end - end - context 'when the user provides invalid url' do - it 'reports an error' do - source_url = 'invalid-url' - pat = 'demo-pat' + context 'when the user does not fill in source URL' do + it 'reports an error' do + pat = 'demo-pat' - fill_in :bulk_import_gitlab_url, with: source_url - fill_in :bulk_import_gitlab_access_token, with: pat + fill_in :bulk_import_gitlab_access_token, with: pat - click_on 'Connect instance' + click_on 'Connect instance' - expect(page).to have_content 'Specified URL cannot be used' + expect(page).to have_content 'Please fill in GitLab source URL' + end end - end - context 'when the user does not fill in source URL' do - it 'reports an error' do - pat = 'demo-pat' + context 'when the user does not fill in access token' do + it 'reports an error' do + source_url = 'https://gitlab.com' - fill_in :bulk_import_gitlab_access_token, with: pat + fill_in :bulk_import_gitlab_url, with: source_url - click_on 'Connect instance' + click_on 'Connect instance' - expect(page).to have_content 'Please fill in GitLab source URL' + expect(page).to have_content 'Please fill in your personal access token' + end end end - context 'when the user does not fill in access token' do - it 'reports an error' do - source_url = 'https://gitlab.com' - - fill_in :bulk_import_gitlab_url, with: source_url + context 'when importing group by direct transfer is disabled' do + before do + stub_application_setting(bulk_import_enabled: false) - click_on 'Connect instance' + open_import_group + end - expect(page).to have_content 'Please fill in your personal access token' + it 'renders fields and button disabled' do + expect(page).to have_field('GitLab source URL', disabled: true) + expect(page).to have_field('Personal access token', disabled: true) + expect(page).to have_button('Connect instance', disabled: true) end end + + def open_import_group + gitlab_sign_in(user) + + visit new_group_path + + click_link 'Import group' + end end diff --git a/spec/features/groups/import_export/export_file_spec.rb b/spec/features/groups/import_export/export_file_spec.rb index e3cb1ad77a7..885cfa0f595 100644 --- a/spec/features/groups/import_export/export_file_spec.rb +++ b/spec/features/groups/import_export/export_file_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Export', :js do +RSpec.describe 'Group Export', :js, feature_category: :importers do include ExportFileHelper let_it_be(:user) { create(:user) } diff --git a/spec/features/groups/import_export/import_file_spec.rb b/spec/features/groups/import_export/import_file_spec.rb index b69b8bf2c19..f66062b9ac3 100644 --- a/spec/features/groups/import_export/import_file_spec.rb +++ b/spec/features/groups/import_export/import_file_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Import/Export - Group Import', :js do +RSpec.describe 'Import/Export - Group Import', :js, feature_category: :importers do let_it_be(:user) { create(:user) } let_it_be(:import_path) { "#{Dir.tmpdir}/group_import_spec" } diff --git a/spec/features/groups/import_export/migration_history_spec.rb b/spec/features/groups/import_export/migration_history_spec.rb index 243bdcc13a9..f851c5e2ec5 100644 --- a/spec/features/groups/import_export/migration_history_spec.rb +++ b/spec/features/groups/import_export/migration_history_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Import/Export - GitLab migration history', :js do +RSpec.describe 'Import/Export - GitLab migration history', :js, feature_category: :importers do let_it_be(:user) { create(:user) } let_it_be(:user_import_1) { create(:bulk_import, user: user) } diff --git a/spec/features/groups/integrations/user_activates_mattermost_slash_command_spec.rb b/spec/features/groups/integrations/user_activates_mattermost_slash_command_spec.rb index 02aa418cd73..fbdd760f7fb 100644 --- a/spec/features/groups/integrations/user_activates_mattermost_slash_command_spec.rb +++ b/spec/features/groups/integrations/user_activates_mattermost_slash_command_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'User activates the group-level Mattermost Slash Command integration', :js do +RSpec.describe 'User activates the group-level Mattermost Slash Command integration', :js, feature_category: :build do include_context 'group integration activation' before do diff --git a/spec/features/groups/issues_spec.rb b/spec/features/groups/issues_spec.rb index d4e88505118..00c0d4c3ebe 100644 --- a/spec/features/groups/issues_spec.rb +++ b/spec/features/groups/issues_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group issues page' do +RSpec.describe 'Group issues page', feature_category: :subgroups do include FilteredSearchHelpers include DragTo @@ -11,6 +11,10 @@ RSpec.describe 'Group issues page' do let(:project_with_issues_disabled) { create(:project, :issues_disabled, group: group) } let(:path) { issues_group_path(group) } + before do + stub_feature_flags(or_issuable_queries: false) + end + context 'with shared examples', :js do let(:issuable) { create(:issue, project: project, title: "this is my created issuable") } diff --git a/spec/features/groups/labels/create_spec.rb b/spec/features/groups/labels/create_spec.rb index 19433e612ff..5b57e670c1d 100644 --- a/spec/features/groups/labels/create_spec.rb +++ b/spec/features/groups/labels/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Create a group label' do +RSpec.describe 'Create a group label', feature_category: :team_planning do let(:user) { create(:user) } let(:group) { create(:group) } diff --git a/spec/features/groups/labels/edit_spec.rb b/spec/features/groups/labels/edit_spec.rb index cf1729af97d..2cbe44e11bf 100644 --- a/spec/features/groups/labels/edit_spec.rb +++ b/spec/features/groups/labels/edit_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Edit group label' do +RSpec.describe 'Edit group label', feature_category: :team_planning do include Spec::Support::Helpers::ModalHelpers let(:user) { create(:user) } diff --git a/spec/features/groups/labels/index_spec.rb b/spec/features/groups/labels/index_spec.rb index 68f03368989..ea27fa2c5d9 100644 --- a/spec/features/groups/labels/index_spec.rb +++ b/spec/features/groups/labels/index_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group labels' do +RSpec.describe 'Group labels', feature_category: :team_planning do let(:user) { create(:user) } let(:group) { create(:group) } let!(:label) { create(:group_label, group: group) } diff --git a/spec/features/groups/labels/search_labels_spec.rb b/spec/features/groups/labels/search_labels_spec.rb index fbb0acfb923..478d35951f9 100644 --- a/spec/features/groups/labels/search_labels_spec.rb +++ b/spec/features/groups/labels/search_labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Search for labels', :js do +RSpec.describe 'Search for labels', :js, feature_category: :team_planning do let(:user) { create(:user) } let(:group) { create(:group) } let!(:label1) { create(:group_label, title: 'Foo', description: 'Lorem ipsum', group: group) } diff --git a/spec/features/groups/labels/sort_labels_spec.rb b/spec/features/groups/labels/sort_labels_spec.rb index 9d05703aae6..c2410246fe1 100644 --- a/spec/features/groups/labels/sort_labels_spec.rb +++ b/spec/features/groups/labels/sort_labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Sort labels', :js do +RSpec.describe 'Sort labels', :js, feature_category: :team_planning do let(:user) { create(:user) } let(:group) { create(:group) } let!(:label1) { create(:group_label, title: 'Foo', description: 'Lorem ipsum', group: group) } diff --git a/spec/features/groups/labels/subscription_spec.rb b/spec/features/groups/labels/subscription_spec.rb index 231c4b33bee..4d391074e62 100644 --- a/spec/features/groups/labels/subscription_spec.rb +++ b/spec/features/groups/labels/subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Labels subscription' do +RSpec.describe 'Labels subscription', feature_category: :team_planning do let(:user) { create(:user) } let(:group) { create(:group) } let!(:label1) { create(:group_label, group: group, title: 'foo') } diff --git a/spec/features/groups/labels/user_sees_links_to_issuables_spec.rb b/spec/features/groups/labels/user_sees_links_to_issuables_spec.rb index b0508633065..4caf5ba5314 100644 --- a/spec/features/groups/labels/user_sees_links_to_issuables_spec.rb +++ b/spec/features/groups/labels/user_sees_links_to_issuables_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Labels > User sees links to issuables' do +RSpec.describe 'Groups > Labels > User sees links to issuables', feature_category: :team_planning do let_it_be(:group) { create(:group, :public) } before do diff --git a/spec/features/groups/members/filter_members_spec.rb b/spec/features/groups/members/filter_members_spec.rb index 917b35659a6..dc33bb11bea 100644 --- a/spec/features/groups/members/filter_members_spec.rb +++ b/spec/features/groups/members/filter_members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Filter members', :js do +RSpec.describe 'Groups > Members > Filter members', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers let(:user) { create(:user) } diff --git a/spec/features/groups/members/leave_group_spec.rb b/spec/features/groups/members/leave_group_spec.rb index 66f251c859a..cfb1b24bccb 100644 --- a/spec/features/groups/members/leave_group_spec.rb +++ b/spec/features/groups/members/leave_group_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Leave group' do +RSpec.describe 'Groups > Members > Leave group', feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers include Spec::Support::Helpers::ModalHelpers diff --git a/spec/features/groups/members/list_members_spec.rb b/spec/features/groups/members/list_members_spec.rb index b81949da85d..1aea5a76b41 100644 --- a/spec/features/groups/members/list_members_spec.rb +++ b/spec/features/groups/members/list_members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > List members', :js do +RSpec.describe 'Groups > Members > List members', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers let(:user1) { create(:user, name: 'John Doe') } diff --git a/spec/features/groups/members/manage_groups_spec.rb b/spec/features/groups/members/manage_groups_spec.rb index e4252e2f3aa..ee8786a2e36 100644 --- a/spec/features/groups/members/manage_groups_spec.rb +++ b/spec/features/groups/members/manage_groups_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Manage groups', :js do +RSpec.describe 'Groups > Members > Manage groups', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers include Spec::Support::Helpers::Features::InviteMembersModalHelper include Spec::Support::Helpers::ModalHelpers diff --git a/spec/features/groups/members/manage_members_spec.rb b/spec/features/groups/members/manage_members_spec.rb index 5f28afc23f1..4211f2b6265 100644 --- a/spec/features/groups/members/manage_members_spec.rb +++ b/spec/features/groups/members/manage_members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Manage members' do +RSpec.describe 'Groups > Members > Manage members', feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers include Spec::Support::Helpers::Features::InviteMembersModalHelper include Spec::Support::Helpers::ModalHelpers @@ -72,7 +72,7 @@ RSpec.describe 'Groups > Members > Manage members' do visit group_group_members_path(group) - invite_member(user1.name, role: 'Reporter', refresh: false) + invite_member(user1.name, role: 'Reporter') invite_modal = page.find(invite_modal_selector) expect(invite_modal).to have_content("not authorized to update member") diff --git a/spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb b/spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb index 86185b8dd32..e9f80b05fa7 100644 --- a/spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb +++ b/spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Owner adds member with expiration date', :js do +RSpec.describe 'Groups > Members > Owner adds member with expiration date', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers include Spec::Support::Helpers::Features::InviteMembersModalHelper diff --git a/spec/features/groups/members/master_manages_access_requests_spec.rb b/spec/features/groups/members/master_manages_access_requests_spec.rb index 2a17e7d2a5c..951dc59feca 100644 --- a/spec/features/groups/members/master_manages_access_requests_spec.rb +++ b/spec/features/groups/members/master_manages_access_requests_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Maintainer manages access requests' do +RSpec.describe 'Groups > Members > Maintainer manages access requests', feature_category: :subgroups do it_behaves_like 'Maintainer manages access requests' do let(:entity) { create(:group, :public) } let(:members_page_path) { group_group_members_path(entity) } diff --git a/spec/features/groups/members/request_access_spec.rb b/spec/features/groups/members/request_access_spec.rb index f806c7d3704..35eb085a195 100644 --- a/spec/features/groups/members/request_access_spec.rb +++ b/spec/features/groups/members/request_access_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Request access' do +RSpec.describe 'Groups > Members > Request access', feature_category: :subgroups do let(:user) { create(:user) } let(:owner) { create(:user) } let(:group) { create(:group, :public) } diff --git a/spec/features/groups/members/search_members_spec.rb b/spec/features/groups/members/search_members_spec.rb index fe5fed307d7..6b2896b194c 100644 --- a/spec/features/groups/members/search_members_spec.rb +++ b/spec/features/groups/members/search_members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Search group member', :js do +RSpec.describe 'Search group member', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers let(:user) { create :user } diff --git a/spec/features/groups/members/sort_members_spec.rb b/spec/features/groups/members/sort_members_spec.rb index bf8e64fa1e2..4e9adda5f2b 100644 --- a/spec/features/groups/members/sort_members_spec.rb +++ b/spec/features/groups/members/sort_members_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Sort members', :js do +RSpec.describe 'Groups > Members > Sort members', :js, feature_category: :subgroups do include Spec::Support::Helpers::Features::MembersHelpers let(:owner) { create(:user, name: 'John Doe', created_at: 5.days.ago, last_activity_on: Date.today) } diff --git a/spec/features/groups/members/tabs_spec.rb b/spec/features/groups/members/tabs_spec.rb index 2e9f332c0d6..2dc116842b3 100644 --- a/spec/features/groups/members/tabs_spec.rb +++ b/spec/features/groups/members/tabs_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > Members > Tabs', :js do +RSpec.describe 'Groups > Members > Tabs', :js, feature_category: :subgroups do using RSpec::Parameterized::TableSyntax shared_examples 'active "Members" tab' do diff --git a/spec/features/groups/merge_requests_spec.rb b/spec/features/groups/merge_requests_spec.rb index 296b839c8fc..87f1f422e90 100644 --- a/spec/features/groups/merge_requests_spec.rb +++ b/spec/features/groups/merge_requests_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group merge requests page' do +RSpec.describe 'Group merge requests page', feature_category: :code_review do include FilteredSearchHelpers let(:path) { merge_requests_group_path(group) } diff --git a/spec/features/groups/milestone_spec.rb b/spec/features/groups/milestone_spec.rb index 92a40459737..a70a1e2e70b 100644 --- a/spec/features/groups/milestone_spec.rb +++ b/spec/features/groups/milestone_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group milestones' do +RSpec.describe 'Group milestones', feature_category: :subgroups do let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project_empty_repo, group: group) } let_it_be(:user) { create(:group_member, :maintainer, user: create(:user), group: group).user } diff --git a/spec/features/groups/milestones/gfm_autocomplete_spec.rb b/spec/features/groups/milestones/gfm_autocomplete_spec.rb index 1fec6091f1e..8df097dde88 100644 --- a/spec/features/groups/milestones/gfm_autocomplete_spec.rb +++ b/spec/features/groups/milestones/gfm_autocomplete_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'GFM autocomplete', :js do +RSpec.describe 'GFM autocomplete', :js, feature_category: :team_planning do let_it_be(:user) { create(:user, name: '💃speciąl someone💃', username: 'someone.special') } let_it_be(:group) { create(:group, name: 'Ancestor') } let_it_be(:project) { create(:project, :repository, group: group) } diff --git a/spec/features/groups/milestones_sorting_spec.rb b/spec/features/groups/milestones_sorting_spec.rb index 6f3fc72775f..5543938957a 100644 --- a/spec/features/groups/milestones_sorting_spec.rb +++ b/spec/features/groups/milestones_sorting_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Milestones sorting', :js do +RSpec.describe 'Milestones sorting', :js, feature_category: :team_planning do let(:group) { create(:group) } let!(:project) { create(:project_empty_repo, group: group) } let!(:other_project) { create(:project_empty_repo, group: group) } diff --git a/spec/features/groups/navbar_spec.rb b/spec/features/groups/navbar_spec.rb index b3fb563a202..180ccab78bc 100644 --- a/spec/features/groups/navbar_spec.rb +++ b/spec/features/groups/navbar_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group navbar' do +RSpec.describe 'Group navbar', feature_category: :navigation do include NavbarStructureHelper include WikiHelpers diff --git a/spec/features/groups/new_group_page_spec.rb b/spec/features/groups/new_group_page_spec.rb index 6a8af9c31fd..662ef734299 100644 --- a/spec/features/groups/new_group_page_spec.rb +++ b/spec/features/groups/new_group_page_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'New group page', :js do +RSpec.describe 'New group page', :js, feature_category: :subgroups do let(:user) { create(:user) } let(:group) { create(:group) } diff --git a/spec/features/groups/packages_spec.rb b/spec/features/groups/packages_spec.rb index 26338b03349..dd238657fbc 100644 --- a/spec/features/groups/packages_spec.rb +++ b/spec/features/groups/packages_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Packages' do +RSpec.describe 'Group Packages', feature_category: :package_registry do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project, group: group) } diff --git a/spec/features/groups/settings/access_tokens_spec.rb b/spec/features/groups/settings/access_tokens_spec.rb index 198d3a40df2..1bee3be1ddb 100644 --- a/spec/features/groups/settings/access_tokens_spec.rb +++ b/spec/features/groups/settings/access_tokens_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group > Settings > Access Tokens', :js do +RSpec.describe 'Group > Settings > Access Tokens', :js, feature_category: :authentication_and_authorization do include Spec::Support::Helpers::ModalHelpers let_it_be(:user) { create(:user) } diff --git a/spec/features/groups/settings/ci_cd_spec.rb b/spec/features/groups/settings/ci_cd_spec.rb index 50c481c115c..a1acb73178b 100644 --- a/spec/features/groups/settings/ci_cd_spec.rb +++ b/spec/features/groups/settings/ci_cd_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group CI/CD settings' do +RSpec.describe 'Group CI/CD settings', feature_category: :continuous_integration do include WaitForRequests let_it_be(:user) { create(:user) } @@ -23,11 +23,6 @@ RSpec.describe 'Group CI/CD settings' do visit group_settings_ci_cd_path(group) end - it 'displays the new group runners view banner' do - expect(page).to have_content(s_('Runners|New group runners view')) - expect(page).to have_link(href: group_runners_path(group)) - end - it 'has "Enable shared runners for this group" toggle', :js do expect(shared_runners_toggle).to have_content(_('Enable shared runners for this group')) end diff --git a/spec/features/groups/settings/group_badges_spec.rb b/spec/features/groups/settings/group_badges_spec.rb index 5bf736cc7ce..07c8451f8fb 100644 --- a/spec/features/groups/settings/group_badges_spec.rb +++ b/spec/features/groups/settings/group_badges_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Badges' do +RSpec.describe 'Group Badges', feature_category: :subgroups do include WaitForRequests let(:user) { create(:user) } diff --git a/spec/features/groups/settings/manage_applications_spec.rb b/spec/features/groups/settings/manage_applications_spec.rb index 277471cb304..e7b87cda506 100644 --- a/spec/features/groups/settings/manage_applications_spec.rb +++ b/spec/features/groups/settings/manage_applications_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'User manages applications' do +RSpec.describe 'User manages applications', feature_category: :subgroups do let_it_be(:group) { create(:group) } let_it_be(:user) { create(:user) } let_it_be(:new_application_path) { group_settings_applications_path(group) } diff --git a/spec/features/groups/settings/packages_and_registries_spec.rb b/spec/features/groups/settings/packages_and_registries_spec.rb index 7f3f5775559..60aad8452ce 100644 --- a/spec/features/groups/settings/packages_and_registries_spec.rb +++ b/spec/features/groups/settings/packages_and_registries_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Package and registry settings' do +RSpec.describe 'Group Package and registry settings', feature_category: :package_registry do include WaitForRequests let(:user) { create(:user) } diff --git a/spec/features/groups/settings/repository_spec.rb b/spec/features/groups/settings/repository_spec.rb index cd7dcbdb28d..c65a8268a18 100644 --- a/spec/features/groups/settings/repository_spec.rb +++ b/spec/features/groups/settings/repository_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group Repository settings', :js do +RSpec.describe 'Group Repository settings', :js, feature_category: :source_code_management do include WaitForRequests let_it_be(:user) { create(:user) } diff --git a/spec/features/groups/settings/user_searches_in_settings_spec.rb b/spec/features/groups/settings/user_searches_in_settings_spec.rb index fe0dd7cec9a..374ac236e20 100644 --- a/spec/features/groups/settings/user_searches_in_settings_spec.rb +++ b/spec/features/groups/settings/user_searches_in_settings_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'User searches group settings', :js do +RSpec.describe 'User searches group settings', :js, feature_category: :subgroups do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } diff --git a/spec/features/groups/share_lock_spec.rb b/spec/features/groups/share_lock_spec.rb index d8207899e24..2f5a5e6ba16 100644 --- a/spec/features/groups/share_lock_spec.rb +++ b/spec/features/groups/share_lock_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group share with group lock' do +RSpec.describe 'Group share with group lock', feature_category: :subgroups do let(:root_owner) { create(:user) } let(:root_group) { create(:group) } diff --git a/spec/features/groups/show_spec.rb b/spec/features/groups/show_spec.rb index d814906a274..c0af6080d0f 100644 --- a/spec/features/groups/show_spec.rb +++ b/spec/features/groups/show_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Group show page' do +RSpec.describe 'Group show page', feature_category: :subgroups do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } diff --git a/spec/features/groups/user_browse_projects_group_page_spec.rb b/spec/features/groups/user_browse_projects_group_page_spec.rb index 73fde7cafe5..38b879bb5b2 100644 --- a/spec/features/groups/user_browse_projects_group_page_spec.rb +++ b/spec/features/groups/user_browse_projects_group_page_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'User browse group projects page' do +RSpec.describe 'User browse group projects page', feature_category: :subgroups do let(:user) { create :user } let(:group) { create :group } diff --git a/spec/features/groups/user_sees_package_sidebar_spec.rb b/spec/features/groups/user_sees_package_sidebar_spec.rb index ee216488232..64422f5cca5 100644 --- a/spec/features/groups/user_sees_package_sidebar_spec.rb +++ b/spec/features/groups/user_sees_package_sidebar_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > sidebar' do +RSpec.describe 'Groups > sidebar', feature_category: :subgroups do let(:user) { create(:user) } let(:group) { create(:group) } diff --git a/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb b/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb index 4e4c0e509b0..e5e30ed1a55 100644 --- a/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb +++ b/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Groups > User sees users dropdowns in issuables list', :js do +RSpec.describe 'Groups > User sees users dropdowns in issuables list', :js, feature_category: :subgroups do include FilteredSearchHelpers let(:group) { create(:group) } @@ -11,6 +11,7 @@ RSpec.describe 'Groups > User sees users dropdowns in issuables list', :js do let!(:project) { create(:project, group: group) } before do + stub_feature_flags(or_issuable_queries: false) group.add_developer(user_in_dropdown) sign_in(user_in_dropdown) end |