Remove `rbac_clusters` feature flag

Now that Auto DevOps can run in a RBAC enabled cluster from
https://gitlab.com/gitlab-org/gitlab-ce/issues/51942, we can now remove
the FF.

As the flag only governed if UI elements would appear or not when
creating/adding existing clusters; the effect of removing the FF would
be that the checkbox to choose to enable RBAC clusters will now always
appear.

Remove FF stubs from specs

Improve spec context names

2 files changed, 2 insertions, 6 deletions

diff --git a/spec/features/projects/clusters/gcp_spec.rb b/spec/features/projects/clusters/gcp_spec.rb
index edc763ad0ad..8b92b9fc869 100644
--- a/spec/features/projects/clusters/gcp_spec.rb
+++ b/spec/features/projects/clusters/gcp_spec.rb
@@ -84,10 +84,8 @@ describe 'Gcp Cluster', :js do
 
         it_behaves_like 'valid cluster gcp form'
 
-        context 'rbac_clusters feature flag is enabled' do
+        context 'RBAC is enabled for the cluster' do
           before do
-            stub_feature_flags(rbac_clusters: true)
-
             check 'cluster_provider_gcp_attributes_legacy_abac'
           end
 
diff --git a/spec/features/projects/clusters/user_spec.rb b/spec/features/projects/clusters/user_spec.rb
index 2b4998ed5ac..9ae1dba60b5 100644
--- a/spec/features/projects/clusters/user_spec.rb
+++ b/spec/features/projects/clusters/user_spec.rb
@@ -44,10 +44,8 @@ describe 'User Cluster', :js do
 
       it_behaves_like 'valid cluster user form'
 
-      context 'rbac_clusters feature flag is enabled' do
+      context 'RBAC is enabled for the cluster' do
         before do
-          stub_feature_flags(rbac_clusters: true)
-
           check 'cluster_platform_kubernetes_attributes_authorization_type'
         end