diff options
author | Winnie Hellmann <winnie@gitlab.com> | 2018-07-05 09:32:05 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-07-05 09:32:05 +0300 |
commit | 3db2f327594e134729a0ca2f48a748bb28ab7d6c (patch) | |
tree | 661033b988897aaf506c0deaf457c2002e17d51b /spec/features/snippets | |
parent | baab4cddb091c0aa9649fecc340b8b343747ba83 (diff) |
Enable Capybara/FeatureMethods cop
Diffstat (limited to 'spec/features/snippets')
-rw-r--r-- | spec/features/snippets/explore_spec.rb | 8 | ||||
-rw-r--r-- | spec/features/snippets/internal_snippet_spec.rb | 6 | ||||
-rw-r--r-- | spec/features/snippets/public_snippets_spec.rb | 6 | ||||
-rw-r--r-- | spec/features/snippets/search_snippets_spec.rb | 6 | ||||
-rw-r--r-- | spec/features/snippets/show_spec.rb | 2 | ||||
-rw-r--r-- | spec/features/snippets/user_creates_snippet_spec.rb | 12 | ||||
-rw-r--r-- | spec/features/snippets/user_deletes_snippet_spec.rb | 2 | ||||
-rw-r--r-- | spec/features/snippets/user_edits_snippet_spec.rb | 2 | ||||
-rw-r--r-- | spec/features/snippets/user_snippets_spec.rb | 12 |
9 files changed, 28 insertions, 28 deletions
diff --git a/spec/features/snippets/explore_spec.rb b/spec/features/snippets/explore_spec.rb index 835fd90adc8..c08f25875f8 100644 --- a/spec/features/snippets/explore_spec.rb +++ b/spec/features/snippets/explore_spec.rb @@ -1,11 +1,11 @@ require 'rails_helper' -feature 'Explore Snippets' do +describe 'Explore Snippets' do let!(:public_snippet) { create(:personal_snippet, :public) } let!(:internal_snippet) { create(:personal_snippet, :internal) } let!(:private_snippet) { create(:personal_snippet, :private) } - scenario 'User should see snippets that are not private' do + it 'User should see snippets that are not private' do sign_in create(:user) visit explore_snippets_path @@ -14,7 +14,7 @@ feature 'Explore Snippets' do expect(page).not_to have_content(private_snippet.title) end - scenario 'External user should see only public snippets' do + it 'External user should see only public snippets' do sign_in create(:user, :external) visit explore_snippets_path @@ -23,7 +23,7 @@ feature 'Explore Snippets' do expect(page).not_to have_content(private_snippet.title) end - scenario 'Not authenticated user should see only public snippets' do + it 'Not authenticated user should see only public snippets' do visit explore_snippets_path expect(page).to have_content(public_snippet.title) diff --git a/spec/features/snippets/internal_snippet_spec.rb b/spec/features/snippets/internal_snippet_spec.rb index 3a2768c424f..f6215b481dc 100644 --- a/spec/features/snippets/internal_snippet_spec.rb +++ b/spec/features/snippets/internal_snippet_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -feature 'Internal Snippets', :js do +describe 'Internal Snippets', :js do let(:internal_snippet) { create(:personal_snippet, :internal) } describe 'normal user' do @@ -8,13 +8,13 @@ feature 'Internal Snippets', :js do sign_in(create(:user)) end - scenario 'sees internal snippets' do + it 'sees internal snippets' do visit snippet_path(internal_snippet) expect(page).to have_content(internal_snippet.content) end - scenario 'sees raw internal snippets' do + it 'sees raw internal snippets' do visit raw_snippet_path(internal_snippet) expect(page).to have_content(internal_snippet.content) diff --git a/spec/features/snippets/public_snippets_spec.rb b/spec/features/snippets/public_snippets_spec.rb index bdeeca7187e..71c72b98fad 100644 --- a/spec/features/snippets/public_snippets_spec.rb +++ b/spec/features/snippets/public_snippets_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' -feature 'Public Snippets', :js do - scenario 'Unauthenticated user should see public snippets' do +describe 'Public Snippets', :js do + it 'Unauthenticated user should see public snippets' do public_snippet = create(:personal_snippet, :public) visit snippet_path(public_snippet) @@ -10,7 +10,7 @@ feature 'Public Snippets', :js do expect(page).to have_content(public_snippet.content) end - scenario 'Unauthenticated user should see raw public snippets' do + it 'Unauthenticated user should see raw public snippets' do public_snippet = create(:personal_snippet, :public) visit raw_snippet_path(public_snippet) diff --git a/spec/features/snippets/search_snippets_spec.rb b/spec/features/snippets/search_snippets_spec.rb index cd66a2cb20c..c137b0bcd96 100644 --- a/spec/features/snippets/search_snippets_spec.rb +++ b/spec/features/snippets/search_snippets_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' -feature 'Search Snippets' do - scenario 'User searches for snippets by title' do +describe 'Search Snippets' do + it 'User searches for snippets by title' do public_snippet = create(:personal_snippet, :public, title: 'Beginning and Middle') private_snippet = create(:personal_snippet, :private, title: 'Middle and End') @@ -19,7 +19,7 @@ feature 'Search Snippets' do expect(page).to have_link(private_snippet.title) end - scenario 'User searches for snippet contents' do + it 'User searches for snippet contents' do create(:personal_snippet, :public, title: 'Many lined snippet', diff --git a/spec/features/snippets/show_spec.rb b/spec/features/snippets/show_spec.rb index 5a48f5774ca..74b693f3eff 100644 --- a/spec/features/snippets/show_spec.rb +++ b/spec/features/snippets/show_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -feature 'Snippet', :js do +describe 'Snippet', :js do let(:project) { create(:project, :repository) } let(:snippet) { create(:personal_snippet, :public, file_name: file_name, content: content) } diff --git a/spec/features/snippets/user_creates_snippet_spec.rb b/spec/features/snippets/user_creates_snippet_spec.rb index 941765b7578..879c46d7c4e 100644 --- a/spec/features/snippets/user_creates_snippet_spec.rb +++ b/spec/features/snippets/user_creates_snippet_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -feature 'User creates snippet', :js do +describe 'User creates snippet', :js do include DropzoneHelper let(:user) { create(:user) } @@ -18,7 +18,7 @@ feature 'User creates snippet', :js do end end - scenario 'Authenticated user creates a snippet' do + it 'Authenticated user creates a snippet' do fill_form click_button('Create snippet') @@ -32,7 +32,7 @@ feature 'User creates snippet', :js do expect(page).to have_content('Hello World!') end - scenario 'previews a snippet with file' do + it 'previews a snippet with file' do fill_in 'personal_snippet_description', with: 'My Snippet' dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif') find('.js-md-preview-button').click @@ -48,7 +48,7 @@ feature 'User creates snippet', :js do end end - scenario 'uploads a file when dragging into textarea' do + it 'uploads a file when dragging into textarea' do fill_form dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif') @@ -65,7 +65,7 @@ feature 'User creates snippet', :js do expect(reqs.first.status_code).to eq(200) end - scenario 'validation fails for the first time' do + it 'validation fails for the first time' do fill_in 'personal_snippet_title', with: 'My Snippet Title' click_button('Create snippet') @@ -90,7 +90,7 @@ feature 'User creates snippet', :js do expect(reqs.first.status_code).to eq(200) end - scenario 'Authenticated user creates a snippet with + in filename' do + it 'Authenticated user creates a snippet with + in filename' do fill_in 'personal_snippet_title', with: 'My Snippet Title' page.within('.file-editor') do find(:xpath, "//input[@id='personal_snippet_file_name']").set 'snippet+file+name' diff --git a/spec/features/snippets/user_deletes_snippet_spec.rb b/spec/features/snippets/user_deletes_snippet_spec.rb index ae5b883c477..7bdccacb0fa 100644 --- a/spec/features/snippets/user_deletes_snippet_spec.rb +++ b/spec/features/snippets/user_deletes_snippet_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -feature 'User deletes snippet' do +describe 'User deletes snippet' do let(:user) { create(:user) } let(:content) { 'puts "test"' } let(:snippet) { create(:personal_snippet, :public, content: content, author: user) } diff --git a/spec/features/snippets/user_edits_snippet_spec.rb b/spec/features/snippets/user_edits_snippet_spec.rb index 71de6b6bd1c..77f62990158 100644 --- a/spec/features/snippets/user_edits_snippet_spec.rb +++ b/spec/features/snippets/user_edits_snippet_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -feature 'User edits snippet', :js do +describe 'User edits snippet', :js do include DropzoneHelper let(:file_name) { 'test.rb' } diff --git a/spec/features/snippets/user_snippets_spec.rb b/spec/features/snippets/user_snippets_spec.rb index 7bc27486787..e3065a899cc 100644 --- a/spec/features/snippets/user_snippets_spec.rb +++ b/spec/features/snippets/user_snippets_spec.rb @@ -1,23 +1,23 @@ require 'rails_helper' -feature 'User Snippets' do +describe 'User Snippets' do let(:author) { create(:user) } let!(:public_snippet) { create(:personal_snippet, :public, author: author, title: "This is a public snippet") } let!(:internal_snippet) { create(:personal_snippet, :internal, author: author, title: "This is an internal snippet") } let!(:private_snippet) { create(:personal_snippet, :private, author: author, title: "This is a private snippet") } - background do + before do sign_in author visit dashboard_snippets_path end - scenario 'View all of my snippets' do + it 'View all of my snippets' do expect(page).to have_content(public_snippet.title) expect(page).to have_content(internal_snippet.title) expect(page).to have_content(private_snippet.title) end - scenario 'View my public snippets' do + it 'View my public snippets' do page.within('.snippet-scope-menu') do click_link "Public" end @@ -27,7 +27,7 @@ feature 'User Snippets' do expect(page).not_to have_content(private_snippet.title) end - scenario 'View my internal snippets' do + it 'View my internal snippets' do page.within('.snippet-scope-menu') do click_link "Internal" end @@ -37,7 +37,7 @@ feature 'User Snippets' do expect(page).not_to have_content(private_snippet.title) end - scenario 'View my private snippets' do + it 'View my private snippets' do page.within('.snippet-scope-menu') do click_link "Private" end |