Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeinrich Lee Yu <heinrich@gitlab.com>2019-08-07 18:45:23 +0300
committerClement Ho <408677-ClemMakesApps@users.noreply.gitlab.com>2019-08-07 18:45:23 +0300
commitb689ddd9b6d7ebed2f4d014a77ee223df2d3491b (patch)
treec8b0d42bb5d7ab104f7727ef9462b1ec8c96f362 /spec/features/user_opens_link_to_comment_spec.rb
parentaf2edf28259ff1c236af346cfa6c62092afe7391 (diff)
Do not persist notes filter when auto-switching
Send a `persist_filter: false` param to backend when opening links to notes and auto-switching to show all notes
Diffstat (limited to 'spec/features/user_opens_link_to_comment_spec.rb')
-rw-r--r--spec/features/user_opens_link_to_comment_spec.rb5
1 files changed, 5 insertions, 0 deletions
diff --git a/spec/features/user_opens_link_to_comment_spec.rb b/spec/features/user_opens_link_to_comment_spec.rb
index f1e07e55799..9533a4fe40d 100644
--- a/spec/features/user_opens_link_to_comment_spec.rb
+++ b/spec/features/user_opens_link_to_comment_spec.rb
@@ -18,8 +18,13 @@ describe 'User opens link to comment', :js do
visit Gitlab::UrlBuilder.build(note)
+ wait_for_requests
+
expect(page.find('#discussion-filter-dropdown')).to have_content('Show all activity')
expect(page).not_to have_content('Something went wrong while fetching comments')
+
+ # Auto-switching to show all notes shouldn't be persisted
+ expect(user.reload.notes_filter_for(note.noteable)).to eq(UserPreference::NOTES_FILTERS[:only_activity])
end
end