diff options
author | Kamil Trzcinski <ayufan@ayufan.eu> | 2016-06-10 22:45:06 +0300 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2016-06-13 13:09:19 +0300 |
commit | 421be01dabb13cd1f45d0118b4e1be9d33baef61 (patch) | |
tree | f886bfcadb224a9c8d7cc28ed77ec918e3052f29 /spec/features | |
parent | 9281709b41ce5be5637194cda191a6dd76ddd495 (diff) |
Improve design based on review
Diffstat (limited to 'spec/features')
-rw-r--r-- | spec/features/builds_spec.rb | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/spec/features/builds_spec.rb b/spec/features/builds_spec.rb index a5c3f7cc0b0..0fd95295388 100644 --- a/spec/features/builds_spec.rb +++ b/spec/features/builds_spec.rb @@ -106,7 +106,7 @@ describe "Builds" do context 'no expire date defined' do let(:expire_at) { nil } - it 'should not have the Keep button' do + it 'does not have the Keep button' do page.within('.artifacts') do expect(page).not_to have_content 'Keep' end @@ -116,7 +116,7 @@ describe "Builds" do context 'when expire date is defined' do let(:expire_at) { Time.now + 7.days } - it 'should keep artifacts when Keep button is clicked' do + it 'keeps artifacts when Keep button is clicked' do page.within('.artifacts') do expect(page).to have_content 'The artifacts will be removed' click_link 'Keep' @@ -130,7 +130,7 @@ describe "Builds" do context 'when artifacts expired' do let(:expire_at) { Time.now - 7.days } - it 'should not have the Keep button' do + it 'does not have the Keep button' do page.within('.artifacts') do expect(page).to have_content 'The artifacts were removed' expect(page).not_to have_link 'Keep' @@ -150,8 +150,6 @@ describe "Builds" do expect(page).to have_link 'Raw' end end - - context '' end describe "POST /:project/builds/:id/cancel" do |