Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2018-07-31 10:24:19 +0300
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2018-07-31 10:24:19 +0300
commitde8f8cdf068ba4f029539217daccbbf6ccc6c6f6 (patch)
tree139e15ec008e02c2746dfdfef8f9e694075f565d /spec/features
parent719eeb0f49e4200c345ba555b343a65227a3258e (diff)
Improve authentication activity code readability
Diffstat (limited to 'spec/features')
-rw-r--r--spec/features/users/login_spec.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/spec/features/users/login_spec.rb b/spec/features/users/login_spec.rb
index e82978102aa..44758f862a8 100644
--- a/spec/features/users/login_spec.rb
+++ b/spec/features/users/login_spec.rb
@@ -159,6 +159,7 @@ describe 'Login' do
it 'blocks login with invalid code' do
# TODO invalid 2FA code does not generate any events
+ # See gitlab-org/gitlab-ce#49785
enter_code('foo')
@@ -233,7 +234,7 @@ describe 'Login' do
context 'with invalid code' do
it 'blocks login' do
# TODO, invalid two factor authentication does not increment
- # metrics / counters
+ # metrics / counters, see gitlab-org/gitlab-ce#49785
code = codes.sample
expect(user.invalidate_otp_backup_code!(code)).to eq true
@@ -267,7 +268,8 @@ describe 'Login' do
end
it 'signs user in without prompting for second factor' do
- # TODO, OAuth authentication does not fire events
+ # TODO, OAuth authentication does not fire events,
+ # see gitlab-org/gitlab-ce#49786
expect(authentication_metrics)
.to increment(:user_authenticated_counter)