diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-16 21:25:58 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-16 21:25:58 +0300 |
commit | a5f4bba440d7f9ea47046a0a561d49adf0a1e6d4 (patch) | |
tree | fb69158581673816a8cd895f9d352dcb3c678b1e /spec/finders/deployments_finder_spec.rb | |
parent | d16b2e8639e99961de6ddc93909f3bb5c1445ba1 (diff) |
Add latest changes from gitlab-org/gitlab@14-0-stable-eev14.0.0-rc42
Diffstat (limited to 'spec/finders/deployments_finder_spec.rb')
-rw-r--r-- | spec/finders/deployments_finder_spec.rb | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/spec/finders/deployments_finder_spec.rb b/spec/finders/deployments_finder_spec.rb index b294f1117f5..bd03b254f40 100644 --- a/spec/finders/deployments_finder_spec.rb +++ b/spec/finders/deployments_finder_spec.rb @@ -81,16 +81,6 @@ RSpec.describe DeploymentsFinder do it 'returns deployments with matched updated_at' do is_expected.to match_array([deployment_2, deployment_1]) end - - context 'when deployments_finder_implicitly_enforce_ordering_for_updated_at_filter feature flag is disabled' do - before do - stub_feature_flags(deployments_finder_implicitly_enforce_ordering_for_updated_at_filter: false) - end - - it 'returns deployments with matched updated_at' do - is_expected.to match_array([deployment_1, deployment_2]) - end - end end context 'when the environment name is specified' do @@ -244,20 +234,6 @@ RSpec.describe DeploymentsFinder do expect(subject.order_values.first.to_sql).to eq(Deployment.arel_table[:updated_at].asc.to_sql) expect(subject.order_values.second.to_sql).to eq(Deployment.arel_table[:id].asc.to_sql) end - - context 'when deployments_finder_implicitly_enforce_ordering_for_updated_at_filter feature flag is disabled' do - before do - stub_feature_flags(deployments_finder_implicitly_enforce_ordering_for_updated_at_filter: false) - end - - it 'sorts by only one column' do - expect(subject.order_values.size).to eq(1) - end - - it 'sorts by `id`' do - expect(subject.order_values.first.to_sql).to eq(Deployment.arel_table[:id].asc.to_sql) - end - end end context 'when filtering by finished time' do |