Add latest changes from gitlab-org/gitlab@14-0-stable-eev14.0.0-rc42

2 files changed, 253 insertions, 280 deletions

diff --git a/spec/frontend/commit/pipelines/pipelines_spec.js b/spec/frontend/commit/pipelines/pipelines_spec.js
deleted file mode 100644
index fe928a01acf..00000000000
--- a/spec/frontend/commit/pipelines/pipelines_spec.js
+++ /dev/null
@@ -1,280 +0,0 @@
-import '~/commons';
-import MockAdapter from 'axios-mock-adapter';
-import Vue from 'vue';
-import mountComponent from 'helpers/vue_mount_component_helper';
-import Api from '~/api';
-import pipelinesTable from '~/commit/pipelines/pipelines_table.vue';
-import axios from '~/lib/utils/axios_utils';
-
-describe('Pipelines table in Commits and Merge requests', () => {
-  const jsonFixtureName = 'pipelines/pipelines.json';
-  let pipeline;
-  let PipelinesTable;
-  let mock;
-  let vm;
-  const props = {
-    endpoint: 'endpoint.json',
-    emptyStateSvgPath: 'foo',
-    errorStateSvgPath: 'foo',
-  };
-
-  const findRunPipelineBtn = () => vm.$el.querySelector('[data-testid="run_pipeline_button"]');
-  const findRunPipelineBtnMobile = () =>
-    vm.$el.querySelector('[data-testid="run_pipeline_button_mobile"]');
-
-  beforeEach(() => {
-    mock = new MockAdapter(axios);
-
-    const { pipelines } = getJSONFixture(jsonFixtureName);
-
-    PipelinesTable = Vue.extend(pipelinesTable);
-    pipeline = pipelines.find((p) => p.user !== null && p.commit !== null);
-  });
-
-  afterEach(() => {
-    vm.$destroy();
-    mock.restore();
-  });
-
-  describe('successful request', () => {
-    describe('without pipelines', () => {
-      beforeEach(() => {
-        mock.onGet('endpoint.json').reply(200, []);
-
-        vm = mountComponent(PipelinesTable, props);
-      });
-
-      it('should render the empty state', (done) => {
-        setImmediate(() => {
-          expect(vm.$el.querySelector('.empty-state')).toBeDefined();
-          expect(vm.$el.querySelector('.realtime-loading')).toBe(null);
-          expect(vm.$el.querySelector('.js-pipelines-error-state')).toBe(null);
-          done();
-        });
-      });
-    });
-
-    describe('with pipelines', () => {
-      beforeEach(() => {
-        mock.onGet('endpoint.json').reply(200, [pipeline]);
-        vm = mountComponent(PipelinesTable, props);
-      });
-
-      it('should render a table with the received pipelines', (done) => {
-        setImmediate(() => {
-          expect(vm.$el.querySelectorAll('.ci-table .commit').length).toEqual(1);
-          expect(vm.$el.querySelector('.realtime-loading')).toBe(null);
-          expect(vm.$el.querySelector('.empty-state')).toBe(null);
-          expect(vm.$el.querySelector('.js-pipelines-error-state')).toBe(null);
-          done();
-        });
-      });
-
-      describe('with pagination', () => {
-        it('should make an API request when using pagination', (done) => {
-          setImmediate(() => {
-            jest.spyOn(vm, 'updateContent').mockImplementation(() => {});
-
-            vm.store.state.pageInfo = {
-              page: 1,
-              total: 10,
-              perPage: 2,
-              nextPage: 2,
-              totalPages: 5,
-            };
-
-            vm.$nextTick(() => {
-              vm.$el.querySelector('.next-page-item').click();
-
-              expect(vm.updateContent).toHaveBeenCalledWith({ page: '2' });
-              done();
-            });
-          });
-        });
-      });
-    });
-
-    describe('pipeline badge counts', () => {
-      beforeEach(() => {
-        mock.onGet('endpoint.json').reply(200, [pipeline]);
-      });
-
-      it('should receive update-pipelines-count event', (done) => {
-        const element = document.createElement('div');
-        document.body.appendChild(element);
-
-        element.addEventListener('update-pipelines-count', (event) => {
-          expect(event.detail.pipelines).toEqual([pipeline]);
-          done();
-        });
-
-        vm = mountComponent(PipelinesTable, props);
-
-        element.appendChild(vm.$el);
-      });
-    });
-  });
-
-  describe('run pipeline button', () => {
-    let pipelineCopy;
-
-    beforeEach(() => {
-      pipelineCopy = { ...pipeline };
-    });
-
-    describe('when latest pipeline has detached flag', () => {
-      it('renders the run pipeline button', (done) => {
-        pipelineCopy.flags.detached_merge_request_pipeline = true;
-        pipelineCopy.flags.merge_request_pipeline = true;
-
-        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
-
-        vm = mountComponent(PipelinesTable, { ...props });
-
-        setImmediate(() => {
-          expect(findRunPipelineBtn()).not.toBeNull();
-          expect(findRunPipelineBtnMobile()).not.toBeNull();
-          done();
-        });
-      });
-    });
-
-    describe('when latest pipeline does not have detached flag', () => {
-      it('does not render the run pipeline button', (done) => {
-        pipelineCopy.flags.detached_merge_request_pipeline = false;
-        pipelineCopy.flags.merge_request_pipeline = false;
-
-        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
-
-        vm = mountComponent(PipelinesTable, { ...props });
-
-        setImmediate(() => {
-          expect(findRunPipelineBtn()).toBeNull();
-          expect(findRunPipelineBtnMobile()).toBeNull();
-          done();
-        });
-      });
-    });
-
-    describe('on click', () => {
-      const findModal = () =>
-        document.querySelector('#create-pipeline-for-fork-merge-request-modal');
-
-      beforeEach((done) => {
-        pipelineCopy.flags.detached_merge_request_pipeline = true;
-
-        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
-
-        vm = mountComponent(PipelinesTable, {
-          ...props,
-          canRunPipeline: true,
-          projectId: '5',
-          mergeRequestId: 3,
-        });
-
-        jest.spyOn(Api, 'postMergeRequestPipeline').mockReturnValue(Promise.resolve());
-
-        setImmediate(() => {
-          done();
-        });
-      });
-
-      it('on desktop, shows a loading button', (done) => {
-        findRunPipelineBtn().click();
-
-        vm.$nextTick(() => {
-          expect(findModal()).toBeNull();
-
-          expect(findRunPipelineBtn().disabled).toBe(true);
-          expect(findRunPipelineBtn().querySelector('.gl-spinner')).not.toBeNull();
-
-          setImmediate(() => {
-            expect(findRunPipelineBtn().disabled).toBe(false);
-            expect(findRunPipelineBtn().querySelector('.gl-spinner')).toBeNull();
-
-            done();
-          });
-        });
-      });
-
-      it('on mobile, shows a loading button', (done) => {
-        findRunPipelineBtnMobile().click();
-
-        vm.$nextTick(() => {
-          expect(findModal()).toBeNull();
-
-          expect(findModal()).toBeNull();
-          expect(findRunPipelineBtn().querySelector('.gl-spinner')).not.toBeNull();
-
-          setImmediate(() => {
-            expect(findRunPipelineBtn().disabled).toBe(false);
-            expect(findRunPipelineBtn().querySelector('.gl-spinner')).toBeNull();
-
-            done();
-          });
-        });
-      });
-    });
-
-    describe('on click for fork merge request', () => {
-      const findModal = () =>
-        document.querySelector('#create-pipeline-for-fork-merge-request-modal');
-
-      beforeEach((done) => {
-        pipelineCopy.flags.detached_merge_request_pipeline = true;
-
-        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
-
-        vm = mountComponent(PipelinesTable, {
-          ...props,
-          projectId: '5',
-          mergeRequestId: 3,
-          canCreatePipelineInTargetProject: true,
-          sourceProjectFullPath: 'test/parent-project',
-          targetProjectFullPath: 'test/fork-project',
-        });
-
-        jest.spyOn(Api, 'postMergeRequestPipeline').mockReturnValue(Promise.resolve());
-
-        setImmediate(() => {
-          done();
-        });
-      });
-
-      it('on desktop, shows a security warning modal', (done) => {
-        findRunPipelineBtn().click();
-
-        vm.$nextTick(() => {
-          expect(findModal()).not.toBeNull();
-          done();
-        });
-      });
-
-      it('on mobile, shows a security warning modal', (done) => {
-        findRunPipelineBtnMobile().click();
-
-        vm.$nextTick(() => {
-          expect(findModal()).not.toBeNull();
-          done();
-        });
-      });
-    });
-  });
-
-  describe('unsuccessfull request', () => {
-    beforeEach(() => {
-      mock.onGet('endpoint.json').reply(500, []);
-
-      vm = mountComponent(PipelinesTable, props);
-    });
-
-    it('should render error state', (done) => {
-      setImmediate(() => {
-        expect(vm.$el.querySelector('.js-pipelines-error-state')).toBeDefined();
-        expect(vm.$el.querySelector('.realtime-loading')).toBe(null);
-        expect(vm.$el.querySelector('.ci-table')).toBe(null);
-        done();
-      });
-    });
-  });
-});
diff --git a/spec/frontend/commit/pipelines/pipelines_table_spec.js b/spec/frontend/commit/pipelines/pipelines_table_spec.js
new file mode 100644
index 00000000000..4bf6727af3b
--- /dev/null
+++ b/spec/frontend/commit/pipelines/pipelines_table_spec.js
@@ -0,0 +1,253 @@
+import { GlEmptyState, GlLoadingIcon, GlModal, GlTable } from '@gitlab/ui';
+import { mount } from '@vue/test-utils';
+import MockAdapter from 'axios-mock-adapter';
+import { extendedWrapper } from 'helpers/vue_test_utils_helper';
+import waitForPromises from 'helpers/wait_for_promises';
+import Api from '~/api';
+import PipelinesTable from '~/commit/pipelines/pipelines_table.vue';
+import axios from '~/lib/utils/axios_utils';
+
+describe('Pipelines table in Commits and Merge requests', () => {
+  const jsonFixtureName = 'pipelines/pipelines.json';
+  let wrapper;
+  let pipeline;
+  let mock;
+
+  const findRunPipelineBtn = () => wrapper.findByTestId('run_pipeline_button');
+  const findRunPipelineBtnMobile = () => wrapper.findByTestId('run_pipeline_button_mobile');
+  const findLoadingState = () => wrapper.findComponent(GlLoadingIcon);
+  const findEmptyState = () => wrapper.findComponent(GlEmptyState);
+  const findTable = () => wrapper.findComponent(GlTable);
+  const findTableRows = () => wrapper.findAllByTestId('pipeline-table-row');
+  const findModal = () => wrapper.findComponent(GlModal);
+
+  const createComponent = (props = {}) => {
+    wrapper = extendedWrapper(
+      mount(PipelinesTable, {
+        propsData: {
+          endpoint: 'endpoint.json',
+          emptyStateSvgPath: 'foo',
+          errorStateSvgPath: 'foo',
+          ...props,
+        },
+      }),
+    );
+  };
+
+  beforeEach(() => {
+    mock = new MockAdapter(axios);
+
+    const { pipelines } = getJSONFixture(jsonFixtureName);
+
+    pipeline = pipelines.find((p) => p.user !== null && p.commit !== null);
+  });
+
+  afterEach(() => {
+    wrapper.destroy();
+    mock.restore();
+  });
+
+  describe('successful request', () => {
+    describe('without pipelines', () => {
+      beforeEach(async () => {
+        mock.onGet('endpoint.json').reply(200, []);
+
+        createComponent();
+
+        await waitForPromises();
+      });
+
+      it('should render the empty state', () => {
+        expect(findTableRows()).toHaveLength(0);
+        expect(findLoadingState().exists()).toBe(false);
+        expect(findEmptyState().exists()).toBe(false);
+      });
+    });
+
+    describe('with pipelines', () => {
+      beforeEach(async () => {
+        mock.onGet('endpoint.json').reply(200, [pipeline]);
+
+        createComponent();
+
+        await waitForPromises();
+      });
+
+      it('should render a table with the received pipelines', () => {
+        expect(findTable().exists()).toBe(true);
+        expect(findTableRows()).toHaveLength(1);
+        expect(findLoadingState().exists()).toBe(false);
+        expect(findEmptyState().exists()).toBe(false);
+      });
+
+      describe('with pagination', () => {
+        it('should make an API request when using pagination', async () => {
+          jest.spyOn(wrapper.vm, 'updateContent').mockImplementation(() => {});
+
+          await wrapper.setData({
+            store: {
+              state: {
+                pageInfo: {
+                  page: 1,
+                  total: 10,
+                  perPage: 2,
+                  nextPage: 2,
+                  totalPages: 5,
+                },
+              },
+            },
+          });
+
+          wrapper.find('.next-page-item').trigger('click');
+
+          expect(wrapper.vm.updateContent).toHaveBeenCalledWith({ page: '2' });
+        });
+      });
+
+      describe('pipeline badge counts', () => {
+        it('should receive update-pipelines-count event', (done) => {
+          const element = document.createElement('div');
+          document.body.appendChild(element);
+
+          element.addEventListener('update-pipelines-count', (event) => {
+            expect(event.detail.pipelines).toEqual([pipeline]);
+            done();
+          });
+
+          createComponent();
+
+          element.appendChild(wrapper.vm.$el);
+        });
+      });
+    });
+  });
+
+  describe('run pipeline button', () => {
+    let pipelineCopy;
+
+    beforeEach(() => {
+      pipelineCopy = { ...pipeline };
+    });
+
+    describe('when latest pipeline has detached flag', () => {
+      it('renders the run pipeline button', async () => {
+        pipelineCopy.flags.detached_merge_request_pipeline = true;
+        pipelineCopy.flags.merge_request_pipeline = true;
+
+        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
+
+        createComponent();
+
+        await waitForPromises();
+
+        expect(findRunPipelineBtn().exists()).toBe(true);
+        expect(findRunPipelineBtnMobile().exists()).toBe(true);
+      });
+    });
+
+    describe('when latest pipeline does not have detached flag', () => {
+      it('does not render the run pipeline button', async () => {
+        pipelineCopy.flags.detached_merge_request_pipeline = false;
+        pipelineCopy.flags.merge_request_pipeline = false;
+
+        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
+
+        createComponent();
+
+        await waitForPromises();
+
+        expect(findRunPipelineBtn().exists()).toBe(false);
+        expect(findRunPipelineBtnMobile().exists()).toBe(false);
+      });
+    });
+
+    describe('on click', () => {
+      beforeEach(async () => {
+        pipelineCopy.flags.detached_merge_request_pipeline = true;
+
+        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
+
+        createComponent({
+          canRunPipeline: true,
+          projectId: '5',
+          mergeRequestId: 3,
+        });
+
+        jest.spyOn(Api, 'postMergeRequestPipeline').mockReturnValue(Promise.resolve());
+
+        await waitForPromises();
+      });
+
+      it('on desktop, shows a loading button', async () => {
+        await findRunPipelineBtn().trigger('click');
+
+        expect(findRunPipelineBtn().props('loading')).toBe(true);
+
+        await waitForPromises();
+
+        expect(findRunPipelineBtn().props('loading')).toBe(false);
+      });
+
+      it('on mobile, shows a loading button', async () => {
+        await findRunPipelineBtnMobile().trigger('click');
+
+        expect(findRunPipelineBtn().props('loading')).toBe(true);
+
+        await waitForPromises();
+
+        expect(findRunPipelineBtn().props('disabled')).toBe(false);
+        expect(findRunPipelineBtn().props('loading')).toBe(false);
+      });
+    });
+
+    describe('on click for fork merge request', () => {
+      beforeEach(async () => {
+        pipelineCopy.flags.detached_merge_request_pipeline = true;
+
+        mock.onGet('endpoint.json').reply(200, [pipelineCopy]);
+
+        createComponent({
+          projectId: '5',
+          mergeRequestId: 3,
+          canCreatePipelineInTargetProject: true,
+          sourceProjectFullPath: 'test/parent-project',
+          targetProjectFullPath: 'test/fork-project',
+        });
+
+        jest.spyOn(Api, 'postMergeRequestPipeline').mockReturnValue(Promise.resolve());
+
+        await waitForPromises();
+      });
+
+      it('on desktop, shows a security warning modal', async () => {
+        await findRunPipelineBtn().trigger('click');
+
+        await wrapper.vm.$nextTick();
+
+        expect(findModal()).not.toBeNull();
+      });
+
+      it('on mobile, shows a security warning modal', async () => {
+        await findRunPipelineBtnMobile().trigger('click');
+
+        expect(findModal()).not.toBeNull();
+      });
+    });
+  });
+
+  describe('unsuccessfull request', () => {
+    beforeEach(async () => {
+      mock.onGet('endpoint.json').reply(500, []);
+
+      createComponent();
+
+      await waitForPromises();
+    });
+
+    it('should render error state', () => {
+      expect(findEmptyState().text()).toBe(
+        'There was an error fetching the pipelines. Try again in a few moments or contact your support team.',
+      );
+    });
+  });
+});