diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 14:59:07 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 14:59:07 +0300 |
commit | 8b573c94895dc0ac0e1d9d59cf3e8745e8b539ca (patch) | |
tree | 544930fb309b30317ae9797a9683768705d664c4 /spec/frontend/issue_spec.js | |
parent | 4b1de649d0168371549608993deac953eb692019 (diff) |
Add latest changes from gitlab-org/gitlab@13-7-stable-eev13.7.0-rc42
Diffstat (limited to 'spec/frontend/issue_spec.js')
-rw-r--r-- | spec/frontend/issue_spec.js | 202 |
1 files changed, 18 insertions, 184 deletions
diff --git a/spec/frontend/issue_spec.js b/spec/frontend/issue_spec.js index 24020daf728..00595736821 100644 --- a/spec/frontend/issue_spec.js +++ b/spec/frontend/issue_spec.js @@ -1,5 +1,3 @@ -/* eslint-disable one-var, no-use-before-define */ - import $ from 'jquery'; import MockAdapter from 'axios-mock-adapter'; import axios from '~/lib/utils/axios_utils'; @@ -7,59 +5,16 @@ import Issue from '~/issue'; import '~/lib/utils/text_utility'; describe('Issue', () => { + let $boxClosed; + let $boxOpen; let testContext; beforeEach(() => { testContext = {}; }); - let $boxClosed, $boxOpen, $btn; - preloadFixtures('issues/closed-issue.html'); - preloadFixtures('issues/issue-with-task-list.html'); preloadFixtures('issues/open-issue.html'); - preloadFixtures('static/issue_with_mermaid_graph.html'); - - function expectErrorMessage() { - const $flashMessage = $('div.flash-alert'); - - expect($flashMessage).toExist(); - expect($flashMessage).toBeVisible(); - expect($flashMessage).toHaveText('Unable to update this issue at this time.'); - } - - function expectIssueState(isIssueOpen) { - expectVisibility($boxClosed, !isIssueOpen); - expectVisibility($boxOpen, isIssueOpen); - - expect($btn).toHaveText(isIssueOpen ? 'Close issue' : 'Reopen issue'); - } - - function expectNewBranchButtonState(isPending, canCreate) { - if (Issue.$btnNewBranch.length === 0) { - return; - } - - const $available = Issue.$btnNewBranch.find('.available'); - - expect($available).toHaveText('New branch'); - - if (!isPending && canCreate) { - expect($available).toBeVisible(); - } else { - expect($available).toBeHidden(); - } - - const $unavailable = Issue.$btnNewBranch.find('.unavailable'); - - expect($unavailable).toHaveText('New branch unavailable'); - - if (!isPending && !canCreate) { - expect($unavailable).toBeVisible(); - } else { - expect($unavailable).toBeHidden(); - } - } function expectVisibility($element, shouldBeVisible) { if (shouldBeVisible) { @@ -69,7 +24,12 @@ describe('Issue', () => { } } - function findElements(isIssueInitiallyOpen) { + function expectIssueState(isIssueOpen) { + expectVisibility($boxClosed, !isIssueOpen); + expectVisibility($boxOpen, isIssueOpen); + } + + function findElements() { $boxClosed = $('div.status-box-issue-closed'); expect($boxClosed).toExist(); @@ -79,11 +39,6 @@ describe('Issue', () => { expect($boxOpen).toExist(); expect($boxOpen).toHaveText('Open'); - - $btn = $('.js-issuable-close-button'); - - expect($btn).toExist(); - expect($btn).toHaveText(isIssueInitiallyOpen ? 'Close issue' : 'Reopen issue'); } [true, false].forEach(isIssueInitiallyOpen => { @@ -99,25 +54,6 @@ describe('Issue', () => { testContext.$projectIssuesCounter.text('1,001'); } - function mockCloseButtonResponseSuccess(url, response) { - mock.onPut(url).reply(() => { - expectNewBranchButtonState(true, false); - - return [200, response]; - }); - } - - function mockCloseButtonResponseError(url) { - mock.onPut(url).networkError(); - } - - function mockCanCreateBranch(canCreateBranch) { - mock.onGet(/(.*)\/can_create_branch$/).reply(200, { - can_create_branch: canCreateBranch, - suggested_branch_name: 'foo-99', - }); - } - beforeEach(() => { if (isIssueInitiallyOpen) { loadFixtures('issues/open-issue.html'); @@ -130,7 +66,6 @@ describe('Issue', () => { jest.spyOn(axios, 'get'); findElements(isIssueInitiallyOpen); - testContext.$triggeredButton = $btn; }); afterEach(() => { @@ -138,120 +73,19 @@ describe('Issue', () => { $('div.flash-alert').remove(); }); - it(`${action}s the issue`, done => { - mockCloseButtonResponseSuccess(testContext.$triggeredButton.attr('href'), { - id: 34, - }); - mockCanCreateBranch(!isIssueInitiallyOpen); - - setup(); - testContext.$triggeredButton.trigger('click'); - - setImmediate(() => { - expectIssueState(!isIssueInitiallyOpen); - - expect(testContext.$triggeredButton.get(0).getAttribute('disabled')).toBeNull(); - expect(testContext.$projectIssuesCounter.text()).toBe( - isIssueInitiallyOpen ? '1,000' : '1,002', - ); - expectNewBranchButtonState(false, !isIssueInitiallyOpen); - - done(); - }); - }); - - it(`fails to ${action} the issue if saved:false`, done => { - mockCloseButtonResponseSuccess(testContext.$triggeredButton.attr('href'), { - saved: false, - }); - mockCanCreateBranch(isIssueInitiallyOpen); - - setup(); - testContext.$triggeredButton.trigger('click'); - - setImmediate(() => { - expectIssueState(isIssueInitiallyOpen); - - expect(testContext.$triggeredButton.get(0).getAttribute('disabled')).toBeNull(); - expectErrorMessage(); - - expect(testContext.$projectIssuesCounter.text()).toBe('1,001'); - expectNewBranchButtonState(false, isIssueInitiallyOpen); - - done(); - }); - }); - - it(`fails to ${action} the issue if HTTP error occurs`, done => { - mockCloseButtonResponseError(testContext.$triggeredButton.attr('href')); - mockCanCreateBranch(isIssueInitiallyOpen); - - setup(); - testContext.$triggeredButton.trigger('click'); - - setImmediate(() => { - expectIssueState(isIssueInitiallyOpen); - - expect(testContext.$triggeredButton.get(0).getAttribute('disabled')).toBeNull(); - expectErrorMessage(); - - expect(testContext.$projectIssuesCounter.text()).toBe('1,001'); - expectNewBranchButtonState(false, isIssueInitiallyOpen); - - done(); - }); - }); - - it('disables the new branch button if Ajax call fails', () => { - mockCloseButtonResponseError(testContext.$triggeredButton.attr('href')); - mock.onGet(/(.*)\/can_create_branch$/).networkError(); - - setup(); - testContext.$triggeredButton.trigger('click'); - - expectNewBranchButtonState(false, false); - }); - - it('does not trigger Ajax call if new branch button is missing', done => { - mockCloseButtonResponseError(testContext.$triggeredButton.attr('href')); - - document.querySelector('#related-branches').remove(); - document.querySelector('.create-mr-dropdown-wrap').remove(); - + it(`${action}s the issue on dispatch of issuable_vue_app:change event`, () => { setup(); - testContext.$triggeredButton.trigger('click'); - - setImmediate(() => { - expect(axios.get).not.toHaveBeenCalled(); - - done(); - }); - }); - }); - }); - - describe('when not displaying blocked warning', () => { - describe('when clicking a mermaid graph inside an issue description', () => { - let mock; - let spy; - - beforeEach(() => { - loadFixtures('static/issue_with_mermaid_graph.html'); - mock = new MockAdapter(axios); - spy = jest.spyOn(axios, 'put'); - }); - - afterEach(() => { - mock.restore(); - jest.clearAllMocks(); - }); - - it('does not make a PUT request', () => { - Issue.prototype.initIssueBtnEventListeners(); - $('svg a.js-issuable-actions').trigger('click'); + document.dispatchEvent( + new CustomEvent('issuable_vue_app:change', { + detail: { + data: { id: 1 }, + isClosed: isIssueInitiallyOpen, + }, + }), + ); - expect(spy).not.toHaveBeenCalled(); + expectIssueState(!isIssueInitiallyOpen); }); }); }); |