diff options
| author | Arun Kumar Mohan <arunmohandm@gmail.com> | 2019-08-28 13:20:30 +0300 |
|---|---|---|
| committer | Arun Kumar Mohan <arunmohandm@gmail.com> | 2019-08-31 01:08:16 +0300 |
| commit | 9575288f6259e37726c61451478b9c7d5a73b843 (patch) | |
| tree | df4183f84bcafb9b1353865ceaeae0cf5a9ce845 /spec/frontend/vue_shared/components/changed_file_icon_spec.js | |
| parent | c0ff11820228acbc27369e99db9bbf9a80a8405b (diff) | |
Refactor showStagedIcon property's behavior to match its name
Previously, the `showStagedIcon` property was doing the opposite
of what its name suggested. It was rendering the staged icon when
`showStagedIcon` was `false` and rendering the regular icon when
it was `true`.
Diffstat (limited to 'spec/frontend/vue_shared/components/changed_file_icon_spec.js')
| -rw-r--r-- | spec/frontend/vue_shared/components/changed_file_icon_spec.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/spec/frontend/vue_shared/components/changed_file_icon_spec.js b/spec/frontend/vue_shared/components/changed_file_icon_spec.js index 806602877ef..d0586f9e63f 100644 --- a/spec/frontend/vue_shared/components/changed_file_icon_spec.js +++ b/spec/frontend/vue_shared/components/changed_file_icon_spec.js @@ -106,12 +106,10 @@ describe('Changed file icon', () => { expect(findIcon().props('size')).toBe(size); }); - // NOTE: It looks like 'showStagedIcon' behavior is backwards to what the name suggests - // https://gitlab.com/gitlab-org/gitlab-ce/issues/66071 it.each` showStagedIcon | iconName | desc - ${false} | ${'file-modified-solid'} | ${'with showStagedIcon false, renders staged icon'} - ${true} | ${'file-modified'} | ${'with showStagedIcon true, renders regular icon'} + ${true} | ${'file-modified-solid'} | ${'with showStagedIcon true, renders staged icon'} + ${false} | ${'file-modified'} | ${'with showStagedIcon false, renders regular icon'} `('$desc', ({ showStagedIcon, iconName }) => { factory({ file: stagedFile(), |