Add latest changes from gitlab-org/gitlab@13-3-stable-ee

3 files changed, 226 insertions, 0 deletions

diff --git a/spec/graphql/mutations/boards/issues/issue_move_list_spec.rb b/spec/graphql/mutations/boards/issues/issue_move_list_spec.rb
new file mode 100644
index 00000000000..71c43ed826c
--- /dev/null
+++ b/spec/graphql/mutations/boards/issues/issue_move_list_spec.rb
@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Mutations::Boards::Issues::IssueMoveList do
+  let_it_be(:group) { create(:group, :public) }
+  let_it_be(:project) { create(:project, group: group) }
+  let_it_be(:board) { create(:board, group: group) }
+  let_it_be(:user)  { create(:user) }
+  let_it_be(:guest) { create(:user) }
+  let_it_be(:development) { create(:label, project: project, name: 'Development') }
+  let_it_be(:testing) { create(:label, project: project, name: 'Testing') }
+  let_it_be(:list1)   { create(:list, board: board, label: development, position: 0) }
+  let_it_be(:list2)   { create(:list, board: board, label: testing, position: 1) }
+  let_it_be(:issue1) { create(:labeled_issue, project: project, labels: [development]) }
+  let_it_be(:existing_issue1) { create(:labeled_issue, project: project, labels: [testing], relative_position: 10) }
+  let_it_be(:existing_issue2) { create(:labeled_issue, project: project, labels: [testing], relative_position: 50) }
+
+  let(:current_user) { user }
+  let(:mutation) { described_class.new(object: nil, context: { current_user: current_user }, field: nil) }
+  let(:params) { { board: board, project_path: project.full_path, iid: issue1.iid } }
+  let(:move_params) do
+    {
+      from_list_id: list1.id,
+      to_list_id: list2.id,
+      move_before_id: existing_issue2.id,
+      move_after_id: existing_issue1.id
+    }
+  end
+
+  before_all do
+    group.add_maintainer(user)
+    group.add_guest(guest)
+  end
+
+  subject do
+    mutation.resolve(params.merge(move_params))
+  end
+
+  describe '#ready?' do
+    it 'raises an error if required arguments are missing' do
+      expect { mutation.ready?(params) }
+        .to raise_error(Gitlab::Graphql::Errors::ArgumentError, "At least one of the arguments " \
+        "fromListId, toListId, afterId or beforeId is required")
+    end
+
+    it 'raises an error if only one of fromListId and toListId is present' do
+      expect { mutation.ready?(params.merge(from_list_id: list1.id)) }
+        .to raise_error(Gitlab::Graphql::Errors::ArgumentError,
+          'Both fromListId and toListId must be present'
+        )
+    end
+  end
+
+  describe '#resolve' do
+    context 'when user have access to resources' do
+      it 'moves and repositions issue' do
+        subject
+
+        expect(issue1.reload.labels).to eq([testing])
+        expect(issue1.relative_position).to be < existing_issue2.relative_position
+        expect(issue1.relative_position).to be > existing_issue1.relative_position
+      end
+    end
+
+    context 'when user have no access to resources' do
+      shared_examples 'raises a resource not available error' do
+        it { expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) }
+      end
+
+      context 'when user cannot update issue' do
+        let(:current_user) { guest }
+
+        it_behaves_like 'raises a resource not available error'
+      end
+
+      context 'when user cannot access board' do
+        let(:board) { create(:board, group: create(:group, :private)) }
+
+        it_behaves_like 'raises a resource not available error'
+      end
+
+      context 'when passing board_id as nil' do
+        let(:board) { nil }
+
+        it_behaves_like 'raises a resource not available error'
+      end
+    end
+  end
+end
diff --git a/spec/graphql/mutations/boards/lists/create_spec.rb b/spec/graphql/mutations/boards/lists/create_spec.rb
new file mode 100644
index 00000000000..1a881ac81e8
--- /dev/null
+++ b/spec/graphql/mutations/boards/lists/create_spec.rb
@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Mutations::Boards::Lists::Create do
+  include GraphqlHelpers
+
+  let_it_be(:group) { create(:group, :private) }
+  let_it_be(:board) { create(:board, group: group) }
+  let_it_be(:user)  { create(:user) }
+  let_it_be(:guest) { create(:user) }
+
+  let(:current_user) { user }
+  let(:mutation) { described_class.new(object: nil, context: { current_user: current_user }, field: nil) }
+  let(:list_create_params) { {} }
+
+  before_all do
+    group.add_reporter(user)
+    group.add_guest(guest)
+  end
+
+  subject { mutation.resolve(board_id: board.to_global_id.to_s, **list_create_params) }
+
+  describe '#ready?' do
+    it 'raises an error if required arguments are missing' do
+      expect { mutation.ready?({ board_id: 'some id' }) }
+        .to raise_error(Gitlab::Graphql::Errors::ArgumentError,
+                        'one and only one of backlog or labelId is required')
+    end
+
+    it 'raises an error if too many required arguments are specified' do
+      expect { mutation.ready?({ board_id: 'some id', backlog: true, label_id: 'some label' }) }
+        .to raise_error(Gitlab::Graphql::Errors::ArgumentError,
+                        'one and only one of backlog or labelId is required')
+    end
+  end
+
+  describe '#resolve' do
+    context 'with proper permissions' do
+      describe 'backlog list' do
+        let(:list_create_params) { { backlog: true } }
+
+        it 'creates one and only one backlog' do
+          expect { subject }.to change { board.lists.backlog.count }.from(0).to(1)
+          expect(board.lists.backlog.first.list_type).to eq 'backlog'
+
+          backlog_id = board.lists.backlog.first.id
+
+          expect { subject }.not_to change { board.lists.backlog.count }
+          expect(board.lists.backlog.last.id).to eq backlog_id
+        end
+      end
+
+      describe 'label list' do
+        let_it_be(:dev_label) do
+          create(:group_label, title: 'Development', color: '#FFAABB', group: group)
+        end
+
+        let(:list_create_params) { { label_id: dev_label.to_global_id.to_s } }
+
+        it 'creates a new issue board list for labels' do
+          expect { subject }.to change { board.lists.count }.from(1).to(2)
+
+          new_list = subject[:list]
+
+          expect(new_list.title).to eq dev_label.title
+          expect(new_list.position).to eq 0
+        end
+      end
+    end
+
+    context 'without proper permissions' do
+      let(:current_user) { guest }
+
+      it 'raises an error' do
+        expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)
+      end
+    end
+  end
+end
diff --git a/spec/graphql/mutations/boards/lists/update_spec.rb b/spec/graphql/mutations/boards/lists/update_spec.rb
new file mode 100644
index 00000000000..d5d8a2af6bf
--- /dev/null
+++ b/spec/graphql/mutations/boards/lists/update_spec.rb
@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Mutations::Boards::Lists::Update do
+  let_it_be(:group)    { create(:group, :private) }
+  let_it_be(:board)    { create(:board, group: group) }
+  let_it_be(:reporter) { create(:user) }
+  let_it_be(:guest)    { create(:user) }
+  let_it_be(:list)     { create(:list, board: board, position: 0) }
+  let_it_be(:list2)    { create(:list, board: board) }
+  let(:mutation) { described_class.new(object: nil, context: { current_user: current_user }, field: nil) }
+  let(:list_update_params) { { position: 1, collapsed: true } }
+
+  before_all do
+    group.add_reporter(reporter)
+    group.add_guest(guest)
+    list.update_preferences_for(reporter, collapsed: false)
+  end
+
+  subject { mutation.resolve(list: list, **list_update_params) }
+
+  describe '#resolve' do
+    context 'with permission to admin board lists' do
+      let(:current_user) { reporter }
+
+      it 'updates the list position and collapsed state as expected' do
+        subject
+
+        reloaded_list = list.reload
+        expect(reloaded_list.position).to eq(1)
+        expect(reloaded_list.collapsed?(current_user)).to eq(true)
+      end
+    end
+
+    context 'with permission to read board lists' do
+      let(:current_user) { guest }
+
+      it 'updates the list collapsed state but not the list position' do
+        subject
+
+        reloaded_list = list.reload
+        expect(reloaded_list.position).to eq(0)
+        expect(reloaded_list.collapsed?(current_user)).to eq(true)
+      end
+    end
+
+    context 'without permission to read board lists' do
+      let(:current_user) { create(:user) }
+
+      it 'raises Resource Not Found error' do
+        expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)
+      end
+    end
+  end
+end