diff options
author | Robert Speicher <rspeicher@gmail.com> | 2021-01-20 22:34:23 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2021-01-20 22:34:23 +0300 |
commit | 6438df3a1e0fb944485cebf07976160184697d72 (patch) | |
tree | 00b09bfd170e77ae9391b1a2f5a93ef6839f2597 /spec/graphql/mutations | |
parent | 42bcd54d971da7ef2854b896a7b34f4ef8601067 (diff) |
Add latest changes from gitlab-org/gitlab@13-8-stable-eev13.8.0-rc42
Diffstat (limited to 'spec/graphql/mutations')
-rw-r--r-- | spec/graphql/mutations/namespace/package_settings/update_spec.rb | 98 | ||||
-rw-r--r-- | spec/graphql/mutations/releases/create_spec.rb | 7 | ||||
-rw-r--r-- | spec/graphql/mutations/releases/update_spec.rb | 7 |
3 files changed, 101 insertions, 11 deletions
diff --git a/spec/graphql/mutations/namespace/package_settings/update_spec.rb b/spec/graphql/mutations/namespace/package_settings/update_spec.rb new file mode 100644 index 00000000000..bd0d38cb49f --- /dev/null +++ b/spec/graphql/mutations/namespace/package_settings/update_spec.rb @@ -0,0 +1,98 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::Namespace::PackageSettings::Update do + using RSpec::Parameterized::TableSyntax + + let_it_be_with_reload(:namespace) { create(:group) } + let_it_be(:user) { create(:user) } + + let(:params) { { namespace_path: namespace.full_path } } + + specify { expect(described_class).to require_graphql_authorizations(:create_package_settings) } + + describe '#resolve' do + subject { described_class.new(object: namespace, context: { current_user: user }, field: nil).resolve(**params) } + + RSpec.shared_examples 'returning a success' do + it 'returns the namespace package setting with no errors' do + expect(subject).to eq( + package_settings: package_settings, + errors: [] + ) + end + end + + RSpec.shared_examples 'updating the namespace package setting' do + it_behaves_like 'updating the namespace package setting attributes', from: { maven_duplicates_allowed: true, maven_duplicate_exception_regex: 'SNAPSHOT' }, to: { maven_duplicates_allowed: false, maven_duplicate_exception_regex: 'RELEASE' } + + it_behaves_like 'returning a success' + + context 'with invalid params' do + let_it_be(:params) { { namespace_path: namespace.full_path, maven_duplicate_exception_regex: '[' } } + + it_behaves_like 'not creating the namespace package setting' + + it 'doesn\'t update the maven_duplicates_allowed' do + expect { subject } + .not_to change { package_settings.reload.maven_duplicates_allowed } + end + + it 'returns an error' do + expect(subject).to eq( + package_settings: nil, + errors: ['Maven duplicate exception regex not valid RE2 syntax: missing ]: ['] + ) + end + end + end + + RSpec.shared_examples 'denying access to namespace package setting' do + it 'raises Gitlab::Graphql::Errors::ResourceNotAvailable' do + expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + end + + context 'with existing namespace package setting' do + let_it_be(:package_settings) { create(:namespace_package_setting, namespace: namespace) } + let_it_be(:params) { { namespace_path: namespace.full_path, maven_duplicates_allowed: false, maven_duplicate_exception_regex: 'RELEASE' } } + + where(:user_role, :shared_examples_name) do + :maintainer | 'updating the namespace package setting' + :developer | 'updating the namespace package setting' + :reporter | 'denying access to namespace package setting' + :guest | 'denying access to namespace package setting' + :anonymous | 'denying access to namespace package setting' + end + + with_them do + before do + namespace.send("add_#{user_role}", user) unless user_role == :anonymous + end + + it_behaves_like params[:shared_examples_name] + end + end + + context 'without existing namespace package setting' do + let_it_be(:package_settings) { namespace.package_settings } + + where(:user_role, :shared_examples_name) do + :maintainer | 'creating the namespace package setting' + :developer | 'creating the namespace package setting' + :reporter | 'denying access to namespace package setting' + :guest | 'denying access to namespace package setting' + :anonymous | 'denying access to namespace package setting' + end + + with_them do + before do + namespace.send("add_#{user_role}", user) unless user_role == :anonymous + end + + it_behaves_like params[:shared_examples_name] + end + end + end +end diff --git a/spec/graphql/mutations/releases/create_spec.rb b/spec/graphql/mutations/releases/create_spec.rb index d6305691dac..7776f968346 100644 --- a/spec/graphql/mutations/releases/create_spec.rb +++ b/spec/graphql/mutations/releases/create_spec.rb @@ -88,12 +88,9 @@ RSpec.describe Mutations::Releases::Create do it 'creates the release with the correct milestone associations' do expected_milestone_titles = [milestone_12_3.title, milestone_12_4.title] - actual_milestone_titles = new_release.milestones.map { |m| m.title } + actual_milestone_titles = new_release.milestones.order_by_dates_and_title.map { |m| m.title } - # Right now the milestones are returned in a non-deterministic order. - # `match_array` should be updated to `eq` once - # https://gitlab.com/gitlab-org/gitlab/-/issues/259012 is addressed. - expect(actual_milestone_titles).to match_array(expected_milestone_titles) + expect(actual_milestone_titles).to eq(expected_milestone_titles) end describe 'asset links' do diff --git a/spec/graphql/mutations/releases/update_spec.rb b/spec/graphql/mutations/releases/update_spec.rb index 0406e9c96f3..c541afd53a1 100644 --- a/spec/graphql/mutations/releases/update_spec.rb +++ b/spec/graphql/mutations/releases/update_spec.rb @@ -48,12 +48,7 @@ RSpec.describe Mutations::Releases::Update do expect(updated_release.name).to eq(name) unless except_for == :name expect(updated_release.description).to eq(description) unless except_for == :description expect(updated_release.released_at).to eq(released_at) unless except_for == :released_at - - # Right now the milestones are returned in a non-deterministic order. - # Because of this, we need to allow for milestones to be returned in any order. - # Once https://gitlab.com/gitlab-org/gitlab/-/issues/259012 has been - # fixed, this can be updated to expect a specific order. - expect(updated_release.milestones).to match_array([milestone_12_3, milestone_12_4]) unless except_for == :milestones + expect(updated_release.milestones.order_by_dates_and_title).to eq([milestone_12_3, milestone_12_4]) unless except_for == :milestones end end |