diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-20 16:49:51 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-20 16:49:51 +0300 |
commit | 71786ddc8e28fbd3cb3fcc4b3ff15e5962a1c82e (patch) | |
tree | 6a2d93ef3fb2d353bb7739e4b57e6541f51cdd71 /spec/helpers/invite_members_helper_spec.rb | |
parent | a7253423e3403b8c08f8a161e5937e1488f5f407 (diff) |
Add latest changes from gitlab-org/gitlab@15-9-stable-eev15.9.0-rc42
Diffstat (limited to 'spec/helpers/invite_members_helper_spec.rb')
-rw-r--r-- | spec/helpers/invite_members_helper_spec.rb | 52 |
1 files changed, 10 insertions, 42 deletions
diff --git a/spec/helpers/invite_members_helper_spec.rb b/spec/helpers/invite_members_helper_spec.rb index 48e94ec7e98..abf8b65dc1e 100644 --- a/spec/helpers/invite_members_helper_spec.rb +++ b/spec/helpers/invite_members_helper_spec.rb @@ -36,7 +36,8 @@ RSpec.describe InviteMembersHelper do end it 'provides the correct attributes' do - expect(helper.common_invite_group_modal_data(group, GroupMember, 'false')).to include({ groups_filter: 'descendant_groups', parent_id: group.id }) + expect(helper.common_invite_group_modal_data(group, GroupMember, 'false')) + .to include({ groups_filter: 'descendant_groups', parent_id: group.id }) end end @@ -46,7 +47,8 @@ RSpec.describe InviteMembersHelper do end it 'does not return filter attributes' do - expect(helper.common_invite_group_modal_data(project.group, ProjectMember, 'true').keys).not_to include(:groups_filter, :parent_id) + expect(helper.common_invite_group_modal_data(project.group, ProjectMember, 'true').keys) + .not_to include(:groups_filter, :parent_id) end end end @@ -64,7 +66,7 @@ RSpec.describe InviteMembersHelper do expect(helper.common_invite_modal_dataset(project)).to include(attributes) end - context 'tasks_to_be_done' do + context 'with tasks_to_be_done' do using RSpec::Parameterized::TableSyntax subject(:output) { helper.common_invite_modal_dataset(source) } @@ -79,9 +81,7 @@ RSpec.describe InviteMembersHelper do { value: :issues, text: 'Create/import issues (tickets) to collaborate on ideas and plan work' } ].to_json ) - expect(output[:projects]).to eq( - [{ id: project.id, title: project.title }].to_json - ) + expect(output[:projects]).to eq([{ id: project.id, title: project.title }].to_json) expect(output[:new_project_path]).to eq( source.is_a?(Project) ? '' : new_project_path(namespace_id: group.id) ) @@ -93,8 +93,8 @@ RSpec.describe InviteMembersHelper do end end - context 'inviting members for tasks' do - where(:open_modal_param_present?, :logged_in?, :expected?) do + context 'when inviting members for tasks' do + where(:open_modal_param?, :logged_in?, :expected?) do true | true | true true | false | false false | true | false @@ -104,7 +104,7 @@ RSpec.describe InviteMembersHelper do with_them do before do allow(helper).to receive(:current_user).and_return(developer) if logged_in? - allow(helper).to receive(:params).and_return({ open_modal: 'invite_members_for_task' }) if open_modal_param_present? + allow(helper).to receive(:params).and_return({ open_modal: 'invite_members_for_task' }) if open_modal_param? end context 'when the source is a project' do @@ -120,36 +120,6 @@ RSpec.describe InviteMembersHelper do end end end - - context 'the invite_for_help_continuous_onboarding experiment' do - where(:invite_for_help_continuous_onboarding?, :logged_in?, :expected?) do - true | true | true - true | false | false - false | true | false - false | false | false - end - - with_them do - before do - allow(helper).to receive(:current_user).and_return(developer) if logged_in? - stub_experiments(invite_for_help_continuous_onboarding: :candidate) if invite_for_help_continuous_onboarding? - end - - context 'when the source is a project' do - let_it_be(:source) { project } - - it_behaves_like 'including the tasks to be done attributes' - end - - context 'when the source is a group' do - let_it_be(:source) { group } - - let(:expected?) { false } - - it_behaves_like 'including the tasks to be done attributes' - end - end - end end end @@ -172,11 +142,9 @@ RSpec.describe InviteMembersHelper do end context 'when the user can not manage project members' do - before do + it 'returns false' do expect(helper).to receive(:can?).with(owner, :admin_project_member, project).and_return(false) - end - it 'returns false' do expect(helper.can_invite_members_for_project?(project)).to eq false end end |