diff options
author | jakeburden <jburden@gitlab.com> | 2019-08-31 01:16:39 +0300 |
---|---|---|
committer | jakeburden <jburden@gitlab.com> | 2019-09-03 23:40:38 +0300 |
commit | 90dc19e9f0be8ac530b5e5e042791143ce0ba0ce (patch) | |
tree | d29578ef53dea5faefb39eaddf7157d6a664e417 /spec/helpers | |
parent | 5c25a757dcdeb9aae38744ed8b43832ff51e3dcb (diff) |
Create and use external_link helper
Creates a helper method that takes body text and a url.
The output is a external link with icon.
It contains the noopenner noreferrer attributes for security.
Usage: external_link(domain.title, domain.url)
Add rspec test for ExternalLinkHelper
Add changelog for MR 32130
Diffstat (limited to 'spec/helpers')
-rw-r--r-- | spec/helpers/external_link_helper_spec.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/spec/helpers/external_link_helper_spec.rb b/spec/helpers/external_link_helper_spec.rb new file mode 100644 index 00000000000..60ad188e98b --- /dev/null +++ b/spec/helpers/external_link_helper_spec.rb @@ -0,0 +1,12 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe ExternalLinkHelper do + include IconsHelper + + it 'returns external link with icon' do + expect(external_link('https://gitlab.com', 'https://gitlab.com').to_s) + .to eq('<a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">https://gitlab.com <i aria-hidden="true" data-hidden="true" class="fa fa-external-link"></i></a>') + end +end |