diff options
| author | Oxan van Leeuwen <oxan@oxanvanleeuwen.nl> | 2016-11-22 20:11:34 +0300 |
|---|---|---|
| committer | Oxan van Leeuwen <oxan@oxanvanleeuwen.nl> | 2016-12-05 01:07:22 +0300 |
| commit | bb447383c527d28bf4f884df18462e22be05f3b4 (patch) | |
| tree | 82c72bd1de0a05b52f0549d593aeacd012e720f9 /spec/javascripts/fixtures | |
| parent | ef6a91af123d8b773ba8a286cf986abaedee6c33 (diff) | |
Add issue events filter and make sure "All" really shows everything
Currently, the EventFilter whitelists event types for the "All" filter.
This has gotten outdated, which causes the confusing behaviour of the
"All" tab not really showing all events. To make matters worse, by
default no tab at all is selected, which does show all events, so
selecting the "All" tab actually hides some events.
Fix this by:
- Making sure All always includes all activity, by abolishing the
whitelist and just returning all events instead.
- Make the All tab selected by default.
- Add Issue events tab to include the specific events around opening
and closing issues, since there was no specific filter to see them
yet.
Fixes #24826
Diffstat (limited to 'spec/javascripts/fixtures')
| -rw-r--r-- | spec/javascripts/fixtures/event_filter.html.haml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/spec/javascripts/fixtures/event_filter.html.haml b/spec/javascripts/fixtures/event_filter.html.haml index 95e248cadf8..5477c6075f0 100644 --- a/spec/javascripts/fixtures/event_filter.html.haml +++ b/spec/javascripts/fixtures/event_filter.html.haml @@ -12,6 +12,10 @@ %span Merge events %li + %a.event-filter-link{ id: "issue_event_filter", title: "Filter by issue events", href: "/dashboard/activity"} + %span + Issue events + %li %a.event-filter-link{ id: "comments_event_filter", title: "Filter by comments", href: "/dashboard/activity"} %span Comments |