Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamantha Ming <sming@gitlab.com>2019-08-20 07:29:47 +0300
committerPaul Slaughter <pslaughter@gitlab.com>2019-08-20 23:15:19 +0300
commit1c7cbc25b9a877e492643d8749fa2862d86fd93f (patch)
tree247b93a45cff4c2d4730cf692b89d14e440d3fc3 /spec/javascripts/sidebar
parent96b994bd05db072655bcd28204770013feeaa779 (diff)
Apply patch and update spec per MR comments
- Use wrapper instead of global Vue object - Use vue utils helper method - Remove redundant spec tests
Diffstat (limited to 'spec/javascripts/sidebar')
-rw-r--r--spec/javascripts/sidebar/assignees_spec.js2
-rw-r--r--spec/javascripts/sidebar/mock_data.js10
2 files changed, 0 insertions, 12 deletions
diff --git a/spec/javascripts/sidebar/assignees_spec.js b/spec/javascripts/sidebar/assignees_spec.js
index fc731e731ae..a1df5389a38 100644
--- a/spec/javascripts/sidebar/assignees_spec.js
+++ b/spec/javascripts/sidebar/assignees_spec.js
@@ -224,7 +224,6 @@ describe('Assignee component', () => {
expect(userItems.length).toBe(3);
expect(userItems[0].dataset.originalTitle).toBe(users[2].name);
- expect(userItems[0].dataset.originalTitle).not.toBe(users[0].name);
});
it('passes the sorted assignees to the collapsed-assignee-list', () => {
@@ -244,7 +243,6 @@ describe('Assignee component', () => {
const collapsedButton = component.$el.querySelector('.sidebar-collapsed-user button');
expect(collapsedButton.innerText.trim()).toBe(users[2].name);
- expect(collapsedButton.innerText.trim()).not.toBe(users[0].name);
});
});
});
diff --git a/spec/javascripts/sidebar/mock_data.js b/spec/javascripts/sidebar/mock_data.js
index 107acead3c6..7f20b0da991 100644
--- a/spec/javascripts/sidebar/mock_data.js
+++ b/spec/javascripts/sidebar/mock_data.js
@@ -1,13 +1,3 @@
-export const userDataMock = {
- avatar_url: 'mock_path',
- id: 1,
- name: 'Root',
- state: 'active',
- username: 'root',
- web_url: '',
- can_merge: true,
-};
-
const RESPONSE_MAP = {
GET: {
'/gitlab-org/gitlab-shell/issues/5.json': {