Resolve "Jobs dropdown in mini graph should close when we receive an error"

2 files changed, 75 insertions, 46 deletions

diff --git a/spec/javascripts/mini_pipeline_graph_dropdown_spec.js b/spec/javascripts/mini_pipeline_graph_dropdown_spec.js
index e504d41d4d4..481b46c3ac6 100644
--- a/spec/javascripts/mini_pipeline_graph_dropdown_spec.js
+++ b/spec/javascripts/mini_pipeline_graph_dropdown_spec.js
@@ -3,70 +3,84 @@
 import MiniPipelineGraph from '~/mini_pipeline_graph_dropdown';
 import '~/flash';
 
-(() => {
-  describe('Mini Pipeline Graph Dropdown', () => {
-    preloadFixtures('static/mini_dropdown_graph.html.raw');
+describe('Mini Pipeline Graph Dropdown', () => {
+  preloadFixtures('static/mini_dropdown_graph.html.raw');
 
-    beforeEach(() => {
-      loadFixtures('static/mini_dropdown_graph.html.raw');
-    });
+  beforeEach(() => {
+    loadFixtures('static/mini_dropdown_graph.html.raw');
+  });
 
-    describe('When is initialized', () => {
-      it('should initialize without errors when no options are given', () => {
-        const miniPipelineGraph = new MiniPipelineGraph();
+  describe('When is initialized', () => {
+    it('should initialize without errors when no options are given', () => {
+      const miniPipelineGraph = new MiniPipelineGraph();
 
-        expect(miniPipelineGraph.dropdownListSelector).toEqual('.js-builds-dropdown-container');
-      });
+      expect(miniPipelineGraph.dropdownListSelector).toEqual('.js-builds-dropdown-container');
+    });
 
-      it('should set the container as the given prop', () => {
-        const container = '.foo';
+    it('should set the container as the given prop', () => {
+      const container = '.foo';
 
-        const miniPipelineGraph = new MiniPipelineGraph({ container });
+      const miniPipelineGraph = new MiniPipelineGraph({ container });
 
-        expect(miniPipelineGraph.container).toEqual(container);
-      });
+      expect(miniPipelineGraph.container).toEqual(container);
     });
+  });
 
-    describe('When dropdown is clicked', () => {
-      it('should call getBuildsList', () => {
-        const getBuildsListSpy = spyOn(MiniPipelineGraph.prototype, 'getBuildsList').and.callFake(function () {});
+  describe('When dropdown is clicked', () => {
+    it('should call getBuildsList', () => {
+      const getBuildsListSpy = spyOn(
+        MiniPipelineGraph.prototype,
+        'getBuildsList',
+      ).and.callFake(function () {});
 
-        new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
+      new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
 
-        document.querySelector('.js-builds-dropdown-button').click();
+      document.querySelector('.js-builds-dropdown-button').click();
 
-        expect(getBuildsListSpy).toHaveBeenCalled();
-      });
+      expect(getBuildsListSpy).toHaveBeenCalled();
+    });
 
-      it('should make a request to the endpoint provided in the html', () => {
-        const ajaxSpy = spyOn($, 'ajax').and.callFake(function () {});
+    it('should make a request to the endpoint provided in the html', () => {
+      const ajaxSpy = spyOn($, 'ajax').and.callFake(function () {});
 
-        new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
+      new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
 
-        document.querySelector('.js-builds-dropdown-button').click();
-        expect(ajaxSpy.calls.allArgs()[0][0].url).toEqual('foobar');
-      });
+      document.querySelector('.js-builds-dropdown-button').click();
+      expect(ajaxSpy.calls.allArgs()[0][0].url).toEqual('foobar');
+    });
 
-      it('should not close when user uses cmd/ctrl + click', () => {
-        spyOn($, 'ajax').and.callFake(function (params) {
-          params.success({
-            html: `<li>
-              <a class="mini-pipeline-graph-dropdown-item" href="#">
-                <span class="ci-status-icon ci-status-icon-failed"></span>
-                <span class="ci-build-text">build</span>
-              </a>
-              <a class="ci-action-icon-wrapper js-ci-action-icon" href="#"></a>
-            </li>`,
-          });
+    it('should not close when user uses cmd/ctrl + click', () => {
+      spyOn($, 'ajax').and.callFake(function (params) {
+        params.success({
+          html: `<li>
+            <a class="mini-pipeline-graph-dropdown-item" href="#">
+              <span class="ci-status-icon ci-status-icon-failed"></span>
+              <span class="ci-build-text">build</span>
+            </a>
+            <a class="ci-action-icon-wrapper js-ci-action-icon" href="#"></a>
+          </li>`,
         });
-        new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
+      });
+      new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
 
-        document.querySelector('.js-builds-dropdown-button').click();
+      document.querySelector('.js-builds-dropdown-button').click();
 
-        document.querySelector('a.mini-pipeline-graph-dropdown-item').click();
+      document.querySelector('a.mini-pipeline-graph-dropdown-item').click();
 
-        expect($('.js-builds-dropdown-list').is(':visible')).toEqual(true);
-      });
+      expect($('.js-builds-dropdown-list').is(':visible')).toEqual(true);
     });
   });
-})();
+
+  it('should close the dropdown when request returns an error', (done) => {
+    spyOn($, 'ajax').and.callFake(options => options.error());
+
+    new MiniPipelineGraph({ container: '.js-builds-dropdown-tests' }).bindEvents();
+
+    document.querySelector('.js-builds-dropdown-button').click();
+
+    setTimeout(() => {
+      expect($('.js-builds-dropdown-tests .dropdown').hasClass('open')).toEqual(false);
+      done();
+    }, 0);
+  });
+});
diff --git a/spec/javascripts/pipelines/stage_spec.js b/spec/javascripts/pipelines/stage_spec.js
index 66b57a82363..2f1154bd999 100644
--- a/spec/javascripts/pipelines/stage_spec.js
+++ b/spec/javascripts/pipelines/stage_spec.js
@@ -63,4 +63,19 @@ describe('Pipelines Stage', () => {
       expect(minifiedComponent).toContain(expectedSVG);
     });
   });
+
+  describe('when request fails', () => {
+    it('closes dropdown', () => {
+      spyOn($, 'ajax').and.callFake(options => options.error());
+      const StageComponent = Vue.extend(Stage);
+
+      const component = new StageComponent({
+        propsData: { stage: { status: { icon: 'foo' } } },
+      }).$mount();
+
+      expect(
+        component.$el.classList.contains('open'),
+      ).toEqual(false);
+    });
+  });
 });