diff options
| author | Jan Provaznik <jprovaznik@gitlab.com> | 2019-08-16 11:22:57 +0300 |
|---|---|---|
| committer | Jan Provaznik <jprovaznik@gitlab.com> | 2019-08-23 11:36:51 +0300 |
| commit | a98b89e9bcb56b9adc3a4b0bef3e9844bf93bfd0 (patch) | |
| tree | 4b7d1487d1bddddd94ae11ede65c14eb63926834 /spec/lib/banzai/filter/label_reference_filter_spec.rb | |
| parent | 842b4d4ab59f19f7311b7f39948e699a6924fd52 (diff) | |
Re-escape whole HTML content instead of only match
When we un-escape HTML text to find references in it, we should then
re-escape the whole text again, not only found matches.
Because we replace matches with milestone/label links (which contain
HTML tags we don't want to escape again), we re-escape HTML text
with placeholders instead of these links and then replace placeholders
in the escaped text.
Diffstat (limited to 'spec/lib/banzai/filter/label_reference_filter_spec.rb')
| -rw-r--r-- | spec/lib/banzai/filter/label_reference_filter_spec.rb | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/spec/lib/banzai/filter/label_reference_filter_spec.rb b/spec/lib/banzai/filter/label_reference_filter_spec.rb index 213a5459118..35e99d2586e 100644 --- a/spec/lib/banzai/filter/label_reference_filter_spec.rb +++ b/spec/lib/banzai/filter/label_reference_filter_spec.rb @@ -10,6 +10,11 @@ describe Banzai::Filter::LabelReferenceFilter do let(:label) { create(:label, project: project) } let(:reference) { label.to_reference } + it_behaves_like 'HTML text with references' do + let(:resource) { label } + let(:resource_text) { resource.title } + end + it 'requires project context' do expect { described_class.call('') }.to raise_error(ArgumentError, /:project/) end |