Add latest changes from gitlab-org/gitlab@13-6-stable-eev13.6.0-rc42

4 files changed, 220 insertions, 0 deletions

diff --git a/spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb b/spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb
new file mode 100644
index 00000000000..cde8e2d5c18
--- /dev/null
+++ b/spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb
@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Common::Extractors::GraphqlExtractor do
+  let(:graphql_client) { instance_double(BulkImports::Clients::Graphql) }
+  let(:import_entity) { create(:bulk_import_entity) }
+  let(:response) { double(original_hash: { foo: :bar }) }
+  let(:query) { { query: double(to_s: 'test', variables: {}) } }
+  let(:context) do
+    instance_double(
+      BulkImports::Pipeline::Context,
+      entity: import_entity
+    )
+  end
+
+  subject { described_class.new(query) }
+
+  before do
+    allow(subject).to receive(:graphql_client).and_return(graphql_client)
+    allow(graphql_client).to receive(:parse)
+  end
+
+  describe '#extract' do
+    before do
+      allow(subject).to receive(:query_variables).and_return({})
+      allow(graphql_client).to receive(:execute).and_return(response)
+    end
+
+    it 'returns an enumerator with fetched results' do
+      response = subject.extract(context)
+
+      expect(response).to be_instance_of(Enumerator)
+      expect(response.first).to eq({ foo: :bar })
+    end
+  end
+
+  describe 'query variables' do
+    before do
+      allow(graphql_client).to receive(:execute).and_return(response)
+    end
+
+    context 'when variables are present' do
+      let(:query) { { query: double(to_s: 'test', variables: { full_path: :source_full_path }) } }
+
+      it 'builds graphql query variables for import entity' do
+        expected_variables = { full_path: import_entity.source_full_path }
+
+        expect(graphql_client).to receive(:execute).with(anything, expected_variables)
+
+        subject.extract(context).first
+      end
+    end
+
+    context 'when no variables are present' do
+      let(:query) { { query: double(to_s: 'test', variables: nil) } }
+
+      it 'returns empty hash' do
+        expect(graphql_client).to receive(:execute).with(anything, nil)
+
+        subject.extract(context).first
+      end
+    end
+
+    context 'when variables are empty hash' do
+      let(:query) { { query: double(to_s: 'test', variables: {}) } }
+
+      it 'makes graphql request with empty hash' do
+        expect(graphql_client).to receive(:execute).with(anything, {})
+
+        subject.extract(context).first
+      end
+    end
+  end
+end
diff --git a/spec/lib/bulk_imports/common/loaders/entity_loader_spec.rb b/spec/lib/bulk_imports/common/loaders/entity_loader_spec.rb
new file mode 100644
index 00000000000..4de7d95172f
--- /dev/null
+++ b/spec/lib/bulk_imports/common/loaders/entity_loader_spec.rb
@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Common::Loaders::EntityLoader do
+  describe '#load' do
+    it "creates entities for the given data" do
+      group = create(:group, path: "imported-group")
+      parent_entity = create(:bulk_import_entity, group: group, bulk_import: create(:bulk_import))
+      context = instance_double(BulkImports::Pipeline::Context, entity: parent_entity)
+
+      data = {
+        source_type: :group_entity,
+        source_full_path: "parent/subgroup",
+        destination_name: "subgroup",
+        destination_namespace: parent_entity.group.full_path,
+        parent_id: parent_entity.id
+      }
+
+      expect { subject.load(context, data) }.to change(BulkImports::Entity, :count).by(1)
+
+      subgroup_entity = BulkImports::Entity.last
+
+      expect(subgroup_entity.source_full_path).to eq 'parent/subgroup'
+      expect(subgroup_entity.destination_namespace).to eq 'imported-group'
+      expect(subgroup_entity.destination_name).to eq 'subgroup'
+      expect(subgroup_entity.parent_id).to eq parent_entity.id
+    end
+  end
+end
diff --git a/spec/lib/bulk_imports/common/transformers/graphql_cleaner_transformer_spec.rb b/spec/lib/bulk_imports/common/transformers/graphql_cleaner_transformer_spec.rb
new file mode 100644
index 00000000000..8f39b6e7c93
--- /dev/null
+++ b/spec/lib/bulk_imports/common/transformers/graphql_cleaner_transformer_spec.rb
@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Common::Transformers::GraphqlCleanerTransformer do
+  describe '#transform' do
+    let_it_be(:expected_output) do
+      {
+        'name' => 'test',
+        'fullName' => 'test',
+        'description' => 'test',
+        'labels' => [
+          { 'title' => 'label1' },
+          { 'title' => 'label2' },
+          { 'title' => 'label3' }
+        ]
+      }
+    end
+
+    it 'deep cleans hash from GraphQL keys' do
+      data = {
+        'data' => {
+          'group' => {
+            'name' => 'test',
+            'fullName' => 'test',
+            'description' => 'test',
+            'labels' => {
+              'edges' => [
+                { 'node' => { 'title' => 'label1' } },
+                { 'node' => { 'title' => 'label2' } },
+                { 'node' => { 'title' => 'label3' } }
+              ]
+            }
+          }
+        }
+      }
+
+      transformed_data = described_class.new.transform(nil, data)
+
+      expect(transformed_data).to eq(expected_output)
+    end
+
+    context 'when data does not have data/group nesting' do
+      it 'deep cleans hash from GraphQL keys' do
+        data = {
+          'name' => 'test',
+          'fullName' => 'test',
+          'description' => 'test',
+          'labels' => {
+            'edges' => [
+              { 'node' => { 'title' => 'label1' } },
+              { 'node' => { 'title' => 'label2' } },
+              { 'node' => { 'title' => 'label3' } }
+            ]
+          }
+        }
+
+        transformed_data = described_class.new.transform(nil, data)
+
+        expect(transformed_data).to eq(expected_output)
+      end
+    end
+
+    context 'when data is not a hash' do
+      it 'does not perform transformation' do
+        data = 'test'
+
+        transformed_data = described_class.new.transform(nil, data)
+
+        expect(transformed_data).to eq(data)
+      end
+    end
+
+    context 'when nested data is not an array or hash' do
+      it 'only removes top level data/group keys' do
+        data = {
+          'data' => {
+            'group' => 'test'
+          }
+        }
+
+        transformed_data = described_class.new.transform(nil, data)
+
+        expect(transformed_data).to eq('test')
+      end
+    end
+  end
+end
diff --git a/spec/lib/bulk_imports/common/transformers/underscorify_keys_transformer_spec.rb b/spec/lib/bulk_imports/common/transformers/underscorify_keys_transformer_spec.rb
new file mode 100644
index 00000000000..cdffa750694
--- /dev/null
+++ b/spec/lib/bulk_imports/common/transformers/underscorify_keys_transformer_spec.rb
@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BulkImports::Common::Transformers::UnderscorifyKeysTransformer do
+  describe '#transform' do
+    it 'deep underscorifies hash keys' do
+      data = {
+        'fullPath' => 'Foo',
+        'snakeKeys' => {
+          'snakeCaseKey' => 'Bar',
+          'moreKeys' => {
+            'anotherSnakeCaseKey' => 'Test'
+          }
+        }
+      }
+
+      transformed_data = described_class.new.transform(nil, data)
+
+      expect(transformed_data).to have_key('full_path')
+      expect(transformed_data).to have_key('snake_keys')
+      expect(transformed_data['snake_keys']).to have_key('snake_case_key')
+      expect(transformed_data['snake_keys']).to have_key('more_keys')
+      expect(transformed_data.dig('snake_keys', 'more_keys')).to have_key('another_snake_case_key')
+    end
+  end
+end