diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-31 15:06:26 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-31 15:06:26 +0300 |
commit | 0be510a49f6e4f8e27b19b707fd1dac61571f78f (patch) | |
tree | 97ca0053d4fad66e900d25fdba61b2adb611efb0 /spec/lib/gitlab/danger | |
parent | 6026bddcd51eca573c530240c421392045172b89 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/lib/gitlab/danger')
-rw-r--r-- | spec/lib/gitlab/danger/helper_spec.rb | 13 | ||||
-rw-r--r-- | spec/lib/gitlab/danger/teammate_spec.rb | 18 |
2 files changed, 27 insertions, 4 deletions
diff --git a/spec/lib/gitlab/danger/helper_spec.rb b/spec/lib/gitlab/danger/helper_spec.rb index 1696d3566ad..8056418e697 100644 --- a/spec/lib/gitlab/danger/helper_spec.rb +++ b/spec/lib/gitlab/danger/helper_spec.rb @@ -178,6 +178,7 @@ describe Gitlab::Danger::Helper do 'app/assets/foo' | :frontend 'app/views/foo' | :frontend 'public/foo' | :frontend + 'scripts/frontend/foo' | :frontend 'spec/javascripts/foo' | :frontend 'spec/frontend/bar' | :frontend 'vendor/assets/foo' | :frontend @@ -193,10 +194,8 @@ describe Gitlab::Danger::Helper do 'app/models/foo' | :backend 'bin/foo' | :backend 'config/foo' | :backend - 'danger/foo' | :backend 'lib/foo' | :backend 'rubocop/foo' | :backend - 'scripts/foo' | :backend 'spec/foo' | :backend 'spec/foo/bar' | :backend @@ -209,16 +208,24 @@ describe Gitlab::Danger::Helper do 'vendor/languages.yml' | :backend 'vendor/licenses.csv' | :backend - 'Dangerfile' | :backend 'Gemfile' | :backend 'Gemfile.lock' | :backend 'Procfile' | :backend 'Rakefile' | :backend 'FOO_VERSION' | :backend + 'Dangerfile' | :engineering_productivity + 'danger/commit_messages/Dangerfile' | :engineering_productivity + 'ee/danger/commit_messages/Dangerfile' | :engineering_productivity + 'danger/commit_messages/' | :engineering_productivity + 'ee/danger/commit_messages/' | :engineering_productivity '.gitlab-ci.yml' | :engineering_productivity '.gitlab/ci/cng.gitlab-ci.yml' | :engineering_productivity '.gitlab/ci/ee-specific-checks.gitlab-ci.yml' | :engineering_productivity + 'scripts/foo' | :engineering_productivity + 'lib/gitlab/danger/foo' | :engineering_productivity + 'ee/lib/gitlab/danger/foo' | :engineering_productivity + 'lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml' | :backend 'ee/FOO_VERSION' | :unknown diff --git a/spec/lib/gitlab/danger/teammate_spec.rb b/spec/lib/gitlab/danger/teammate_spec.rb index bd1c2b10dc8..35edfa08a63 100644 --- a/spec/lib/gitlab/danger/teammate_spec.rb +++ b/spec/lib/gitlab/danger/teammate_spec.rb @@ -30,7 +30,7 @@ describe Gitlab::Danger::Teammate do expect(subject.maintainer?(project, :frontend, labels)).to be_truthy end - context 'when labels contain Create and the category is test' do + context 'when labels contain devops::create and the category is test' do let(:labels) { ['devops::create'] } context 'when role is Test Automation Engineer, Create' do @@ -79,6 +79,22 @@ describe Gitlab::Danger::Teammate do it '#maintainer? returns false' do expect(subject.maintainer?(project, :engineering_productivity, labels)).to be_falsey end + + context 'when capabilities include maintainer backend' do + let(:capabilities) { ['maintainer backend'] } + + it '#maintainer? returns true' do + expect(subject.maintainer?(project, :engineering_productivity, labels)).to be_truthy + end + end + + context 'when capabilities include trainee_maintainer backend' do + let(:capabilities) { ['trainee_maintainer backend'] } + + it '#traintainer? returns true' do + expect(subject.traintainer?(project, :engineering_productivity, labels)).to be_truthy + end + end end end end |