diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-13 18:08:52 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-13 18:08:52 +0300 |
commit | 0ab47b994caa80c5587f33dc818626b66cfdafe2 (patch) | |
tree | 5ef3976d2f84e3368903a67ba2dbd87a74b9a43c /spec/lib/gitlab/git_access_snippet_spec.rb | |
parent | 1308dc5eb484ab0f8064989fc551ebdb4b1a7976 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/lib/gitlab/git_access_snippet_spec.rb')
-rw-r--r-- | spec/lib/gitlab/git_access_snippet_spec.rb | 85 |
1 files changed, 85 insertions, 0 deletions
diff --git a/spec/lib/gitlab/git_access_snippet_spec.rb b/spec/lib/gitlab/git_access_snippet_spec.rb new file mode 100644 index 00000000000..ffb3d86408a --- /dev/null +++ b/spec/lib/gitlab/git_access_snippet_spec.rb @@ -0,0 +1,85 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe Gitlab::GitAccessSnippet do + include GitHelpers + + let_it_be(:user) { create(:user) } + let_it_be(:personal_snippet) { create(:personal_snippet, :private, :repository) } + + let(:protocol) { 'ssh' } + let(:changes) { Gitlab::GitAccess::ANY } + let(:push_access_check) { access.check('git-receive-pack', changes) } + let(:pull_access_check) { access.check('git-upload-pack', changes) } + let(:snippet) { personal_snippet } + let(:actor) { personal_snippet.author } + + describe 'when feature flag :version_snippets is enabled' do + it 'allows push and pull access' do + aggregate_failures do + expect { pull_access_check }.not_to raise_error + expect { push_access_check }.not_to raise_error + end + end + end + + describe 'when feature flag :version_snippets is disabled' do + before do + stub_feature_flags(version_snippets: false) + end + + it 'does not allow push and pull access' do + aggregate_failures do + expect { push_access_check }.to raise_snippet_not_found + expect { pull_access_check }.to raise_snippet_not_found + end + end + end + + describe '#check_snippet_accessibility!' do + context 'when the snippet exists' do + it 'allows push and pull access' do + aggregate_failures do + expect { pull_access_check }.not_to raise_error + expect { push_access_check }.not_to raise_error + end + end + end + + context 'when the snippet is nil' do + let(:snippet) { nil } + + it 'blocks push and pull with "not found"' do + aggregate_failures do + expect { pull_access_check }.to raise_snippet_not_found + expect { push_access_check }.to raise_snippet_not_found + end + end + end + + context 'when the snippet does not have a repository' do + let(:snippet) { build_stubbed(:personal_snippet) } + + it 'blocks push and pull with "not found"' do + aggregate_failures do + expect { pull_access_check }.to raise_snippet_not_found + expect { push_access_check }.to raise_snippet_not_found + end + end + end + end + + private + + def access + described_class.new(actor, snippet, protocol, + authentication_abilities: [], + namespace_path: nil, project_path: nil, + redirected_path: nil, auth_result_type: nil) + end + + def raise_snippet_not_found + raise_error(Gitlab::GitAccess::NotFoundError, Gitlab::GitAccess::ERROR_MESSAGES[:snippet_not_found]) + end +end |