diff options
author | Michael Kozono <mkozono@gmail.com> | 2017-05-16 19:02:52 +0300 |
---|---|---|
committer | Michael Kozono <mkozono@gmail.com> | 2017-06-05 15:32:26 +0300 |
commit | a738a446f4ade6204c10f016e355da354dbfc01f (patch) | |
tree | 5a689fa6086046d7e5f038c42839820bcf1ea781 /spec/lib/gitlab/git_access_spec.rb | |
parent | 2d6cafa781ae24586fcd5307ae01daf3f407aa25 (diff) |
Check disabled commands in GitAccess instead
Diffstat (limited to 'spec/lib/gitlab/git_access_spec.rb')
-rw-r--r-- | spec/lib/gitlab/git_access_spec.rb | 43 |
1 files changed, 42 insertions, 1 deletions
diff --git a/spec/lib/gitlab/git_access_spec.rb b/spec/lib/gitlab/git_access_spec.rb index 25769977f24..a86afe57873 100644 --- a/spec/lib/gitlab/git_access_spec.rb +++ b/spec/lib/gitlab/git_access_spec.rb @@ -1,10 +1,11 @@ require 'spec_helper' describe Gitlab::GitAccess, lib: true do - let(:access) { Gitlab::GitAccess.new(actor, project, 'ssh', authentication_abilities: authentication_abilities) } + let(:access) { Gitlab::GitAccess.new(actor, project, protocol, authentication_abilities: authentication_abilities) } let(:project) { create(:project, :repository) } let(:user) { create(:user) } let(:actor) { user } + let(:protocol) { 'ssh' } let(:authentication_abilities) do [ :read_project, @@ -50,6 +51,46 @@ describe Gitlab::GitAccess, lib: true do end end + describe '#check with commands disabled' do + before { project.team << [user, :master] } + + context 'over http' do + let(:protocol) { 'http' } + + context 'when the git-upload-pack command is disabled in config' do + before do + allow(Gitlab.config.gitlab_shell).to receive(:upload_pack).and_return(false) + end + + context 'when calling git-upload-pack' do + subject { access.check('git-upload-pack', '_any') } + it { expect(subject.allowed?).to be_falsey } + it { expect(subject.message).to eq('The command "git-upload-pack" is not allowed.') } + end + + context 'when calling git-receive-pack' do + it { expect(access.check('git-receive-pack', '_any').allowed?).to be_truthy } + end + end + + context 'when the git-receive-pack command is disabled in config' do + before do + allow(Gitlab.config.gitlab_shell).to receive(:receive_pack).and_return(false) + end + + context 'when calling git-receive-pack' do + subject { access.check('git-receive-pack', '_any') } + it { expect(subject.allowed?).to be_falsey } + it { expect(subject.message).to eq('The command "git-receive-pack" is not allowed.') } + end + + context 'when calling git-upload-pack' do + it { expect(access.check('git-upload-pack', '_any').allowed?).to be_truthy } + end + end + end + end + describe '#check_download_access!' do subject { access.check('git-upload-pack', '_any') } |