diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 12:40:42 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 12:40:42 +0300 |
commit | ee664acb356f8123f4f6b00b73c1e1cf0866c7fb (patch) | |
tree | f8479f94a28f66654c6a4f6fb99bad6b4e86a40e /spec/lib/gitlab/memory/reports_daemon_spec.rb | |
parent | 62f7d5c5b69180e82ae8196b7b429eeffc8e7b4f (diff) |
Add latest changes from gitlab-org/gitlab@15-5-stable-eev15.5.0-rc42
Diffstat (limited to 'spec/lib/gitlab/memory/reports_daemon_spec.rb')
-rw-r--r-- | spec/lib/gitlab/memory/reports_daemon_spec.rb | 39 |
1 files changed, 22 insertions, 17 deletions
diff --git a/spec/lib/gitlab/memory/reports_daemon_spec.rb b/spec/lib/gitlab/memory/reports_daemon_spec.rb index c9562470971..0473e170502 100644 --- a/spec/lib/gitlab/memory/reports_daemon_spec.rb +++ b/spec/lib/gitlab/memory/reports_daemon_spec.rb @@ -2,9 +2,15 @@ require 'spec_helper' -RSpec.describe Gitlab::Memory::ReportsDaemon do +RSpec.describe Gitlab::Memory::ReportsDaemon, :aggregate_failures do let(:daemon) { described_class.new } + let_it_be(:tmp_dir) { Dir.mktmpdir } + + after(:all) do + FileUtils.remove_entry(tmp_dir) + end + describe '#run_thread' do let(:report_duration_counter) { instance_double(::Prometheus::Client::Counter) } let(:file_size) { 1_000_000 } @@ -22,13 +28,10 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do allow(File).to receive(:size).with(/#{daemon.reports_path}.*\.json/).and_return(file_size) end - it 'runs reports' do - expect(daemon.send(:reports)).to all(receive(:run).twice.and_call_original) - - daemon.send(:run_thread) - end + it 'runs reports, logs and sets gauge' do + expect(daemon.send(:reports)) + .to all(receive(:run).twice { Tempfile.new("report.json", tmp_dir).path }) - it 'logs report execution' do expect(::Prometheus::PidProvider).to receive(:worker_id).at_least(:once).and_return('worker_1') expect(Gitlab::AppLogger).to receive(:info).with( @@ -42,6 +45,8 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do perf_report: 'jemalloc_stats' )).twice + expect(report_duration_counter).to receive(:increment).with({ report: 'jemalloc_stats' }, an_instance_of(Float)) + daemon.send(:run_thread) end @@ -51,18 +56,15 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do end it 'logs `0` as `perf_report_size_bytes`' do + expect(daemon.send(:reports)) + .to all(receive(:run).twice { Tempfile.new("report.json", tmp_dir).path }) + expect(Gitlab::AppLogger).to receive(:info).with(hash_including(perf_report_size_bytes: 0)).twice daemon.send(:run_thread) end end - it 'sets real time duration gauge' do - expect(report_duration_counter).to receive(:increment).with({ report: 'jemalloc_stats' }, an_instance_of(Float)) - - daemon.send(:run_thread) - end - it 'allows configure and run multiple reports' do # rubocop: disable RSpec/VerifiedDoubles # We test how ReportsDaemon could be extended in the future @@ -74,8 +76,8 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do allow(daemon).to receive(:reports).and_return([active_report_1, inactive_report, active_report_2]) - expect(active_report_1).to receive(:run).and_return('/tmp/report_1.json').twice - expect(active_report_2).to receive(:run).and_return('/tmp/report_2.json').twice + expect(active_report_1).to receive(:run).and_return(File.join(tmp_dir, 'report_1.json')).twice + expect(active_report_2).to receive(:run).and_return(File.join(tmp_dir, 'report_2.json')).twice expect(inactive_report).not_to receive(:run) daemon.send(:run_thread) @@ -87,6 +89,9 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do daemon = described_class.new allow(daemon).to receive(:alive).and_return(true, true, false) + expect(daemon.send(:reports)) + .to all(receive(:run).twice { Tempfile.new("report.json", tmp_dir).path }) + expect(daemon).to receive(:sleep).with(described_class::DEFAULT_SLEEP_S).ordered expect(daemon).to receive(:sleep).with(described_class::DEFAULT_SLEEP_BETWEEN_REPORTS_S).ordered expect(daemon).to receive(:sleep).with(described_class::DEFAULT_SLEEP_S).ordered @@ -120,7 +125,7 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do stub_env('GITLAB_DIAGNOSTIC_REPORTS_SLEEP_S', 100) stub_env('GITLAB_DIAGNOSTIC_REPORTS_SLEEP_MAX_DELTA_S', 50) stub_env('GITLAB_DIAGNOSTIC_REPORTS_SLEEP_BETWEEN_REPORTS_S', 2) - stub_env('GITLAB_DIAGNOSTIC_REPORTS_PATH', '/empty-dir') + stub_env('GITLAB_DIAGNOSTIC_REPORTS_PATH', tmp_dir) end it 'uses provided values' do @@ -129,7 +134,7 @@ RSpec.describe Gitlab::Memory::ReportsDaemon do expect(daemon.sleep_s).to eq(100) expect(daemon.sleep_max_delta_s).to eq(50) expect(daemon.sleep_between_reports_s).to eq(2) - expect(daemon.reports_path).to eq('/empty-dir') + expect(daemon.reports_path).to eq(tmp_dir) end end end |