Use string evaluation for method instrumentation

This is faster than using define_method since we don't have to keep
block bindings around.

1 files changed, 4 insertions, 2 deletions

diff --git a/spec/lib/gitlab/metrics/instrumentation_spec.rb b/spec/lib/gitlab/metrics/instrumentation_spec.rb
index eb31c9e52cd..3e7e9869e30 100644
--- a/spec/lib/gitlab/metrics/instrumentation_spec.rb
+++ b/spec/lib/gitlab/metrics/instrumentation_spec.rb
@@ -11,6 +11,8 @@ describe Gitlab::Metrics::Instrumentation do
         text
       end
     end
+
+    allow(@dummy).to receive(:name).and_return('Dummy')
   end
 
   describe '.instrument_method' do
@@ -31,7 +33,7 @@ describe Gitlab::Metrics::Instrumentation do
 
       it 'fires an ActiveSupport notification upon calling the method' do
         expect(ActiveSupport::Notifications).to receive(:instrument).
-          with('class_method.method_call', module: @dummy, name: :foo)
+          with('class_method.method_call', module: 'Dummy', name: :foo)
 
         @dummy.foo
       end
@@ -69,7 +71,7 @@ describe Gitlab::Metrics::Instrumentation do
 
       it 'fires an ActiveSupport notification upon calling the method' do
         expect(ActiveSupport::Notifications).to receive(:instrument).
-          with('instance_method.method_call', module: @dummy, name: :bar)
+          with('instance_method.method_call', module: 'Dummy', name: :bar)
 
         @dummy.new.bar
       end