diff options
| author | Vladimir Shushlin <vshushlin@gitlab.com> | 2019-05-28 07:47:34 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-05-28 07:47:34 +0300 |
| commit | 4687ff7c9be789341e82a6440234fce43f30b5be (patch) | |
| tree | 59b72fafa974c92af04590e7fc3b64c6536aef70 /spec/lib | |
| parent | af43970834b911242eecf9b7c815faf0f6b50048 (diff) | |
Store Let's Encrypt private key in settings
Storing this key in secrets.yml was a bad idea,
it would require users using HA setups to manually
replicate secrets across nodes during update,
it also needed support from omnibus package
* Revert "Generate Let's Encrypt private key"
This reverts commit 444959bfa0b79e827a2a1a7a314acac19390f976.
* Add Let's Encrypt private key to settings
as encrypted attribute
* Generate Let's Encrypt private key
in database migration
Diffstat (limited to 'spec/lib')
| -rw-r--r-- | spec/lib/gitlab/lets_encrypt/client_spec.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/spec/lib/gitlab/lets_encrypt/client_spec.rb b/spec/lib/gitlab/lets_encrypt/client_spec.rb index 16a16acfd25..d63a2fbee04 100644 --- a/spec/lib/gitlab/lets_encrypt/client_spec.rb +++ b/spec/lib/gitlab/lets_encrypt/client_spec.rb @@ -5,12 +5,14 @@ require 'spec_helper' describe ::Gitlab::LetsEncrypt::Client do include LetsEncryptHelpers + set(:private_key) { OpenSSL::PKey::RSA.new(4096).to_pem } let(:client) { described_class.new } before do stub_application_setting( lets_encrypt_notification_email: 'myemail@test.example.com', - lets_encrypt_terms_of_service_accepted: true + lets_encrypt_terms_of_service_accepted: true, + lets_encrypt_private_key: private_key ) end |