diff options
author | Izaak Alpert <ialpert@blackberry.com> | 2013-07-17 01:14:03 +0400 |
---|---|---|
committer | Izaak Alpert <ialpert@blackberry.com> | 2013-07-18 06:48:03 +0400 |
commit | d99594273d57b2d5ed7c748b3185712960b89478 (patch) | |
tree | 5f5d6da6011465e3521c7c3ab09ec7a38dbef37a /spec/lib | |
parent | 128f2845770b7a6d553ee764cdbbe63da5ba9e84 (diff) |
Style changes from review with @randx
-Some changes around calling origional methods for !for_fork? merge requests. Other changes to follow
Change-Id: I009c716ce2475b9efa3fd07aee9215fca7a1c150
Diffstat (limited to 'spec/lib')
-rw-r--r-- | spec/lib/gitlab/satellite/action_spec.rb | 6 | ||||
-rw-r--r-- | spec/lib/gitlab/satellite/merge_action_spec.rb | 6 |
2 files changed, 0 insertions, 12 deletions
diff --git a/spec/lib/gitlab/satellite/action_spec.rb b/spec/lib/gitlab/satellite/action_spec.rb index e37edb9614b..5e0a825c3c3 100644 --- a/spec/lib/gitlab/satellite/action_spec.rb +++ b/spec/lib/gitlab/satellite/action_spec.rb @@ -1,12 +1,9 @@ require 'spec_helper' describe 'Gitlab::Satellite::Action' do - - let(:project) { create(:project_with_code) } let(:user) { create(:user) } - describe '#prepare_satellite!' do it 'create a repository with a parking branch and one remote: origin' do @@ -50,11 +47,8 @@ describe 'Gitlab::Satellite::Action' do repo.config['user.name'].should ==user.name repo.config['user.email'].should ==user.email end - - end - describe '#in_locked_and_timed_satellite' do it 'should make use of a lockfile' do diff --git a/spec/lib/gitlab/satellite/merge_action_spec.rb b/spec/lib/gitlab/satellite/merge_action_spec.rb index 3f6e5c35245..2478efe8493 100644 --- a/spec/lib/gitlab/satellite/merge_action_spec.rb +++ b/spec/lib/gitlab/satellite/merge_action_spec.rb @@ -11,7 +11,6 @@ describe 'Gitlab::Satellite::MergeAction' do #these commits are quite close together, itended to make string diffs/format patches small @close_commit1 = ['2_3_notes_fix', '8470d70da67355c9c009e4401746b1d5410af2e3'] @close_commit2 = ['scss_refactoring', 'f0f14c8eaba69ebddd766498a9d0b0e79becd633'] - end let(:project) { create(:project_with_code) } @@ -53,7 +52,6 @@ describe 'Gitlab::Satellite::MergeAction' do end end - describe '#format_patch' do context 'on fork' do it 'should build a format patch' do @@ -76,7 +74,6 @@ describe 'Gitlab::Satellite::MergeAction' do end end - describe '#diffs_between_satellite tested against diff_in_satellite' do def is_a_matching_diff(diff, diffs) @@ -109,7 +106,6 @@ describe 'Gitlab::Satellite::MergeAction' do merge_request.source_branch = @master[0] diffs = Gitlab::Satellite::MergeAction.new(merge_request.author, merge_request).diffs_between_satellite - merge_request.target_branch = @close_commit1[0] merge_request.source_branch = @master[0] diff = Gitlab::Satellite::MergeAction.new(merge_request.author, merge_request).diff_in_satellite @@ -119,7 +115,6 @@ describe 'Gitlab::Satellite::MergeAction' do end end - describe '#can_be_merged?' do context 'on fork' do it 'return true or false depending on if something is mergable' do @@ -145,5 +140,4 @@ describe 'Gitlab::Satellite::MergeAction' do end end end - end
\ No newline at end of file |