Allow limiting logging in users from too many different IPs.

2 files changed, 128 insertions, 0 deletions

diff --git a/spec/lib/gitlab/auth/unique_ips_limiter_spec.rb b/spec/lib/gitlab/auth/unique_ips_limiter_spec.rb
new file mode 100644
index 00000000000..8e9fea0724a
--- /dev/null
+++ b/spec/lib/gitlab/auth/unique_ips_limiter_spec.rb
@@ -0,0 +1,88 @@
+require 'spec_helper'
+
+describe Gitlab::Auth::UniqueIpsLimiter, lib: true do
+  let(:user) { create(:user) }
+
+  before(:each) do
+    Gitlab::Redis.with do |redis|
+      redis.del("user_unique_ips:#{user.id}")
+    end
+  end
+
+  describe '#count_unique_ips' do
+
+    context 'non unique IPs' do
+      it 'properly counts them' do
+        expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.1')).to eq(1)
+        expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.1')).to eq(1)
+      end
+    end
+
+    context 'unique IPs' do
+      it 'properly counts them' do
+        expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.2')).to eq(1)
+        expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.3')).to eq(2)
+      end
+    end
+
+    it 'resets count after specified time window' do
+      cur_time = Time.now.to_i
+      allow(Time).to receive(:now).and_return(cur_time)
+
+      expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.2')).to eq(1)
+      expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.3')).to eq(2)
+
+      allow(Time).to receive(:now).and_return(cur_time + Gitlab::Auth::UniqueIpsLimiter.config.unique_ips_limit_time_window)
+
+      expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.4')).to eq(1)
+      expect(Gitlab::Auth::UniqueIpsLimiter.count_unique_ips(user.id, '192.168.1.5')).to eq(2)
+    end
+  end
+
+
+  describe '#limit_user!' do
+    context 'when unique ips limit is enabled' do
+      before do
+        allow(Gitlab::Auth::UniqueIpsLimiter).to receive_message_chain(:config, :unique_ips_limit_enabled).and_return(true)
+        allow(Gitlab::Auth::UniqueIpsLimiter).to receive_message_chain(:config, :unique_ips_limit_time_window).and_return(10)
+      end
+
+      context 'when ip limit is set to 1' do
+        before do
+          allow(Gitlab::Auth::UniqueIpsLimiter).to receive_message_chain(:config, :unique_ips_limit_per_user).and_return(1)
+        end
+
+        it 'blocks user trying to login from second ip' do
+          RequestStore[:client_ip] = '192.168.1.1'
+          expect(Gitlab::Auth::UniqueIpsLimiter.limit_user! { user }).to eq(user)
+
+          RequestStore[:client_ip] = '192.168.1.2'
+          expect { Gitlab::Auth::UniqueIpsLimiter.limit_user! { user } }.to raise_error(Gitlab::Auth::TooManyIps)
+        end
+
+        it 'allows user trying to login from the same ip twice' do
+          RequestStore[:client_ip] = '192.168.1.1'
+          expect(Gitlab::Auth::UniqueIpsLimiter.limit_user! { user }).to eq(user)
+          expect(Gitlab::Auth::UniqueIpsLimiter.limit_user! { user }).to eq(user)
+        end
+      end
+
+      context 'when ip limit is set to 2' do
+        before do
+          allow(Gitlab::Auth::UniqueIpsLimiter).to receive_message_chain(:config, :unique_ips_limit_per_user).and_return(2)
+        end
+
+        it 'blocks user trying to login from third ip' do
+          RequestStore[:client_ip] = '192.168.1.1'
+          expect(Gitlab::Auth::UniqueIpsLimiter.limit_user! { user }).to eq(user)
+
+          RequestStore[:client_ip] = '192.168.1.2'
+          expect(Gitlab::Auth::UniqueIpsLimiter.limit_user! { user }).to eq(user)
+
+          RequestStore[:client_ip] = '192.168.1.3'
+          expect { Gitlab::Auth::UniqueIpsLimiter.limit_user! { user } }.to raise_error(Gitlab::Auth::TooManyIps)
+        end
+      end
+    end
+  end
+end
diff --git a/spec/lib/gitlab/request_context_spec.rb b/spec/lib/gitlab/request_context_spec.rb
new file mode 100644
index 00000000000..3565fab6ded
--- /dev/null
+++ b/spec/lib/gitlab/request_context_spec.rb
@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe Gitlab::RequestContext, lib: true do
+  describe '#client_ip' do
+    subject { Gitlab::RequestContext.client_ip }
+    let(:app) { -> env {} }
+    let(:env) { Hash.new }
+
+    context 'when RequestStore::Middleware is used' do
+      around(:each) do |example|
+        RequestStore::Middleware.new(-> env { example.run }).call({})
+      end
+
+      context 'request' do
+        let(:ip) { '192.168.1.11' }
+
+        before do
+          allow_any_instance_of(Rack::Request).to receive(:ip).and_return(ip)
+          Gitlab::RequestContext.new(app).call(env)
+        end
+
+        it { is_expected.to eq(ip) }
+      end
+
+      context 'before RequestContext mw run' do
+        it { is_expected.to be_nil }
+      end
+    end
+
+    context 'RequestStore is not active' do
+      it { is_expected.to be_nil }
+
+      context 'when RequestContext mw is run' do
+        subject { -> { Gitlab::RequestContext.new(app).call(env) } }
+
+        it { is_expected.to raise_error(Gitlab::RequestStoreNotActive) }
+      end
+    end
+  end
+end