diff options
author | João Cunha <j.a.cunha@gmail.com> | 2019-03-01 14:44:11 +0300 |
---|---|---|
committer | João Cunha <j.a.cunha@gmail.com> | 2019-03-28 18:50:47 +0300 |
commit | 4e5a9838fa97c9637ac36d5fd339dc311a8443b1 (patch) | |
tree | 647b13172987e91fb2039feece84540dc7c7cc90 /spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb | |
parent | 04496085c1b83ccf5d9bfa546daf2a92e9c644e7 (diff) |
Refactor subbed_worker calls
- Creates a support/helper file and moves all the duplication defs
into it
Diffstat (limited to 'spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb')
-rw-r--r-- | spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb b/spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb index f8cf76cb339..94de208e53e 100644 --- a/spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb +++ b/spec/migrations/migrate_storage_migrator_sidekiq_queue_spec.rb @@ -3,11 +3,12 @@ require Rails.root.join('db', 'post_migrate', '20190124200344_migrate_storage_mi describe MigrateStorageMigratorSidekiqQueue, :sidekiq, :redis do include Gitlab::Database::MigrationHelpers + include StubWorker context 'when there are jobs in the queues' do it 'correctly migrates queue when migrating up' do Sidekiq::Testing.disable! do - stubbed_worker(queue: :storage_migrator).perform_async(1, 5) + stub_worker(queue: :storage_migrator).perform_async(1, 5) described_class.new.up @@ -18,7 +19,7 @@ describe MigrateStorageMigratorSidekiqQueue, :sidekiq, :redis do it 'correctly migrates queue when migrating down' do Sidekiq::Testing.disable! do - stubbed_worker(queue: :'hashed_storage:hashed_storage_migrator').perform_async(1, 5) + stub_worker(queue: :'hashed_storage:hashed_storage_migrator').perform_async(1, 5) described_class.new.down @@ -37,11 +38,4 @@ describe MigrateStorageMigratorSidekiqQueue, :sidekiq, :redis do expect { described_class.new.down }.not_to raise_error end end - - def stubbed_worker(queue:) - Class.new do - include Sidekiq::Worker - sidekiq_options queue: queue - end - end end |