diff options
author | Robert Speicher <rspeicher@gmail.com> | 2015-06-09 01:13:14 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2015-06-09 01:13:14 +0300 |
commit | 23954b0f77ec048ed1a74eb30531c63de8b21b17 (patch) | |
tree | ab5a37a7927a9ba94b17df77062e6cab5c820eec /spec/models/concerns/mentionable_spec.rb | |
parent | b637f849503db06f38812184aec398f2e4e29d09 (diff) |
Correctly remove already-mentioned commits for cross references
Fixes #1778
Diffstat (limited to 'spec/models/concerns/mentionable_spec.rb')
-rw-r--r-- | spec/models/concerns/mentionable_spec.rb | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/spec/models/concerns/mentionable_spec.rb b/spec/models/concerns/mentionable_spec.rb index eadb941a3fa..22237f2e9f2 100644 --- a/spec/models/concerns/mentionable_spec.rb +++ b/spec/models/concerns/mentionable_spec.rb @@ -1,14 +1,31 @@ require 'spec_helper' describe Issue, "Mentionable" do - describe :mentioned_users do + describe '#mentioned_users' do let!(:user) { create(:user, username: 'stranger') } let!(:user2) { create(:user, username: 'john') } - let!(:issue) { create(:issue, description: '@stranger mentioned') } + let!(:issue) { create(:issue, description: "#{user.to_reference} mentioned") } subject { issue.mentioned_users } it { is_expected.to include(user) } it { is_expected.not_to include(user2) } end + + describe '#create_cross_references!' do + let(:project) { create(:project) } + let(:author) { double('author') } + let(:commit) { project.commit } + let(:commit2) { project.commit } + + let!(:issue) do + create(:issue, project: project, description: commit.to_reference) + end + + it 'correctly removes already-mentioned Commits' do + expect(Note).not_to receive(:create_cross_reference_note) + + issue.create_cross_references!(project, author, [commit2]) + end + end end |