Allow blank values to be stored in reactive cache

Reactive caching concern was using .present? to determine if it got
a valid value from the cache. This returns false for values such as
false, [], {}. Change this check to !.nil? instead.

1 files changed, 10 insertions, 2 deletions

diff --git a/spec/models/concerns/reactive_caching_spec.rb b/spec/models/concerns/reactive_caching_spec.rb
index 97a4c212f1c..03ae45e6b17 100644
--- a/spec/models/concerns/reactive_caching_spec.rb
+++ b/spec/models/concerns/reactive_caching_spec.rb
@@ -25,7 +25,7 @@ describe ReactiveCaching, :use_clean_rails_memory_store_caching do
 
     def result
       with_reactive_cache do |data|
-        data / 2
+        data
       end
     end
   end
@@ -64,7 +64,7 @@ describe ReactiveCaching, :use_clean_rails_memory_store_caching do
         stub_reactive_cache(instance, 4)
       end
 
-      it { is_expected.to eq(2) }
+      it { is_expected.to eq(4) }
 
       it 'does not enqueue a background worker' do
         expect(ReactiveCachingWorker).not_to receive(:perform_async)
@@ -94,6 +94,14 @@ describe ReactiveCaching, :use_clean_rails_memory_store_caching do
         end
       end
     end
+
+    context 'when cache contains non-nil but blank value' do
+      before do
+        stub_reactive_cache(instance, false)
+      end
+
+      it { is_expected.to eq(false) }
+    end
   end
 
   describe '#clear_reactive_cache!' do