diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-03-31 12:54:09 +0300 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-03-31 12:54:09 +0300 |
commit | a7466af3a6f31311d64654631a2ea2740c42b88e (patch) | |
tree | 7eb1d3f63a73cc2d4cca13ba3640d16c7e654b98 /spec/models/container_repository_spec.rb | |
parent | 600bbe15a103b63e14daa295abaffdf1aeafaef3 (diff) |
Improve code related to removing container image tags
Diffstat (limited to 'spec/models/container_repository_spec.rb')
-rw-r--r-- | spec/models/container_repository_spec.rb | 30 |
1 files changed, 11 insertions, 19 deletions
diff --git a/spec/models/container_repository_spec.rb b/spec/models/container_repository_spec.rb index 296b9e713a8..92dccf76d71 100644 --- a/spec/models/container_repository_spec.rb +++ b/spec/models/container_repository_spec.rb @@ -57,38 +57,30 @@ describe ContainerRepository do it { is_expected.not_to be_empty } end - # TODO, improve these specs - # - describe '#delete_tags' do - let(:tag) { ContainerRegistry::Tag.new(container_repository, 'tag') } - - before do - allow(container_repository).to receive(:tags).twice.and_return([tag]) - allow(tag).to receive(:digest) - .and_return('sha256:4c8e63ca4cb663ce6c688cb06f1c3672a172b088dac5b6d7ad7d49cd620d85cf') + describe '#delete_tags!' do + let(:container_repository) do + create(:container_repository, name: 'my_image', + tags: %w[latest rc1], + project: project) end context 'when action succeeds' do - before do - allow(container_repository.client) + it 'returns status that indicates success' do + expect(container_repository.client) .to receive(:delete_repository_tag) .and_return(true) - end - it 'returns status that indicates success' do - expect(container_repository.delete_tags).to be_truthy + expect(container_repository.delete_tags!).to be_truthy end end context 'when action fails' do - before do - allow(container_repository.client) + it 'returns status that indicates failure' do + expect(container_repository.client) .to receive(:delete_repository_tag) .and_return(false) - end - it 'returns status that indicates failure' do - expect(container_repository.delete_tags).to be_falsey + expect(container_repository.delete_tags!).to be_falsey end end end |