diff options
author | Andreas Brandl <abrandl@gitlab.com> | 2019-01-02 18:50:37 +0300 |
---|---|---|
committer | Andreas Brandl <abrandl@gitlab.com> | 2019-01-29 17:38:40 +0300 |
commit | fede3a0b75e5db720bd4684faca5626d4ef109d2 (patch) | |
tree | f1a738e57af08c951839ec388f0dc1473f8d6ac0 /spec/models/internal_id_spec.rb | |
parent | 13f5f7e64de8016bafc6c897a4dc405250f2f63d (diff) |
Flush InternalId records after import
After the import has finished, we flush (delete) the InternalId records
related to the project at hand. This means we're starting over with
tracking correct internal id values, a new record will be created
automatically when the next internal id is generated.
The GitHub importer assigns iid values by using supplied values from
GitHub. We skip tracking internal id values during the import in favor
of higher concurrency. Deleting any InternalId records after the import
has finished is an extra measure to guarantee consistency.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54270.
Diffstat (limited to 'spec/models/internal_id_spec.rb')
-rw-r--r-- | spec/models/internal_id_spec.rb | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/spec/models/internal_id_spec.rb b/spec/models/internal_id_spec.rb index 4696341c05f..d32f163f05b 100644 --- a/spec/models/internal_id_spec.rb +++ b/spec/models/internal_id_spec.rb @@ -13,6 +13,29 @@ describe InternalId do it { is_expected.to validate_presence_of(:usage) } end + describe '.flush_records!' do + subject { described_class.flush_records!(project: project) } + + let(:another_project) { create(:project) } + + before do + create_list(:issue, 2, project: project) + create_list(:issue, 2, project: another_project) + end + + it 'deletes all records for the given project' do + expect { subject }.to change { described_class.where(project: project).count }.from(1).to(0) + end + + it 'retains records for other projects' do + expect { subject }.not_to change { described_class.where(project: another_project).count } + end + + it 'does not allow an empty filter' do + expect { described_class.flush_records!({}) }.to raise_error(/filter cannot be empty/) + end + end + describe '.generate_next' do subject { described_class.generate_next(issue, scope, usage, init) } |