diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-19 12:08:42 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-19 12:08:42 +0300 |
commit | b76ae638462ab0f673e5915986070518dd3f9ad3 (patch) | |
tree | bdab0533383b52873be0ec0eb4d3c66598ff8b91 /spec/models/namespace_setting_spec.rb | |
parent | 434373eabe7b4be9593d18a585fb763f1e5f1a6f (diff) |
Add latest changes from gitlab-org/gitlab@14-2-stable-eev14.2.0-rc42
Diffstat (limited to 'spec/models/namespace_setting_spec.rb')
-rw-r--r-- | spec/models/namespace_setting_spec.rb | 85 |
1 files changed, 85 insertions, 0 deletions
diff --git a/spec/models/namespace_setting_spec.rb b/spec/models/namespace_setting_spec.rb index 14d28be8d43..e8ed6f1a460 100644 --- a/spec/models/namespace_setting_spec.rb +++ b/spec/models/namespace_setting_spec.rb @@ -41,6 +41,14 @@ RSpec.describe NamespaceSetting, type: :model do it_behaves_like "doesn't return an error" end + + context "when it contains javascript tags" do + it "gets sanitized properly" do + namespace_settings.update!(default_branch_name: "hello<script>alert(1)</script>") + + expect(namespace_settings.default_branch_name).to eq('hello') + end + end end describe '#allow_mfa_for_group' do @@ -98,4 +106,81 @@ RSpec.describe NamespaceSetting, type: :model do end end end + + describe '#prevent_sharing_groups_outside_hierarchy' do + let(:settings) { create(:namespace_settings, prevent_sharing_groups_outside_hierarchy: true) } + let!(:group) { create(:group, parent: parent, namespace_settings: settings ) } + + subject(:group_sharing_setting) { settings.prevent_sharing_groups_outside_hierarchy } + + context 'when this namespace is a root ancestor' do + let(:parent) { nil } + + it 'returns the actual stored value' do + expect(group_sharing_setting).to be_truthy + end + end + + context 'when this namespace is a descendant' do + let(:parent) { create(:group) } + + it 'returns the value stored for the parent settings' do + expect(group_sharing_setting).to eq(parent.namespace_settings.prevent_sharing_groups_outside_hierarchy) + expect(group_sharing_setting).to be_falsey + end + end + end + + describe 'hooks related to group user cap update' do + let(:settings) { create(:namespace_settings, new_user_signups_cap: user_cap) } + let(:group) { create(:group, namespace_settings: settings) } + + before do + allow(group).to receive(:root?).and_return(true) + end + + context 'when updating a group with a user cap' do + let(:user_cap) { nil } + + it 'also sets share_with_group_lock and prevent_sharing_groups_outside_hierarchy to true' do + expect(group.new_user_signups_cap).to be_nil + expect(group.share_with_group_lock).to be_falsey + expect(settings.prevent_sharing_groups_outside_hierarchy).to be_falsey + + settings.update!(new_user_signups_cap: 10) + group.reload + + expect(group.new_user_signups_cap).to eq(10) + expect(group.share_with_group_lock).to be_truthy + expect(settings.reload.prevent_sharing_groups_outside_hierarchy).to be_truthy + end + + it 'has share_with_group_lock and prevent_sharing_groups_outside_hierarchy returning true for descendent groups' do + descendent = create(:group, parent: group) + desc_settings = descendent.namespace_settings + + expect(descendent.share_with_group_lock).to be_falsey + expect(desc_settings.prevent_sharing_groups_outside_hierarchy).to be_falsey + + settings.update!(new_user_signups_cap: 10) + + expect(descendent.reload.share_with_group_lock).to be_truthy + expect(desc_settings.reload.prevent_sharing_groups_outside_hierarchy).to be_truthy + end + end + + context 'when removing a user cap from namespace settings' do + let(:user_cap) { 10 } + + it 'leaves share_with_group_lock and prevent_sharing_groups_outside_hierarchy set to true to the related group' do + expect(group.share_with_group_lock).to be_truthy + expect(settings.prevent_sharing_groups_outside_hierarchy).to be_truthy + + settings.update!(new_user_signups_cap: nil) + + expect(group.reload.share_with_group_lock).to be_truthy + expect(settings.reload.prevent_sharing_groups_outside_hierarchy).to be_truthy + end + end + end end |