Fix route rename descendants if route.name is blank

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

1 files changed, 18 insertions, 6 deletions

diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb
index a276aa4b13a..0b222022e62 100644
--- a/spec/models/route_spec.rb
+++ b/spec/models/route_spec.rb
@@ -20,13 +20,25 @@ describe Route, models: true do
     let!(:similar_group) { create(:group, path: 'gitlab-org', name: 'gitlab-org') }
 
     context 'path update' do
-      before { route.update_attributes(path: 'bar') }
+      context 'when route name is set' do
+        before { route.update_attributes(path: 'bar') }
+
+        it "updates children routes with new path" do
+          expect(described_class.exists?(path: 'bar')).to be_truthy
+          expect(described_class.exists?(path: 'bar/test')).to be_truthy
+          expect(described_class.exists?(path: 'bar/test/foo')).to be_truthy
+          expect(described_class.exists?(path: 'gitlab-org')).to be_truthy
+        end
+      end
 
-      it "updates children routes with new path" do
-        expect(described_class.exists?(path: 'bar')).to be_truthy
-        expect(described_class.exists?(path: 'bar/test')).to be_truthy
-        expect(described_class.exists?(path: 'bar/test/foo')).to be_truthy
-        expect(described_class.exists?(path: 'gitlab-org')).to be_truthy
+      context 'when route name is nil' do
+        before do
+          route.update_column(:name, nil)
+        end
+
+        it "does not fail" do
+          expect(route.update_attributes(path: 'bar')).to be_truthy
+        end
       end
     end