Further refactor and syntax fixes.

1 files changed, 18 insertions, 4 deletions

diff --git a/spec/models/user_agent_detail_spec.rb b/spec/models/user_agent_detail_spec.rb
index ba21161fc7f..a8c25766e73 100644
--- a/spec/models/user_agent_detail_spec.rb
+++ b/spec/models/user_agent_detail_spec.rb
@@ -2,16 +2,30 @@ require 'rails_helper'
 
 describe UserAgentDetail, type: :model do
   describe '.submittable?' do
-    it 'should be submittable' do
-      detail = create(:user_agent_detail, :on_issue)
+    it 'is submittable when not already submitted' do
+      detail = build(:user_agent_detail)
+
       expect(detail.submittable?).to be_truthy
     end
+
+    it 'is not submittable when already submitted' do
+      detail = build(:user_agent_detail, submitted: true)
+
+      expect(detail.submittable?).to be_falsey
+    end
   end
 
   describe '.valid?' do
-    it 'should be valid with a subject' do
-      detail = create(:user_agent_detail, :on_issue)
+    it 'is valid with a subject' do
+      detail = build(:user_agent_detail)
+
       expect(detail).to be_valid
     end
+
+    it 'is invalid without a subject' do
+      detail = build(:user_agent_detail, subject: nil)
+
+      expect(detail).not_to be_valid
+    end
   end
 end