diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-09-19 04:45:44 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-09-19 04:45:44 +0300 |
commit | 85dc423f7090da0a52c73eb66faf22ddb20efff9 (patch) | |
tree | 9160f299afd8c80c038f08e1545be119f5e3f1e1 /spec/requests/api/issue_links_spec.rb | |
parent | 15c2c8c66dbe422588e5411eee7e68f1fa440bb8 (diff) |
Add latest changes from gitlab-org/gitlab@13-4-stable-ee
Diffstat (limited to 'spec/requests/api/issue_links_spec.rb')
-rw-r--r-- | spec/requests/api/issue_links_spec.rb | 207 |
1 files changed, 207 insertions, 0 deletions
diff --git a/spec/requests/api/issue_links_spec.rb b/spec/requests/api/issue_links_spec.rb new file mode 100644 index 00000000000..a4243766111 --- /dev/null +++ b/spec/requests/api/issue_links_spec.rb @@ -0,0 +1,207 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe API::IssueLinks do + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:issue) { create(:issue, project: project) } + + before do + project.add_guest(user) + end + + describe 'GET /links' do + context 'when unauthenticated' do + it 'returns 401' do + get api("/projects/#{project.id}/issues/#{issue.iid}/links") + + expect(response).to have_gitlab_http_status(:unauthorized) + end + end + + context 'when authenticated' do + it 'returns related issues' do + target_issue = create(:issue, project: project) + create(:issue_link, source: issue, target: target_issue) + + get api("/projects/#{project.id}/issues/#{issue.iid}/links", user) + + expect(response).to have_gitlab_http_status(:ok) + expect(json_response).to be_an Array + expect(json_response.length).to eq(1) + expect(response).to match_response_schema('public_api/v4/issue_links') + end + end + end + + describe 'POST /links' do + context 'when unauthenticated' do + it 'returns 401' do + target_issue = create(:issue) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links"), + params: { target_project_id: target_issue.project.id, target_issue_iid: target_issue.iid } + + expect(response).to have_gitlab_http_status(:unauthorized) + end + end + + context 'when authenticated' do + context 'given target project not found' do + it 'returns 404' do + target_issue = create(:issue) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: -1, target_issue_iid: target_issue.iid } + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Project Not Found') + end + end + + context 'given target issue not found' do + it 'returns 404' do + target_project = create(:project, :public) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: target_project.id, target_issue_iid: non_existing_record_iid } + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Not found') + end + end + + context 'when user does not have write access to given issue' do + it 'returns 404' do + unauthorized_project = create(:project) + target_issue = create(:issue, project: unauthorized_project) + unauthorized_project.add_guest(user) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: unauthorized_project.id, target_issue_iid: target_issue.iid } + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('No Issue found for given params') + end + end + + context 'when trying to relate to a confidential issue' do + it 'returns 404' do + project = create(:project, :public) + target_issue = create(:issue, :confidential, project: project) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: project.id, target_issue_iid: target_issue.iid } + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Not found') + end + end + + context 'when trying to relate to a private project issue' do + it 'returns 404' do + project = create(:project, :private) + target_issue = create(:issue, project: project) + + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: project.id, target_issue_iid: target_issue.iid } + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Project Not Found') + end + end + + context 'when user has ability to create an issue link' do + let_it_be(:target_issue) { create(:issue, project: project) } + + before do + project.add_reporter(user) + end + + it 'returns 201 status and contains the expected link response' do + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: project.id, target_issue_iid: target_issue.iid, link_type: 'relates_to' } + + expect_link_response(link_type: 'relates_to') + end + + it 'returns 201 when sending full path of target project' do + post api("/projects/#{project.id}/issues/#{issue.iid}/links", user), + params: { target_project_id: project.full_path, target_issue_iid: target_issue.iid } + + expect_link_response + end + + def expect_link_response(link_type: 'relates_to') + expect(response).to have_gitlab_http_status(:created) + expect(response).to match_response_schema('public_api/v4/issue_link') + expect(json_response['link_type']).to eq(link_type) + end + end + end + end + + describe 'DELETE /links/:issue_link_id' do + context 'when unauthenticated' do + it 'returns 401' do + issue_link = create(:issue_link) + + delete api("/projects/#{project.id}/issues/#{issue.iid}/links/#{issue_link.id}") + + expect(response).to have_gitlab_http_status(:unauthorized) + end + end + + context 'when authenticated' do + context 'when user does not have write access to given issue link' do + it 'returns 404' do + unauthorized_project = create(:project) + target_issue = create(:issue, project: unauthorized_project) + issue_link = create(:issue_link, source: issue, target: target_issue) + unauthorized_project.add_guest(user) + + delete api("/projects/#{project.id}/issues/#{issue.iid}/links/#{issue_link.id}", user) + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('No Issue Link found') + end + end + + context 'issue link not found' do + it 'returns 404' do + delete api("/projects/#{project.id}/issues/#{issue.iid}/links/#{non_existing_record_id}", user) + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Not found') + end + end + + context 'when trying to delete a link with a private project issue' do + it 'returns 404' do + project = create(:project, :private) + target_issue = create(:issue, project: project) + issue_link = create(:issue_link, source: issue, target: target_issue) + + delete api("/projects/#{project.id}/issues/#{issue.iid}/links/#{issue_link.id}", user) + + expect(response).to have_gitlab_http_status(:not_found) + expect(json_response['message']).to eq('404 Project Not Found') + end + end + + context 'when user has ability to delete the issue link' do + it 'returns 200' do + target_issue = create(:issue, project: project) + issue_link = create(:issue_link, source: issue, target: target_issue) + project.add_reporter(user) + + delete api("/projects/#{project.id}/issues/#{issue.iid}/links/#{issue_link.id}", user) + + expect(response).to have_gitlab_http_status(:ok) + expect(response).to match_response_schema('public_api/v4/issue_link') + end + end + end + end +end |