diff options
author | Robert Speicher <rspeicher@gmail.com> | 2021-01-20 22:34:23 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2021-01-20 22:34:23 +0300 |
commit | 6438df3a1e0fb944485cebf07976160184697d72 (patch) | |
tree | 00b09bfd170e77ae9391b1a2f5a93ef6839f2597 /spec/requests/api/terraform/state_spec.rb | |
parent | 42bcd54d971da7ef2854b896a7b34f4ef8601067 (diff) |
Add latest changes from gitlab-org/gitlab@13-8-stable-eev13.8.0-rc42
Diffstat (limited to 'spec/requests/api/terraform/state_spec.rb')
-rw-r--r-- | spec/requests/api/terraform/state_spec.rb | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/spec/requests/api/terraform/state_spec.rb b/spec/requests/api/terraform/state_spec.rb index 0fa088a641e..bfdb5458fd1 100644 --- a/spec/requests/api/terraform/state_spec.rb +++ b/spec/requests/api/terraform/state_spec.rb @@ -21,9 +21,36 @@ RSpec.describe API::Terraform::State do stub_terraform_state_object_storage end + shared_examples 'endpoint with unique user tracking' do + context 'without authentication' do + let(:auth_header) { basic_auth_header('bad', 'token') } + + before do + stub_feature_flags(usage_data_p_terraform_state_api_unique_users: false) + end + + it 'does not track unique event' do + expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event) + + request + end + end + + context 'with maintainer permissions' do + let(:current_user) { maintainer } + + it_behaves_like 'tracking unique hll events', :usage_data_p_terraform_state_api_unique_users do + let(:target_id) { 'p_terraform_state_api_unique_users' } + let(:expected_type) { instance_of(Integer) } + end + end + end + describe 'GET /projects/:id/terraform/state/:name' do subject(:request) { get api(state_path), headers: auth_header } + it_behaves_like 'endpoint with unique user tracking' + context 'without authentication' do let(:auth_header) { basic_auth_header('bad', 'token') } @@ -117,6 +144,8 @@ RSpec.describe API::Terraform::State do subject(:request) { post api(state_path), headers: auth_header, as: :json, params: params } + it_behaves_like 'endpoint with unique user tracking' + context 'when terraform state with a given name is already present' do context 'with maintainer permissions' do let(:current_user) { maintainer } @@ -219,6 +248,8 @@ RSpec.describe API::Terraform::State do describe 'DELETE /projects/:id/terraform/state/:name' do subject(:request) { delete api(state_path), headers: auth_header } + it_behaves_like 'endpoint with unique user tracking' + context 'with maintainer permissions' do let(:current_user) { maintainer } @@ -256,6 +287,8 @@ RSpec.describe API::Terraform::State do subject(:request) { post api("#{state_path}/lock"), headers: auth_header, params: params } + it_behaves_like 'endpoint with unique user tracking' + it 'locks the terraform state' do request @@ -305,6 +338,10 @@ RSpec.describe API::Terraform::State do subject(:request) { delete api("#{state_path}/lock"), headers: auth_header, params: params } + it_behaves_like 'endpoint with unique user tracking' do + let(:lock_id) { 'irrelevant to this test, just needs to be present' } + end + context 'with the correct lock id' do let(:lock_id) { '123-456' } |