diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-24 06:07:40 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-24 06:07:40 +0300 |
commit | a908d3a2c87fa52f6d9c6c459455a138b096ab09 (patch) | |
tree | 28b7b3ad77573949d10d9e24964754935d518421 /spec/requests/api | |
parent | 8212423bb8e15f763092671a66b12fa52fde7d08 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/requests/api')
-rw-r--r-- | spec/requests/api/composer_packages_spec.rb | 10 | ||||
-rw-r--r-- | spec/requests/api/conan_instance_packages_spec.rb | 2 | ||||
-rw-r--r-- | spec/requests/api/conan_project_packages_spec.rb | 1 | ||||
-rw-r--r-- | spec/requests/api/generic_packages_spec.rb | 6 | ||||
-rw-r--r-- | spec/requests/api/group_container_repositories_spec.rb | 4 | ||||
-rw-r--r-- | spec/requests/api/helm_packages_spec.rb | 6 | ||||
-rw-r--r-- | spec/requests/api/maven_packages_spec.rb | 7 | ||||
-rw-r--r-- | spec/requests/api/npm_project_packages_spec.rb | 3 | ||||
-rw-r--r-- | spec/requests/api/nuget_group_packages_spec.rb | 4 | ||||
-rw-r--r-- | spec/requests/api/nuget_project_packages_spec.rb | 10 | ||||
-rw-r--r-- | spec/requests/api/project_container_repositories_spec.rb | 18 | ||||
-rw-r--r-- | spec/requests/api/pypi_packages_spec.rb | 13 | ||||
-rw-r--r-- | spec/requests/api/rpm_project_packages_spec.rb | 7 | ||||
-rw-r--r-- | spec/requests/api/rubygem_packages_spec.rb | 6 | ||||
-rw-r--r-- | spec/requests/api/terraform/modules/v1/packages_spec.rb | 8 |
15 files changed, 60 insertions, 45 deletions
diff --git a/spec/requests/api/composer_packages_spec.rb b/spec/requests/api/composer_packages_spec.rb index 55c9347677b..4be488fc2f7 100644 --- a/spec/requests/api/composer_packages_spec.rb +++ b/spec/requests/api/composer_packages_spec.rb @@ -14,7 +14,10 @@ RSpec.describe API::ComposerPackages do let_it_be(:deploy_token_for_group) { create(:deploy_token, :group, read_package_registry: true, write_package_registry: true) } let_it_be(:group_deploy_token) { create(:group_deploy_token, deploy_token: deploy_token_for_group, group: group) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:snowplow_gitlab_standard_context) do + { project: project, namespace: project.namespace, user: user, property: 'i_package_composer_user' } + end + let(:headers) { {} } using RSpec::Parameterized::TableSyntax @@ -491,7 +494,6 @@ RSpec.describe API::ComposerPackages do with_them do let(:token) { user_token ? personal_access_token.token : 'wrong' } let(:headers) { user_role == :anonymous ? {} : basic_auth_header(user.username, token) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } before do project.update!(visibility_level: Gitlab::VisibilityLevel.const_get(project_visibility_level, false)) @@ -501,6 +503,10 @@ RSpec.describe API::ComposerPackages do include_context 'Composer user type', params[:user_role], params[:member] do if params[:expected_status] == :success + let(:snowplow_gitlab_standard_context) do + { project: project, namespace: project.namespace, property: 'i_package_composer_user' } + end + it_behaves_like 'a package tracking event', described_class.name, 'pull_package' else it_behaves_like 'not a package tracking event' diff --git a/spec/requests/api/conan_instance_packages_spec.rb b/spec/requests/api/conan_instance_packages_spec.rb index b343e0cfc97..d3ab676d7ee 100644 --- a/spec/requests/api/conan_instance_packages_spec.rb +++ b/spec/requests/api/conan_instance_packages_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' RSpec.describe API::ConanInstancePackages do - let(:snowplow_standard_context_params) { { user: user, project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) { { user: user, project: project, namespace: project.namespace, property: 'i_package_conan_user' } } include_context 'conan api setup' diff --git a/spec/requests/api/conan_project_packages_spec.rb b/spec/requests/api/conan_project_packages_spec.rb index 4e6af9942ef..3ab43727ccf 100644 --- a/spec/requests/api/conan_project_packages_spec.rb +++ b/spec/requests/api/conan_project_packages_spec.rb @@ -5,7 +5,6 @@ RSpec.describe API::ConanProjectPackages do include_context 'conan api setup' let(:project_id) { project.id } - let(:snowplow_standard_context_params) { { user: user, project: project, namespace: project.namespace } } describe 'GET /api/v4/projects/:id/packages/conan/v1/ping' do let(:url) { "/projects/#{project.id}/packages/conan/v1/ping" } diff --git a/spec/requests/api/generic_packages_spec.rb b/spec/requests/api/generic_packages_spec.rb index 0478e123086..c1faa722d30 100644 --- a/spec/requests/api/generic_packages_spec.rb +++ b/spec/requests/api/generic_packages_spec.rb @@ -19,7 +19,7 @@ RSpec.describe API::GenericPackages do let(:user) { personal_access_token.user } let(:ci_build) { create(:ci_build, :running, user: user, project: project) } - let(:snowplow_standard_context_params) { { user: user, project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) { { user: user, project: project, namespace: project.namespace, property: 'i_package_generic_user' } } def auth_header return {} if user_role == :anonymous @@ -408,8 +408,6 @@ RSpec.describe API::GenericPackages do end context 'event tracking' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } - subject { upload_file(params, workhorse_headers.merge(personal_access_token_header)) } it_behaves_like 'a package tracking event', described_class.name, 'push_package' @@ -645,8 +643,6 @@ RSpec.describe API::GenericPackages do end context 'event tracking' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } - before do project.add_developer(user) end diff --git a/spec/requests/api/group_container_repositories_spec.rb b/spec/requests/api/group_container_repositories_spec.rb index 82daab0e5e8..fcb7085a17a 100644 --- a/spec/requests/api/group_container_repositories_spec.rb +++ b/spec/requests/api/group_container_repositories_spec.rb @@ -35,7 +35,9 @@ RSpec.describe API::GroupContainerRepositories do describe 'GET /groups/:id/registry/repositories' do let(:url) { "/groups/#{group.id}/registry/repositories" } - let(:snowplow_gitlab_standard_context) { { user: api_user, namespace: group } } + let(:snowplow_gitlab_standard_context) do + { user: api_user, namespace: group, property: 'i_package_container_user' } + end subject { get api(url, api_user) } diff --git a/spec/requests/api/helm_packages_spec.rb b/spec/requests/api/helm_packages_spec.rb index 6bd81f64913..249ab0e7302 100644 --- a/spec/requests/api/helm_packages_spec.rb +++ b/spec/requests/api/helm_packages_spec.rb @@ -17,6 +17,8 @@ RSpec.describe API::HelmPackages do let_it_be(:package_file2_2) { create(:helm_package_file, package: package2, file_sha256: 'file2', file_name: 'filename2.tgz', channel: 'test', description: 'hello from test channel') } let_it_be(:other_package) { create(:npm_package, project: project) } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_helm_user' } } + describe 'GET /api/v4/projects/:id/packages/helm/:channel/index.yaml' do let(:project_id) { project.id } let(:channel) { 'stable' } @@ -63,7 +65,6 @@ RSpec.describe API::HelmPackages do with_them do let(:headers) { user_role == :anonymous ? {} : basic_auth_header(user.username, personal_access_token.token) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } before do project.update!(visibility: visibility.to_s) @@ -74,8 +75,6 @@ RSpec.describe API::HelmPackages do end context 'with access to package registry for everyone' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } - before do project.update!(visibility: Gitlab::VisibilityLevel::PRIVATE) project.project_feature.update!(package_registry_access_level: ProjectFeature::PUBLIC) @@ -152,7 +151,6 @@ RSpec.describe API::HelmPackages do let(:params) { { chart: temp_file(file_name) } } let(:file_key) { :chart } let(:send_rewritten_field) { true } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } subject do workhorse_finalize( diff --git a/spec/requests/api/maven_packages_spec.rb b/spec/requests/api/maven_packages_spec.rb index ac8c4aacdf2..4bb78eaab16 100644 --- a/spec/requests/api/maven_packages_spec.rb +++ b/spec/requests/api/maven_packages_spec.rb @@ -22,7 +22,8 @@ RSpec.describe API::MavenPackages do let_it_be(:deploy_token_for_group) { create(:deploy_token, :group, read_package_registry: true, write_package_registry: true) } let_it_be(:group_deploy_token) { create(:group_deploy_token, deploy_token: deploy_token_for_group, group: group) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_maven_user' } } + let(:package_name) { 'com/example/my-app' } let(:headers) { workhorse_headers } let(:headers_with_token) { headers.merge('Private-Token' => personal_access_token.token) } @@ -98,8 +99,6 @@ RSpec.describe API::MavenPackages do context 'with jar file' do let_it_be(:package_file) { jar_file } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } - it_behaves_like 'a package tracking event', described_class.name, 'pull_package' end end @@ -900,6 +899,8 @@ RSpec.describe API::MavenPackages do it_behaves_like 'package workhorse uploads' context 'event tracking' do + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user, property: 'i_package_maven_user' } } + it_behaves_like 'a package tracking event', described_class.name, 'push_package' context 'when the package file fails to be created' do diff --git a/spec/requests/api/npm_project_packages_spec.rb b/spec/requests/api/npm_project_packages_spec.rb index 3af4215052e..6fc3d0ceb48 100644 --- a/spec/requests/api/npm_project_packages_spec.rb +++ b/spec/requests/api/npm_project_packages_spec.rb @@ -55,7 +55,6 @@ RSpec.describe API::NpmProjectPackages do end describe 'GET /api/v4/projects/:id/packages/npm/*package_name/-/*file_name' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } let(:package_file) { package.package_files.first } let(:headers) { {} } @@ -215,7 +214,7 @@ RSpec.describe API::NpmProjectPackages do let_it_be(:version) { '1.2.3' } let(:params) { upload_params(package_name: package_name, package_version: version) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user, property: 'i_package_npm_user' } } shared_examples 'handling upload with different authentications' do context 'with access token' do diff --git a/spec/requests/api/nuget_group_packages_spec.rb b/spec/requests/api/nuget_group_packages_spec.rb index c1375288809..a678d2efff8 100644 --- a/spec/requests/api/nuget_group_packages_spec.rb +++ b/spec/requests/api/nuget_group_packages_spec.rb @@ -12,6 +12,7 @@ RSpec.describe API::NugetGroupPackages do let_it_be(:deploy_token) { create(:deploy_token, :group, read_package_registry: true, write_package_registry: true) } let_it_be(:group_deploy_token) { create(:group_deploy_token, deploy_token: deploy_token, group: group) } + let(:snowplow_gitlab_standard_context) { { namespace: project.group, property: 'i_package_nuget_user' } } let(:target_type) { 'groups' } shared_examples 'handling all endpoints' do @@ -46,7 +47,6 @@ RSpec.describe API::NugetGroupPackages do let_it_be(:group_deploy_token) { create(:group_deploy_token, deploy_token: deploy_token, group: subgroup) } let(:target) { subgroup } - let(:snowplow_gitlab_standard_context) { { namespace: subgroup } } it_behaves_like 'handling all endpoints' @@ -58,7 +58,7 @@ RSpec.describe API::NugetGroupPackages do context 'a group' do let(:target) { group } - let(:snowplow_gitlab_standard_context) { { namespace: group } } + let(:snowplow_gitlab_standard_context) { { namespace: target, property: 'i_package_nuget_user' } } it_behaves_like 'handling all endpoints' diff --git a/spec/requests/api/nuget_project_packages_spec.rb b/spec/requests/api/nuget_project_packages_spec.rb index 4617583493d..4866185cd12 100644 --- a/spec/requests/api/nuget_project_packages_spec.rb +++ b/spec/requests/api/nuget_project_packages_spec.rb @@ -13,6 +13,7 @@ RSpec.describe API::NugetProjectPackages do let(:target) { project } let(:target_type) { 'projects' } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_nuget_user' } } shared_examples 'accept get request on private project with access to package registry for everyone' do subject { get api(url) } @@ -28,9 +29,7 @@ RSpec.describe API::NugetProjectPackages do describe 'GET /api/v4/projects/:id/packages/nuget' do let(:url) { "/projects/#{target.id}/packages/nuget/index.json" } - it_behaves_like 'handling nuget service requests' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } - end + it_behaves_like 'handling nuget service requests' it_behaves_like 'accept get request on private project with access to package registry for everyone' end @@ -58,9 +57,7 @@ RSpec.describe API::NugetProjectPackages do describe 'GET /api/v4/projects/:id/packages/nuget/query' do let(:url) { "/projects/#{target.id}/packages/nuget/query?#{query_parameters.to_query}" } - it_behaves_like 'handling nuget search requests' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } - end + it_behaves_like 'handling nuget search requests' it_behaves_like 'accept get request on private project with access to package registry for everyone' do let_it_be(:query_parameters) { { q: 'query', take: 5, skip: 0, prerelease: true } } @@ -152,7 +149,6 @@ RSpec.describe API::NugetProjectPackages do with_them do let(:token) { user_token ? personal_access_token.token : 'wrong' } let(:headers) { user_role == :anonymous ? {} : basic_auth_header(user.username, token) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } subject { get api(url), headers: headers } diff --git a/spec/requests/api/project_container_repositories_spec.rb b/spec/requests/api/project_container_repositories_spec.rb index 52ec06d76a9..94aceffc6fa 100644 --- a/spec/requests/api/project_container_repositories_spec.rb +++ b/spec/requests/api/project_container_repositories_spec.rb @@ -33,7 +33,10 @@ RSpec.describe API::ProjectContainerRepositories do let(:method) { :get } let(:params) { {} } - let(:snowplow_gitlab_standard_context) { { user: api_user, project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) do + { user: api_user, project: project, namespace: project.namespace, + property: 'i_package_container_user' } + end before_all do project.add_maintainer(maintainer) @@ -414,6 +417,9 @@ RSpec.describe API::ProjectContainerRepositories do context 'for developer', :snowplow do let(:api_user) { developer } + let(:service_ping_context) do + [Gitlab::Tracking::ServicePingContext.new(data_source: :redis_hll, event: 'i_package_container_user').to_h] + end context 'when there are multiple tags' do before do @@ -427,7 +433,10 @@ RSpec.describe API::ProjectContainerRepositories do subject expect(response).to have_gitlab_http_status(:ok) - expect_snowplow_event(category: described_class.name, action: 'delete_tag', project: project, user: api_user, namespace: project.namespace) + expect_snowplow_event(category: described_class.name, action: 'delete_tag', project: project, + user: api_user, namespace: project.namespace.reload, + label: 'redis_hll_counters.user_packages.user_packages_total_unique_counts_monthly', + property: 'i_package_container_user', context: service_ping_context) end end @@ -443,7 +452,10 @@ RSpec.describe API::ProjectContainerRepositories do subject expect(response).to have_gitlab_http_status(:ok) - expect_snowplow_event(category: described_class.name, action: 'delete_tag', project: project, user: api_user, namespace: project.namespace) + expect_snowplow_event(category: described_class.name, action: 'delete_tag', project: project, + user: api_user, namespace: project.namespace.reload, + label: 'redis_hll_counters.user_packages.user_packages_total_unique_counts_monthly', + property: 'i_package_container_user', context: service_ping_context) end end end diff --git a/spec/requests/api/pypi_packages_spec.rb b/spec/requests/api/pypi_packages_spec.rb index 12091158a02..2b022dc8f62 100644 --- a/spec/requests/api/pypi_packages_spec.rb +++ b/spec/requests/api/pypi_packages_spec.rb @@ -14,6 +14,7 @@ RSpec.describe API::PypiPackages do let_it_be(:deploy_token) { create(:deploy_token, read_package_registry: true, write_package_registry: true) } let_it_be(:project_deploy_token) { create(:project_deploy_token, deploy_token: deploy_token, project: project) } let_it_be(:job) { create(:ci_build, :running, user: user, project: project) } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_pypi_user' } } let(:headers) { {} } @@ -25,7 +26,7 @@ RSpec.describe API::PypiPackages do describe 'GET /api/v4/groups/:id/-/packages/pypi/simple' do let(:url) { "/groups/#{group.id}/-/packages/pypi/simple" } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_pypi_user' } } it_behaves_like 'pypi simple index API endpoint' it_behaves_like 'rejects PyPI access with unknown group id' @@ -63,7 +64,7 @@ RSpec.describe API::PypiPackages do describe 'GET /api/v4/projects/:id/packages/pypi/simple' do let(:package_name) { package.name } let(:url) { "/projects/#{project.id}/packages/pypi/simple" } - let(:snowplow_gitlab_standard_context) { { project: nil, namespace: group } } + let(:snowplow_gitlab_standard_context) { { project: nil, namespace: group, property: 'i_package_pypi_user' } } it_behaves_like 'pypi simple index API endpoint' it_behaves_like 'rejects PyPI access with unknown project id' @@ -81,13 +82,13 @@ RSpec.describe API::PypiPackages do context 'simple package API endpoint' do let_it_be(:package) { create(:pypi_package, project: project) } + let(:snowplow_gitlab_standard_context) { { project: nil, namespace: group, property: 'i_package_pypi_user' } } subject { get api(url), headers: headers } describe 'GET /api/v4/groups/:id/-/packages/pypi/simple/:package_name' do let(:package_name) { package.name } let(:url) { "/groups/#{group.id}/-/packages/pypi/simple/#{package_name}" } - let(:snowplow_gitlab_standard_context) { { project: nil, namespace: group } } it_behaves_like 'pypi simple API endpoint' it_behaves_like 'rejects PyPI access with unknown group id' @@ -125,7 +126,7 @@ RSpec.describe API::PypiPackages do describe 'GET /api/v4/projects/:id/packages/pypi/simple/:package_name' do let(:package_name) { package.name } let(:url) { "/projects/#{project.id}/packages/pypi/simple/#{package_name}" } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_pypi_user' } } it_behaves_like 'pypi simple API endpoint' it_behaves_like 'rejects PyPI access with unknown project id' @@ -202,7 +203,7 @@ RSpec.describe API::PypiPackages do let(:base_params) { { requires_python: requires_python, version: '1.0.0', name: 'sample-project', sha256_digest: '1' * 64, md5_digest: '1' * 32 } } let(:params) { base_params.merge(content: temp_file(file_name)) } let(:send_rewritten_field) { true } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user, property: 'i_package_pypi_user' } } subject do workhorse_finalize( @@ -366,7 +367,6 @@ RSpec.describe API::PypiPackages do describe 'GET /api/v4/groups/:id/-/packages/pypi/files/:sha256/*file_identifier' do let(:url) { "/groups/#{group.id}/-/packages/pypi/files/#{package.package_files.first.file_sha256}/#{package_name}-1.0.0.tar.gz" } - let(:snowplow_gitlab_standard_context) { {} } it_behaves_like 'pypi file download endpoint' it_behaves_like 'rejects PyPI access with unknown group id' @@ -375,7 +375,6 @@ RSpec.describe API::PypiPackages do describe 'GET /api/v4/projects/:id/packages/pypi/files/:sha256/*file_identifier' do let(:url) { "/projects/#{project.id}/packages/pypi/files/#{package.package_files.first.file_sha256}/#{package_name}-1.0.0.tar.gz" } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } it_behaves_like 'pypi file download endpoint' it_behaves_like 'rejects PyPI access with unknown project id' diff --git a/spec/requests/api/rpm_project_packages_spec.rb b/spec/requests/api/rpm_project_packages_spec.rb index 68511795c94..f367ad8c59f 100644 --- a/spec/requests/api/rpm_project_packages_spec.rb +++ b/spec/requests/api/rpm_project_packages_spec.rb @@ -136,7 +136,7 @@ RSpec.describe API::RpmProjectPackages do end describe 'GET /api/v4/projects/:id/packages/rpm/:package_file_id/:filename' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: group } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: group, property: 'i_package_rpm_user' } } let(:url) { "/projects/#{project.id}/packages/rpm/#{package_file_id}/#{package_name}" } subject { get api(url), headers: headers } @@ -148,7 +148,10 @@ RSpec.describe API::RpmProjectPackages do end describe 'POST /api/v4/projects/:project_id/packages/rpm' do - let(:snowplow_gitlab_standard_context) { { project: project, namespace: group, user: user } } + let(:snowplow_gitlab_standard_context) do + { project: project, namespace: group, user: user, property: 'i_package_rpm_user' } + end + let(:url) { "/projects/#{project.id}/packages/rpm" } let(:file_upload) { fixture_file_upload('spec/fixtures/packages/rpm/hello-0.0.1-1.fc29.x86_64.rpm') } diff --git a/spec/requests/api/rubygem_packages_spec.rb b/spec/requests/api/rubygem_packages_spec.rb index a7d461781b8..ee43aaa6ead 100644 --- a/spec/requests/api/rubygem_packages_spec.rb +++ b/spec/requests/api/rubygem_packages_spec.rb @@ -15,7 +15,7 @@ RSpec.describe API::RubygemPackages do let_it_be(:project_deploy_token) { create(:project_deploy_token, deploy_token: deploy_token, project: project) } let_it_be(:headers) { {} } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: user, property: 'i_package_rubygems_user' } } let(:tokens) do { @@ -164,7 +164,7 @@ RSpec.describe API::RubygemPackages do with_them do let(:token) { valid_token ? tokens[token_type] : 'invalid-token123' } let(:headers) { user_role == :anonymous ? {} : { 'HTTP_AUTHORIZATION' => token } } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, property: 'i_package_rubygems_user' } } before do project.update_column(:visibility_level, Gitlab::VisibilityLevel.level_value(visibility.to_s)) @@ -323,7 +323,7 @@ RSpec.describe API::RubygemPackages do let(:token) { valid_token ? tokens[token_type] : 'invalid-token123' } let(:user_headers) { user_role == :anonymous ? {} : { 'HTTP_AUTHORIZATION' => token } } let(:headers) { user_headers.merge(workhorse_headers) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: snowplow_user } } + let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: snowplow_user, property: 'i_package_rubygems_user' } } let(:snowplow_user) do case token_type when :deploy_token diff --git a/spec/requests/api/terraform/modules/v1/packages_spec.rb b/spec/requests/api/terraform/modules/v1/packages_spec.rb index ae61017f5bb..c2af3a134f4 100644 --- a/spec/requests/api/terraform/modules/v1/packages_spec.rb +++ b/spec/requests/api/terraform/modules/v1/packages_spec.rb @@ -418,7 +418,8 @@ RSpec.describe API::Terraform::Modules::V1::Packages do { project: project, user: user_role == :anonymous ? nil : user, - namespace: project.namespace + namespace: project.namespace, + property: 'i_package_terraform_module_user' } end @@ -583,7 +584,10 @@ RSpec.describe API::Terraform::Modules::V1::Packages do with_them do let(:user_headers) { user_role == :anonymous ? {} : { token_header => token } } let(:headers) { user_headers.merge(workhorse_headers) } - let(:snowplow_gitlab_standard_context) { { project: project, namespace: project.namespace, user: snowplow_user } } + let(:snowplow_gitlab_standard_context) do + { project: project, namespace: project.namespace, user: snowplow_user, property: 'i_package_terraform_module_user' } + end + let(:snowplow_user) do case token_type when :deploy_token |