diff options
author | Shinya Maeda <shinya@gitlab.com> | 2017-08-24 15:51:46 +0300 |
---|---|---|
committer | Shinya Maeda <shinya@gitlab.com> | 2017-09-04 15:10:34 +0300 |
commit | 362f2226a5febb7a3a82e86f4a83e87a870d67b3 (patch) | |
tree | 618071ce63102842b8e1fc1f6af187fe4cf2b67b /spec/requests | |
parent | fb8f32a92cdfe4cca24cb80a91e8fe48d6b0df25 (diff) |
Improve by zj nice catches
Diffstat (limited to 'spec/requests')
-rw-r--r-- | spec/requests/api/pipeline_schedules_spec.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/spec/requests/api/pipeline_schedules_spec.rb b/spec/requests/api/pipeline_schedules_spec.rb index 8239c26facd..86e834b5a22 100644 --- a/spec/requests/api/pipeline_schedules_spec.rb +++ b/spec/requests/api/pipeline_schedules_spec.rb @@ -303,7 +303,7 @@ describe API::PipelineSchedules do describe 'POST /projects/:id/pipeline_schedules/:pipeline_schedule_id/variables' do let(:params) { attributes_for(:ci_pipeline_schedule_variable) } - let(:pipeline_schedule) do + set(:pipeline_schedule) do create(:ci_pipeline_schedule, project: project, owner: developer) end @@ -359,7 +359,7 @@ describe API::PipelineSchedules do end describe 'PUT /projects/:id/pipeline_schedules/:pipeline_schedule_id/variables/:key' do - let(:pipeline_schedule) do + set(:pipeline_schedule) do create(:ci_pipeline_schedule, project: project, owner: developer) end @@ -398,7 +398,7 @@ describe API::PipelineSchedules do describe 'DELETE /projects/:id/pipeline_schedules/:pipeline_schedule_id/variables/:key' do let(:master) { create(:user) } - let!(:pipeline_schedule) do + set(:pipeline_schedule) do create(:ci_pipeline_schedule, project: project, owner: developer) end @@ -427,7 +427,7 @@ describe API::PipelineSchedules do end end - context 'authenticated user with invalid permissions' do # TODO: + context 'authenticated user with invalid permissions' do let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: master) } it 'does not delete pipeline_schedule_variable' do |