diff options
author | Rémy Coutable <remy@rymai.me> | 2016-05-04 19:07:13 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-05-04 19:07:13 +0300 |
commit | 1a9d50597262a31f03dc66584f05d66b905d9d59 (patch) | |
tree | 2599b4983b22fb9e617a80d9205e4401a6e1aee7 /spec/requests | |
parent | c2c70cfcb31f67809d8dfb5f470e0dc1eefe15d9 (diff) | |
parent | 209f2f1e6fd861dd7bb6a73389400b4bb266d26d (diff) |
Merge branch 'use-rugged-to-create-tag' into 'master'
Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag for better performance
This was originally opened at !1757 by @pcarranza but I changed it to use Rugged instead of gitlab_git, following @DouweM's request.
Once this is merged, https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/26 will be mergeable too.
See merge request !3745
Diffstat (limited to 'spec/requests')
-rw-r--r-- | spec/requests/api/tags_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/requests/api/tags_spec.rb b/spec/requests/api/tags_spec.rb index edcb2bedbf7..12e170b232f 100644 --- a/spec/requests/api/tags_spec.rb +++ b/spec/requests/api/tags_spec.rb @@ -147,7 +147,7 @@ describe API::API, api: true do tag_name: 'v8.0.0', ref: 'master' expect(response.status).to eq(400) - expect(json_response['message']).to eq('Tag already exists') + expect(json_response['message']).to eq('Tag v8.0.0 already exists') end it 'should return 400 if ref name is invalid' do @@ -155,7 +155,7 @@ describe API::API, api: true do tag_name: 'mytag', ref: 'foo' expect(response.status).to eq(400) - expect(json_response['message']).to eq('Invalid reference name') + expect(json_response['message']).to eq('Target foo is invalid') end end |