Merge branch '32821-better-error-message-add-invalid-user-to-project' into 'master'

Resolve "Improve Error Message When Adding Invalid User to Project via API"

Closes #32821

See merge request gitlab-org/gitlab-ce!20885

1 files changed, 8 insertions, 0 deletions

diff --git a/spec/requests/api/members_spec.rb b/spec/requests/api/members_spec.rb
index c621760b6c4..93e1c3a2294 100644
--- a/spec/requests/api/members_spec.rb
+++ b/spec/requests/api/members_spec.rb
@@ -231,6 +231,14 @@ describe API::Members do
         expect(response).to have_gitlab_http_status(409)
       end
 
+      it 'returns 404 when the user_id is not valid' do
+        post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
+             user_id: 0, access_level: Member::MAINTAINER
+
+        expect(response).to have_gitlab_http_status(404)
+        expect(json_response['message']).to eq('404 User Not Found')
+      end
+
       it 'returns 400 when user_id is not given' do
         post api("/#{source_type.pluralize}/#{source.id}/members", maintainer),
              access_level: Member::MAINTAINER