diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-01-20 12:16:11 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-01-20 12:16:11 +0300 |
commit | edaa33dee2ff2f7ea3fac488d41558eb5f86d68c (patch) | |
tree | 11f143effbfeba52329fb7afbd05e6e2a3790241 /spec/rubocop/cop/migration | |
parent | d8a5691316400a0f7ec4f83832698f1988eb27c1 (diff) |
Add latest changes from gitlab-org/gitlab@14-7-stable-eev14.7.0-rc42
Diffstat (limited to 'spec/rubocop/cop/migration')
-rw-r--r-- | spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb | 58 | ||||
-rw-r--r-- | spec/rubocop/cop/migration/schedule_async_spec.rb | 32 |
2 files changed, 62 insertions, 28 deletions
diff --git a/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb b/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb new file mode 100644 index 00000000000..aa63259288d --- /dev/null +++ b/spec/rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction_spec.rb @@ -0,0 +1,58 @@ +# frozen_string_literal: true + +require 'fast_spec_helper' +require_relative '../../../../rubocop/cop/migration/prevent_global_enable_lock_retries_with_disable_ddl_transaction' + +RSpec.describe RuboCop::Cop::Migration::PreventGlobalEnableLockRetriesWithDisableDdlTransaction do + subject(:cop) { described_class.new } + + context 'when in migration' do + before do + allow(cop).to receive(:in_migration?).and_return(true) + end + + it 'registers an offense when `enable_lock_retries` and `disable_ddl_transaction` is used together' do + code = <<~RUBY + class SomeMigration < ActiveRecord::Migration[6.0] + enable_lock_retries! + disable_ddl_transaction! + end + RUBY + + expect_offense(<<~RUBY, node: code, msg: described_class::MSG) + class SomeMigration < ActiveRecord::Migration[6.0] + enable_lock_retries! + disable_ddl_transaction! + ^^^^^^^^^^^^^^^^^^^^^^^^ %{msg} + end + RUBY + end + + it 'registers no offense when `enable_lock_retries!` is used' do + expect_no_offenses(<<~RUBY) + class SomeMigration < ActiveRecord::Migration[6.0] + enable_lock_retries! + end + RUBY + end + + it 'registers no offense when `disable_ddl_transaction!` is used' do + expect_no_offenses(<<~RUBY) + class SomeMigration < ActiveRecord::Migration[6.0] + disable_ddl_transaction! + end + RUBY + end + end + + context 'when outside of migration' do + it 'registers no offense' do + expect_no_offenses(<<~RUBY) + class SomeMigration + enable_lock_retries! + disable_ddl_transaction! + end + RUBY + end + end +end diff --git a/spec/rubocop/cop/migration/schedule_async_spec.rb b/spec/rubocop/cop/migration/schedule_async_spec.rb index b89acb6db41..5f848dd9b66 100644 --- a/spec/rubocop/cop/migration/schedule_async_spec.rb +++ b/spec/rubocop/cop/migration/schedule_async_spec.rb @@ -43,24 +43,18 @@ RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do end context 'BackgroundMigrationWorker.perform_async' do - it 'adds an offense when calling `BackgroundMigrationWorker.peform_async` and corrects', :aggregate_failures do + it 'adds an offense when calling `BackgroundMigrationWorker.peform_async`' do expect_offense(<<~RUBY) def up BackgroundMigrationWorker.perform_async(ClazzName, "Bar", "Baz") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't call [...] end RUBY - - expect_correction(<<~RUBY) - def up - migrate_async(ClazzName, "Bar", "Baz") - end - RUBY end end context 'BackgroundMigrationWorker.perform_in' do - it 'adds an offense and corrects', :aggregate_failures do + it 'adds an offense' do expect_offense(<<~RUBY) def up BackgroundMigrationWorker @@ -68,17 +62,11 @@ RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do .perform_in(delay, ClazzName, "Bar", "Baz") end RUBY - - expect_correction(<<~RUBY) - def up - migrate_in(delay, ClazzName, "Bar", "Baz") - end - RUBY end end context 'BackgroundMigrationWorker.bulk_perform_async' do - it 'adds an offense and corrects', :aggregate_failures do + it 'adds an offense' do expect_offense(<<~RUBY) def up BackgroundMigrationWorker @@ -86,17 +74,11 @@ RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do .bulk_perform_async(jobs) end RUBY - - expect_correction(<<~RUBY) - def up - bulk_migrate_async(jobs) - end - RUBY end end context 'BackgroundMigrationWorker.bulk_perform_in' do - it 'adds an offense and corrects', :aggregate_failures do + it 'adds an offense' do expect_offense(<<~RUBY) def up BackgroundMigrationWorker @@ -104,12 +86,6 @@ RSpec.describe RuboCop::Cop::Migration::ScheduleAsync do .bulk_perform_in(5.minutes, jobs) end RUBY - - expect_correction(<<~RUBY) - def up - bulk_migrate_in(5.minutes, jobs) - end - RUBY end end end |