Add latest changes from gitlab-org/gitlab@master

1 files changed, 54 insertions, 0 deletions

diff --git a/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb b/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb
new file mode 100644
index 00000000000..8ee720af9a5
--- /dev/null
+++ b/spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb
@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require 'rubocop'
+require 'rubocop/rspec/support'
+
+require_relative '../../../../rubocop/cop/qa/ambiguous_page_object_name'
+
+describe RuboCop::Cop::QA::AmbiguousPageObjectName do
+  include CopHelper
+
+  let(:source_file) { 'qa/page.rb' }
+
+  subject(:cop) { described_class.new }
+
+  context 'in a QA file' do
+    before do
+      allow(cop).to receive(:in_qa_file?).and_return(true)
+    end
+
+    it "registers an offense for pages named `page`" do
+      expect_offense(<<-RUBY)
+      Page::Layout::Bar.perform do |page|
+                                    ^^^^ Don't use 'page' as a name for a Page Object. Use `bar` instead.
+        expect(page).to have_performance_bar
+        expect(page).to have_detailed_metrics
+      end
+      RUBY
+    end
+
+    it "doesnt offend if the page object is named otherwise" do
+      expect_no_offenses(<<-RUBY)
+        Page::Object.perform do |obj|
+          obj.whatever
+        end
+      RUBY
+    end
+  end
+
+  context 'outside of a QA file' do
+    before do
+      allow(cop).to receive(:in_qa_file?).and_return(false)
+    end
+
+    it "does not register an offense" do
+      expect_no_offenses(<<-RUBY)
+        Page::Object.perform do |page|
+          page.do_something
+        end
+      RUBY
+    end
+  end
+end