diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
commit | 859a6fb938bb9ee2a317c46dfa4fcc1af49608f0 (patch) | |
tree | d7f2700abe6b4ffcb2dcfc80631b2d87d0609239 /spec/rubocop/cop/rspec/be_success_matcher_spec.rb | |
parent | 446d496a6d000c73a304be52587cd9bbc7493136 (diff) |
Add latest changes from gitlab-org/gitlab@13-9-stable-eev13.9.0-rc42
Diffstat (limited to 'spec/rubocop/cop/rspec/be_success_matcher_spec.rb')
-rw-r--r-- | spec/rubocop/cop/rspec/be_success_matcher_spec.rb | 27 |
1 files changed, 10 insertions, 17 deletions
diff --git a/spec/rubocop/cop/rspec/be_success_matcher_spec.rb b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb index d49507c89b1..050f0396fac 100644 --- a/spec/rubocop/cop/rspec/be_success_matcher_spec.rb +++ b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb @@ -5,34 +5,27 @@ require 'rubocop' require_relative '../../../../rubocop/cop/rspec/be_success_matcher' RSpec.describe RuboCop::Cop::RSpec::BeSuccessMatcher do - include CopHelper - let(:source_file) { 'spec/foo_spec.rb' } subject(:cop) { described_class.new } shared_examples 'cop' do |good:, bad:| context "using #{bad} call" do - it 'registers an offense' do - inspect_source(bad, source_file) - - expect(cop.offenses.size).to eq(1) - expect(cop.offenses.map(&:line)).to eq([1]) - expect(cop.highlights).to eq([bad]) - end - - it "autocorrects it to `#{good}`" do - autocorrected = autocorrect_source(bad, source_file) - - expect(autocorrected).to eql(good) + it 'registers an offense and corrects', :aggregate_failures do + expect_offense(<<~CODE, node: bad) + %{node} + ^{node} Do not use deprecated `success?` method, use `successful?` instead. + CODE + + expect_correction(<<~CODE) + #{good} + CODE end end context "using #{good} call" do it 'does not register an offense' do - inspect_source(good) - - expect(cop.offenses).to be_empty + expect_no_offenses(good) end end end |