diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-02-18 13:34:06 +0300 |
commit | 859a6fb938bb9ee2a317c46dfa4fcc1af49608f0 (patch) | |
tree | d7f2700abe6b4ffcb2dcfc80631b2d87d0609239 /spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb | |
parent | 446d496a6d000c73a304be52587cd9bbc7493136 (diff) |
Add latest changes from gitlab-org/gitlab@13-9-stable-eev13.9.0-rc42
Diffstat (limited to 'spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb')
-rw-r--r-- | spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb | 39 |
1 files changed, 13 insertions, 26 deletions
diff --git a/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb b/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb index d9e3ca5741c..ffabbae90dc 100644 --- a/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb +++ b/spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb @@ -5,33 +5,20 @@ require 'rubocop' require_relative '../../../../rubocop/cop/rspec/modify_sidekiq_middleware' RSpec.describe RuboCop::Cop::RSpec::ModifySidekiqMiddleware do - include CopHelper - subject(:cop) { described_class.new } - let(:source) do - <<~SRC - Sidekiq::Testing.server_middleware do |chain| - chain.add(MyCustomMiddleware) - end - SRC - end - - let(:corrected) do - <<~SRC - with_sidekiq_server_middleware do |chain| - chain.add(MyCustomMiddleware) - end - SRC - end - - it 'registers an offence' do - inspect_source(source) - - expect(cop.offenses.size).to eq(1) - end - - it 'can autocorrect the source' do - expect(autocorrect_source(source)).to eq(corrected) + it 'registers an offense and corrects', :aggregate_failures do + expect_offense(<<~CODE) + Sidekiq::Testing.server_middleware do |chain| + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't modify global sidekiq middleware, [...] + chain.add(MyCustomMiddleware) + end + CODE + + expect_correction(<<~CODE) + with_sidekiq_server_middleware do |chain| + chain.add(MyCustomMiddleware) + end + CODE end end |