diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-01-10 09:50:51 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-01-10 12:30:41 +0300 |
| commit | 05f30ac6bbb5c6f5dcc7fb045bb8761434290367 (patch) | |
| tree | c0f16d225f98957709f7babaef965dc541efd94f /spec/services/ci/destroy_pipeline_service_spec.rb | |
| parent | 4a6c7661edae664a7f6366201d017e24d8f42026 (diff) | |
Disable audit event logging for pipeline destruction
AuditEventService isn't equipped to handle logging of the destruction of
entities such as CI pipelines. It's a project-level event that operates
on a pipeline. The current log doesn't even indicate that the pipeline
is being destroyed.
This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9105. We're
removing the auditing call because it breaks the EE implementation.
Diffstat (limited to 'spec/services/ci/destroy_pipeline_service_spec.rb')
| -rw-r--r-- | spec/services/ci/destroy_pipeline_service_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/services/ci/destroy_pipeline_service_spec.rb b/spec/services/ci/destroy_pipeline_service_spec.rb index 097daf67feb..d896f990470 100644 --- a/spec/services/ci/destroy_pipeline_service_spec.rb +++ b/spec/services/ci/destroy_pipeline_service_spec.rb @@ -17,8 +17,8 @@ describe ::Ci::DestroyPipelineService do expect { pipeline.reload }.to raise_error(ActiveRecord::RecordNotFound) end - it 'logs an audit event' do - expect { subject }.to change { SecurityEvent.count }.by(1) + it 'does not log an audit event' do + expect { subject }.not_to change { SecurityEvent.count } end context 'when the pipeline has jobs' do |